You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/03/05 03:08:09 UTC
Review Request 31755: RU - Service Check group to include all
services with a service_check script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31755/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-9939
https://issues.apache.org/jira/browse/AMBARI-9939
Repository: ambari
Description
-------
Performing an RU will run Service Check groups after several major phases. The Service Check group needs to include all services that can run a service check. However, certain services like Pig still have service check scripts even though they only have client components.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java f8752a2
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java e40706c
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 4a733b3
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml f310b70
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/TEZ/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/31755/diff/
Testing
-------
Performed an RU request and verified that the Service Check group included one more service, namely Pig.
Waiting for unit test results.
Local unit tests passed,
OK
----------------------------------------------------------------------
Total run:609
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 31755: RU - Service Check group to include all
services with a service_check script
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31755/#review75323
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On March 4, 2015, 9:08 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31755/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 9:08 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9939
> https://issues.apache.org/jira/browse/AMBARI-9939
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Performing an RU will run Service Check groups after several major phases. The Service Check group needs to include all services that can run a service check. However, certain services like Pig still have service check scripts even though they only have client components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java f8752a2
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java e40706c
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 4a733b3
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml f310b70
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/TEZ/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31755/diff/
>
>
> Testing
> -------
>
> Performed an RU request and verified that the Service Check group included one more service, namely Pig.
> Waiting for unit test results.
>
> Local unit tests passed,
>
> OK
> ----------------------------------------------------------------------
> Total run:609
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 31755: RU - Service Check group to include all
services with a service_check script
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31755/#review75326
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 4, 2015, 9:08 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31755/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 9:08 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9939
> https://issues.apache.org/jira/browse/AMBARI-9939
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Performing an RU will run Service Check groups after several major phases. The Service Check group needs to include all services that can run a service check. However, certain services like Pig still have service check scripts even though they only have client components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java f8752a2
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java e40706c
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 4a733b3
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml f310b70
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/TEZ/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31755/diff/
>
>
> Testing
> -------
>
> Performed an RU request and verified that the Service Check group included one more service, namely Pig.
> Waiting for unit test results.
>
> Local unit tests passed,
>
> OK
> ----------------------------------------------------------------------
> Total run:609
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 31755: RU - Service Check group to include all
services with a service_check script
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31755/#review75388
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On March 5, 2015, 8:32 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31755/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 8:32 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9939
> https://issues.apache.org/jira/browse/AMBARI-9939
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Performing an RU will run Service Check groups after several major phases. The Service Check group needs to include all services that can run a service check. However, certain services like Pig still have service check scripts even though they only have client components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java f8752a2
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java e40706c
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java f9e81af
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 4a733b3
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml f310b70
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/TEZ/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31755/diff/
>
>
> Testing
> -------
>
> Performed an RU request and verified that the Service Check group included one more service, namely Pig.
> Waiting for unit test results.
>
> Local unit tests passed,
>
> OK
> ----------------------------------------------------------------------
> Total run:609
> Total errors:0
> Total failures:0
> OK
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:36.712s
> AMBARI-9939. RU - Service Check group to include all services with a service_check script (alejandro)
> [INFO] Finished at: Thu Mar 05 12:21:27 PST 2015
> [INFO] Final Memory: 67M/834M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 31755: RU - Service Check group to include all
services with a service_check script
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31755/
-----------------------------------------------------------
(Updated March 5, 2015, 8:32 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-9939
https://issues.apache.org/jira/browse/AMBARI-9939
Repository: ambari
Description
-------
Performing an RU will run Service Check groups after several major phases. The Service Check group needs to include all services that can run a service check. However, certain services like Pig still have service check scripts even though they only have client components.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java f8752a2
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java e40706c
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java f9e81af
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 4a733b3
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml f310b70
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/TEZ/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/31755/diff/
Testing (updated)
-------
Performed an RU request and verified that the Service Check group included one more service, namely Pig.
Waiting for unit test results.
Local unit tests passed,
OK
----------------------------------------------------------------------
Total run:609
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:36.712s
AMBARI-9939. RU - Service Check group to include all services with a service_check script (alejandro)
[INFO] Finished at: Thu Mar 05 12:21:27 PST 2015
[INFO] Final Memory: 67M/834M
[INFO] ------------------------------------------------------------------------
Thanks,
Alejandro Fernandez
Re: Review Request 31755: RU - Service Check group to include all
services with a service_check script
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31755/#review75277
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
<https://reviews.apache.org/r/31755/#comment122248>
In the unit test metainfo.xml files, not all services have a display name.
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
<https://reviews.apache.org/r/31755/#comment122249>
Rather than the default being true, made the default return value false.
- Alejandro Fernandez
On March 5, 2015, 2:08 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31755/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:08 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9939
> https://issues.apache.org/jira/browse/AMBARI-9939
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Performing an RU will run Service Check groups after several major phases. The Service Check group needs to include all services that can run a service check. However, certain services like Pig still have service check scripts even though they only have client components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java f8752a2
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java e40706c
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 4a733b3
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml f310b70
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/TEZ/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31755/diff/
>
>
> Testing
> -------
>
> Performed an RU request and verified that the Service Check group included one more service, namely Pig.
> Waiting for unit test results.
>
> Local unit tests passed,
>
> OK
> ----------------------------------------------------------------------
> Total run:609
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>