You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2010/09/25 16:28:36 UTC
svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Sat Sep 25 14:28:36 2010
New Revision: 1001216
URL: http://svn.apache.org/viewvc?rev=1001216&view=rev
Log:
Please no tabs.
Modified:
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216&r1=1001215&r2=1001216&view=diff
==============================================================================
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010
@@ -68,8 +68,8 @@
Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw)
</fix>
<fix>
- <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
- requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
+ <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
+ requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
</fix>
<fix>
Docs: Document SSLOptions needed for SSL information forwarding. (rjung)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Posted by Ian Darwin <ia...@darwinsys.com>.
On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote:
> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
> will be more vigilent..
Then, once you get it right, document it!
I think most settings like that can be done at a project level or
globally; if project level override is used, it gets saved in .settings,
if you commit that, everybody who starts after that will get this setting.
Be cautious with this and don't overdo it. I have in the past used
"Errors & Warnings" -> Unused Imports -> Error to ensure that other
devs would clean up imports. It's a bit draconian, but it works.
Your proposed "eclipse" target could have an <echo> to remind ppl of
whatever you've come up with...
Ian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Posted by Wesley Acheson <we...@gmail.com>.
On Sun, Sep 26, 2010 at 1:37 PM, sebb <se...@gmail.com> wrote:
> On 26 September 2010 10:00, Tim Whittington <ti...@apache.org> wrote:
>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>> will be more vigilent..
>
> Hit me too amny times.
>
> The tabs setting for the XML editor is in a different place:
> Preferences / XML / XML Files / Editor / Indent using tabs/spaces.
>
>> cheers
>> tim
>>
>> On Sun, Sep 26, 2010 at 3:28 AM, <rj...@apache.org> wrote:
>>> Author: rjung
>>> Date: Sat Sep 25 14:28:36 2010
>>> New Revision: 1001216
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1001216&view=rev
>>> Log:
>>> Please no tabs.
>>>
>>> Modified:
>>> tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>>>
>>> Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>>> URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216&r1=1001215&r2=1001216&view=diff
>>> ==============================================================================
>>> --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
>>> +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010
>>> @@ -68,8 +68,8 @@
>>> Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw)
>>> </fix>
>>> <fix>
>>> - <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
>>> - requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
>>> + <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
>>> + requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
>>> </fix>
>>> <fix>
>>> Docs: Document SSLOptions needed for SSL information forwarding. (rjung)
>>>
How about a pre-commit script that replaces ^(\t)+ with four spaces,
on files with an extension of ".java"?
Seen the tab thing come up a few times in my short subscription to this list.
Wes
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Posted by Wesley Acheson <we...@gmail.com>.
On Sun, Sep 26, 2010 at 6:05 PM, Konstantin Kolinko
<kn...@gmail.com> wrote:
> 2010/9/26 sebb <se...@gmail.com>:
>> On 26 September 2010 10:00, Tim Whittington <ti...@apache.org> wrote:
>>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>>> will be more vigilent..
>>
>> Hit me too amny times.
>>
>> The tabs setting for the XML editor is in a different place:
>> Preferences / XML / XML Files / Editor / Indent using tabs/spaces.
>>
>
> BTW, there is Preferences / General / Editors / Text Editors / Show
> whitespace characters
> that applies to all Text editors there
>
> 2010/9/26 Ian Darwin <ia...@darwinsys.com>:
>> On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote:
>>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>>> will be more vigilent..
>>
>> Then, once you get it right, document it!
>>
>> I think most settings like that can be done at a project level or
>> globally; if project level override is used, it gets saved in .settings,
>> if you commit that, everybody who starts after that will get this setting.
>
> I do not think that we should commit anything that is in ".settings".
>
> I do not mind against "eclipse.settings" though,
> so that one can rename/move that to ".settings". ;)
>
> Best regards,
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Assuming bgu 50001 passes should we copy a .settings into the project
root also? What settings should this be, though, I keep getting vague
answers to code style.
What I know
bracing style : java standard
indentation : 4 spaces
line length :80 (rigid)
multiple parameters: same line?? so long as its under 80 chrs?
xml indentation: 2 spaces??? (basing that off build.xml)
multiple xml attributes (over 80 chars)??
Anything else?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/9/26 sebb <se...@gmail.com>:
> On 26 September 2010 10:00, Tim Whittington <ti...@apache.org> wrote:
>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>> will be more vigilent..
>
> Hit me too amny times.
>
> The tabs setting for the XML editor is in a different place:
> Preferences / XML / XML Files / Editor / Indent using tabs/spaces.
>
BTW, there is Preferences / General / Editors / Text Editors / Show
whitespace characters
that applies to all Text editors there
2010/9/26 Ian Darwin <ia...@darwinsys.com>:
> On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote:
>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>> will be more vigilent..
>
> Then, once you get it right, document it!
>
> I think most settings like that can be done at a project level or
> globally; if project level override is used, it gets saved in .settings,
> if you commit that, everybody who starts after that will get this setting.
I do not think that we should commit anything that is in ".settings".
I do not mind against "eclipse.settings" though,
so that one can rename/move that to ".settings". ;)
Best regards,
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Posted by sebb <se...@gmail.com>.
On 26 September 2010 10:00, Tim Whittington <ti...@apache.org> wrote:
> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
> will be more vigilent..
Hit me too amny times.
The tabs setting for the XML editor is in a different place:
Preferences / XML / XML Files / Editor / Indent using tabs/spaces.
> cheers
> tim
>
> On Sun, Sep 26, 2010 at 3:28 AM, <rj...@apache.org> wrote:
>> Author: rjung
>> Date: Sat Sep 25 14:28:36 2010
>> New Revision: 1001216
>>
>> URL: http://svn.apache.org/viewvc?rev=1001216&view=rev
>> Log:
>> Please no tabs.
>>
>> Modified:
>> tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>>
>> Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>> URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216&r1=1001215&r2=1001216&view=diff
>> ==============================================================================
>> --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
>> +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010
>> @@ -68,8 +68,8 @@
>> Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw)
>> </fix>
>> <fix>
>> - <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
>> - requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
>> + <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
>> + requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
>> </fix>
>> <fix>
>> Docs: Document SSLOptions needed for SSL information forwarding. (rjung)
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Posted by Tim Whittington <ti...@apache.org>.
Bah. Trying to convince Eclipse not to use tabs is proving tricky -
will be more vigilent..
cheers
tim
On Sun, Sep 26, 2010 at 3:28 AM, <rj...@apache.org> wrote:
> Author: rjung
> Date: Sat Sep 25 14:28:36 2010
> New Revision: 1001216
>
> URL: http://svn.apache.org/viewvc?rev=1001216&view=rev
> Log:
> Please no tabs.
>
> Modified:
> tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>
> Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216&r1=1001215&r2=1001216&view=diff
> ==============================================================================
> --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
> +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010
> @@ -68,8 +68,8 @@
> Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw)
> </fix>
> <fix>
> - <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
> - requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
> + <bug>49511</bug>: IIS: Do not override IIS log information when subsequent
> + requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw)
> </fix>
> <fix>
> Docs: Document SSLOptions needed for SSL information forwarding. (rjung)
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org