You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/23 09:09:17 UTC

[GitHub] [spark] xuanyuanking edited a comment on pull request #31570: [SPARK-10816][SS] SessionWindow support for Structure Streaming

xuanyuanking edited a comment on pull request #31570:
URL: https://github.com/apache/spark/pull/31570#issuecomment-804069039


   @viirya @HeartSaVioR Agree with both of you. I'm also running the local benchmark. The only concern is on the `MergingSessionsIterator ` detail, it would be great if we can separate the code in the first stage and maybe refractory later.
   
   ```
   I'm dealing with update mode (required)
   ```
   If it takes too much time, I think the append mode and complete mode (maybe also optional) are good enough.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org