You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/21 08:12:13 UTC
[GitHub] [pulsar] eolivelli opened a new issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
eolivelli opened a new issue #13429:
URL: https://github.com/apache/pulsar/issues/13429
**Describe the bug**
Building OSX packages is broken, at least in 2.9.1
https://github.com/apache/pulsar/wiki/Release-process
**To Reproduce**
```
cd pulsar-client-cpp/python/pkg/osx/
$ ./generate-all-wheel.sh v2.9.1
```
**Error**
>
> default: [ 2%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerDisabled.cc.o
> default: [ 2%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainer.cc.o
> default: [ 2%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerEnabled.cc.o
> default: [ 4%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Backoff.cc.o
> default: [ 4%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Authentication.cc.o
> default: [ 5%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchAcknowledgementTracker.cc.o
> default:
> default: error
> default: :
> default:
> default: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default:
> default: make[3]:
> default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTracker.cc.o] Error 1
> default: make[3]:
> default: *** Waiting for unfinished jobs....
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: make[3]:
> default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerDisabled.cc.o] Error 1
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: make[3]:
> default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainer.cc.o] Error 1
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: make[3]:
> default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchAcknowledgementTracker.cc.o] Error 1
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: make[3]:
> default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Backoff.cc.o] Error 1
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: make[3]:
> default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Authentication.cc.o] Error 1
> default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerEnabled.cc.o] Error 1
> default: [ 7%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainerBase.cc.o
> default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
> default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainerBase.cc.o] Error 1
> default: make[2]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/all] Error 2
> default: make[1]: *** [python/CMakeFiles/_pulsar.dir/rule] Error 2
> default: make: *** [_pulsar] Error 2
> The SSH command responded with a non-zero exit status. Vagrant
> assumes that this means the command failed. The output for this command
> should be in the log above. Please read the output to determine what
> went wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063621562
I discussed with @gaoran10 a few minutes ago, it looks like there is no problem building OSX packages for 2.9.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063616257
@BewareMyPower - thanks for the extra context. I am interested to see how @eolivelli published these artifacts. It's possible that he had someone else do it for him for 2.9.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-999583013
Thank you @BewareMyPower
I will try when possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1071734304
@BewareMyPower - thanks for your note. That was very helpful. I was able to build the clients for MacOS 10.12 and 10.13 by removing that argument. https://github.com/michaeljmarshall/pulsar/commit/cb07459f336bbb85ac81e3305965a9ccd5610586
We'll want a "better" solution for the future, but for now, that was the easiest way to keep the current build solution without changing the git tag.
I couldn't build the 10.14 clients because the vagrant image is unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063648052
For reference, here is my complete log. I am running this from `pulsar-client-cpp/python/pkg/osx` and I checked out the tag `v2.8.3`.
```
$ ./generate-all-wheel.sh v2.8.3
GIT_TAG: 'v2.8.3'
GIT_REPO: 'https://github.com/apache/pulsar.git'
------------- BUILDING PYTHON WHEELS FOR osx-10.12 ---------------------
~/dev/apache/pulsar.v2.8.3/pulsar-client-cpp/python/pkg/osx/osx-10.12 ~/dev/apache/pulsar.v2.8.3/pulsar-client-cpp/python/pkg/osx
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Importing base box 'apachepulsar/osx-10.12-python-dev'...
==> default: Matching MAC address for NAT networking...
==> default: Checking if box 'apachepulsar/osx-10.12-python-dev' version '0.1' is up to date...
==> default: Setting the name of the VM: pulsar-python-osx-10.12
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
default: Adapter 1: nat
==> default: Forwarding ports...
default: 22 (guest) => 2222 (host) (adapter 1)
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
default: SSH address: 127.0.0.1:2222
default: SSH username: vagrant
default: SSH auth method: private key
==> default: Machine booted and ready!
==> default: Checking for guest additions in VM...
default: No guest additions were detected on the base box for this VM! Guest
default: additions are required for forwarded ports, shared folders, host only
default: networking, and more. If SSH fails on this machine, please install
default: the guest additions and repackage the box to continue.
default:
default: This is not an error message; everything may continue to work properly,
default: in which case you may ignore this message.
==> default: Running provisioner: shell...
default: Running: /var/folders/yl/07dpwzpn5wldvrvpf_rk1pzm0000gn/T/vagrant-shell20220309-14804-168s9hb.sh
default: + rm -rf pulsar
default: + git clone -q --depth 1 --branch v2.8.3 https://github.com/apache/pulsar.git
default: Note: checking out 'ee87c7d6c20186ae59298a9a9ec1fdb2b09954c7'.
default:
default: You are in 'detached HEAD' state. You can look around, make experimental
default: changes and commit them, and you can discard any commits you make in this
default: state without impacting any branches by performing another checkout.
default:
default: If you want to create a new branch to retain commits you create, you may
default: do so (now or later) by using -b with the checkout command again. Example:
default:
default: git checkout -b <new-branch-name>
default:
default: + cd pulsar/pulsar-client-cpp
default: + brew link --force boost
default: Warning: Already linked: /usr/local/Cellar/boost/1.68.0_1
default: To relink: brew unlink boost && brew link boost
default: + brew link --force protobuf260
default: Warning: Already linked: /usr/local/Cellar/protobuf@2.6/2.6.1
default: To relink: brew unlink protobuf@2.6 && brew link --force protobuf@2.6
default: + brew unlink python
default: Unlinking /usr/local/Cellar/python/3.7.2_1... 0 symlinks removed
default: + brew unlink boost-python3
default: Unlinking /usr/local/Cellar/boost-python3/1.68.0... 0 symlinks removed
default: + brew link --force python@2
default: Warning: Already linked: /usr/local/Cellar/python@2/2.7.15_2
default: To relink: brew unlink python@2 && brew link python@2
default: + brew link --force boost-python
default: Warning: Already linked: /usr/local/Cellar/boost-python/1.68.0
default: To relink: brew unlink boost-python && brew link boost-python
default: + cmake . -DBUILD_TESTS=OFF -DLINK_STATIC=ON -DPYTHON_LIBRARY=/usr/local/Frameworks/Python.framework/Versions/2.7/lib/libpython2.7.dylib
default: -- The C compiler identification is AppleClang 9.0.0.9000039
default: -- The CXX compiler identification is AppleClang 9.0.0.9000039
default: -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
default: -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc -- works
default: -- Detecting C compiler ABI info
default: -- Detecting C compiler ABI info - done
default: -- Detecting C compile features
default: -- Detecting C compile features - done
default: -- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++
default: -- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ -- works
default: -- Detecting CXX compiler ABI info
default: -- Detecting CXX compiler ABI info - done
default: -- Detecting CXX compile features
default: -- Detecting CXX compile features - done
default: -- ARCHITECTURE: x86_64
default: -- BUILD_DYNAMIC_LIB: ON
default: -- BUILD_STATIC_LIB: ON
default: -- BUILD_TESTS: OFF
default: -- BUILD_PYTHON_WRAPPER: ON
default: -- BUILD_PERF_TOOLS: OFF
default: -- LINK_STATIC: ON
default: -- USE_LOG4CXX: OFF
default: -- CMAKE_BUILD_TYPE: RelWithDebInfo
default: -- Looking for pthread.h
default: -- Looking for pthread.h - found
default: -- Looking for pthread_create
default: -- Looking for pthread_create - found
default: -- Found Threads: TRUE
default: -- Threads library:
default: -- Found OpenSSL: /usr/local/opt/openssl/lib/libcrypto.dylib
default: -- Protobuf_LITE_LIBRARIES: /usr/local/lib/libprotobuf-lite.a
default: -- Boost version: 1.68.0
default: -- Linking with Boost:System
default: -- Using std::regex
default: -- Boost version: 1.68.0
default: -- Found the following Boost libraries:
default: -- system
default: -- Found PythonLibs: /usr/local/Frameworks/Python.framework/Versions/2.7/lib/libpython2.7.dylib (found version "2.7.10")
default: -- PYTHON: 2.7.10
default: CMake Warning at /usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindBoost.cmake:1775 (message):
default: No header defined for python-mt; skipping header check
default: Call Stack (most recent call first):
default: CMakeLists.txt:276 (find_package)
default:
default:
default: CMake Warning at /usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindBoost.cmake:1775 (message):
default: No header defined for python-py27; skipping header check
default: Call Stack (most recent call first):
default: CMakeLists.txt:276 (find_package)
default:
default:
default: CMake Warning at /usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindBoost.cmake:1775 (message):
default: No header defined for python27-mt; skipping header check
default: Call Stack (most recent call first):
default: CMakeLists.txt:276 (find_package)
default:
default:
default: CMake Warning at /usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindBoost.cmake:1775 (message):
default: No header defined for python27-mt; skipping header check
default: Call Stack (most recent call first):
default: CMakeLists.txt:287 (find_package)
default:
default:
default: -- Boost version: 1.68.0
default: -- Found the following Boost libraries:
default: -- python27-mt
default: -- Found OpenSSL: /usr/local/opt/openssl/lib/libcrypto.a
default: -- HAS_ZSTD: 1
default: -- HAS_SNAPPY: 0
default: -- Using Boost Python libs: /usr/local/lib/libboost_python27-mt.a
default: clang-tidy not found
default: clang-format not found
default: -- Configuring done
default: -- Generating done
default: -- Build files have been written to: /Users/vagrant/pulsar/pulsar-client-cpp
default: + make _pulsar -j8
default: [ 0%] Generating ../generated/lib/PulsarApi.pb.cc, ../generated/lib/PulsarApi.pb.h
default: Scanning dependencies of target PULSAR_OBJECT_LIB
default: [ 1%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTracker.cc.o
default: [ 2%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerDisabled.cc.o
default: [ 2%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerEnabled.cc.o
default: [ 4%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Authentication.cc.o
default: [ 4%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Backoff.cc.o
default: [ 5%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchAcknowledgementTracker.cc.o
default: [ 5%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainer.cc.o
default: [ 7%] Building CXX object lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainerBase.cc.o
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Authentication.cc.o] Error 1
default: make[3]: *** Waiting for unfinished jobs....
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/Backoff.cc.o] Error 1
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerDisabled.cc.o] Error 1
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainerBase.cc.o] Error 1
default: make[3]: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTracker.cc.o] Error 1
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchMessageContainer.cc.o] Error 1
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/AckGroupingTrackerEnabled.cc.o] Error 1
default: error: unknown warning option '-Werror=cpp' [-Werror,-Wunknown-warning-option]
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/BatchAcknowledgementTracker.cc.o] Error 1
default: make[2]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/all] Error 2
default: make[1]: *** [python/CMakeFiles/_pulsar.dir/rule] Error 2
default: make: *** [_pulsar] Error 2
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063604749
That change was not verified because I don't have vagrant in my local env, just a guess from the build failure.
Maybe you can try to add `-DCMAKE_CXX_FLAGS=-Wno-unknown-warning-option` to the CMake command in `python/pkg/osx/vagrant-build.sh`. I'm not sure whether this file can be modified.
See https://stackoverflow.com/questions/41673546/clang-warning-warning-unknown-warning-option-wno-maybe-uninitialized, the option disables the warnings for unknown warning option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063639882
I wonder if there is some nuance with protobuf vs protobuf-lite? Looking into that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063457127
@BewareMyPower - how am I supposed to try that change? I am concerned because we already finalized the 2.8.3 tag, so I can't really change the code used to build the python client at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] oversearch commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
oversearch commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063663439
Hi all,
I think this may be due to my change to enable warnings as errors in the c++ client. I tested on GCC, Clang, and Visual Studio... but I don't have a Mac to test with and I'm guessing the OSX compiler is different (not sure what `AppleClang` is... I have zero experience with macs). The error message states that it doesn't know the option `-Werror=cpp`. I think if you simply strip that flag out of from the `CMakeLists.txt` file, this will go away for you.
Ideally we'd add another branch for AppleClang that has the proper flag so that this works, because warnings as errors is a valuable tool for hardening any C++ code base. Although given the range of compliers y'all need to support, maybe it's more trouble than it's worth... my experience is mostly with big commercial code bases where there's only one or two compilers that need to be supported.
Sorry for the inconvenience here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1051438382
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1071734304
@BewareMyPower - thanks for your note. That was very helpful. I was able to build the clients for MacOS 10.12 and 10.13 by removing that argument. https://github.com/michaeljmarshall/pulsar/commit/cb07459f336bbb85ac81e3305965a9ccd5610586
We'll want a "better" solution for the future, but for now, that was the easiest way to keep the current build solution without changing the git tag.
I couldn't build the 10.14 clients because the vagrant image is unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall edited a comment on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall edited a comment on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063638706
The `pulsar-client-cpp/CMakeLists.txt` looks like it could matter. Here is the diff:
```diff
mmarshall-rmbp16:pulsar michaelmarshall$ git diff v2.9.2-candidate-1..v2.8.3 pulsar-client-cpp/CMake*
diff --git a/pulsar-client-cpp/CMakeLists.txt b/pulsar-client-cpp/CMakeLists.txt
index 3fadb05a092..251d4860202 100644
--- a/pulsar-client-cpp/CMakeLists.txt
+++ b/pulsar-client-cpp/CMakeLists.txt
@@ -99,7 +99,7 @@ else() # GCC or Clang are mostly compatible:
# Options unique to Clang or GCC:
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Qunused-arguments)
- elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9))
+ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 8.1))
add_compile_options(-Wno-stringop-truncation)
endif()
endif()
@@ -139,12 +139,12 @@ unset(OPENSSL_VERSION CACHE)
if (LINK_STATIC)
find_library(ZLIB_LIBRARIES REQUIRED NAMES libz.a z zlib)
- find_library(Protobuf_LIBRARIES NAMES libprotobuf.a libprotobuf)
+ find_library(Protobuf_LITE_LIBRARIES NAMES libprotobuf-lite.a libprotobuf-lite)
find_library(CURL_LIBRARIES NAMES libcurl.a curl curl_a libcurl_a)
find_library(LIB_ZSTD NAMES libzstd.a)
find_library(LIB_SNAPPY NAMES libsnappy.a)
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
- set(COMMON_LIBS ${Protobuf_LIBRARIES} ${COMMON_LIBS})
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
+ set(COMMON_LIBS ${Protobuf_LITE_LIBRARIES} ${COMMON_LIBS})
if (USE_LOG4CXX)
if (LOG4CXX_USE_DYNAMIC_LIBS)
@@ -179,30 +179,28 @@ else()
find_package(ZLIB REQUIRED)
set(ZLIB_LIBRARIES ${ZLIB_LIBRARIES})
# NOTE: The default MODULE mode may not find debug libraries so use CONFIG mode here
- unset(Protobuf_INCLUDE_DIRS CACHE)
- unset(Protobuf_LIBRARIES CACHE)
find_package(Protobuf QUIET CONFIG)
# NOTE: On Windows x86 platform, Protobuf_FOUND might be set false but Protobuf_INCLUDE_DIRS and
- # Protobuf_LIBRARIES are both found.
- if (Protobuf_INCLUDE_DIRS AND Protobuf_LIBRARIES AND NOT Protobuf_FOUND)
+ # Protobuf_LITE_LIBRARIES are both found.
+ if (Protobuf_INCLUDE_DIRS AND Protobuf_LITE_LIBRARIES AND NOT Protobuf_FOUND)
set(Protobuf_FOUND TRUE)
endif ()
if (Protobuf_FOUND)
message("Found Protobuf in config mode")
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
message(STATUS "Protobuf_INCLUDE_DIRS: ${Protobuf_INCLUDE_DIRS}")
else ()
message("Failed to find Protobuf in config mode, try to find it from system path")
- find_library(Protobuf_LIBRARIES protobuf libprotobuf)
+ find_library(Protobuf_LITE_LIBRARIES protobuf-lite libprotobuf-lite)
find_path(Protobuf_INCLUDE_DIRS google/protobuf/stubs/common.h)
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
message(STATUS "Protobuf_INCLUDE_DIRS: ${Protobuf_INCLUDE_DIRS}")
endif ()
if (${Protobuf_FOUND} AND (${CMAKE_VERSION} VERSION_GREATER 3.8))
- set(COMMON_LIBS protobuf::libprotobuf ${COMMON_LIBS})
+ set(COMMON_LIBS protobuf::libprotobuf-lite ${COMMON_LIBS})
else ()
- set(COMMON_LIBS ${Protobuf_LIBRARIES} ${COMMON_LIBS})
+ set(COMMON_LIBS ${Protobuf_LITE_LIBRARIES} ${COMMON_LIBS})
endif ()
if (MSVC AND (${CMAKE_BUILD_TYPE} STREQUAL Debug))
@@ -459,4 +457,4 @@ add_custom_target(check-format python ${BUILD_SUPPORT_DIR}/run_clang_format.py
${CMAKE_SOURCE_DIR}/examples
${CMAKE_SOURCE_DIR}/tests
${CMAKE_SOURCE_DIR}/include
- ${CMAKE_SOURCE_DIR}/python/src)
+ ${CMAKE_SOURCE_DIR}/python/src)
\ No newline at end of file
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063412029
@eolivelli - I am seeing this same issue when running `./generate-all-wheel.sh v2.8.3`. How did you get around it to publish the python client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063638706
The `pulsar-client-cpp/CMakeLists.txt` looks like it could matter. Here is the diff:
```diff
mmarshall-rmbp16:pulsar michaelmarshall$ git diff v2.9.2-candidate-1..v2.8.3 pulsar-client-cpp/CMake*
diff --git a/pulsar-client-cpp/CMakeLists.txt b/pulsar-client-cpp/CMakeLists.txt
index 3fadb05a092..251d4860202 100644
--- a/pulsar-client-cpp/CMakeLists.txt
+++ b/pulsar-client-cpp/CMakeLists.txt
@@ -99,7 +99,7 @@ else() # GCC or Clang are mostly compatible:
# Options unique to Clang or GCC:
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Qunused-arguments)
- elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9))
+ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 8.1))
add_compile_options(-Wno-stringop-truncation)
endif()
endif()
@@ -139,12 +139,12 @@ unset(OPENSSL_VERSION CACHE)
if (LINK_STATIC)
find_library(ZLIB_LIBRARIES REQUIRED NAMES libz.a z zlib)
- find_library(Protobuf_LIBRARIES NAMES libprotobuf.a libprotobuf)
+ find_library(Protobuf_LITE_LIBRARIES NAMES libprotobuf-lite.a libprotobuf-lite)
find_library(CURL_LIBRARIES NAMES libcurl.a curl curl_a libcurl_a)
find_library(LIB_ZSTD NAMES libzstd.a)
find_library(LIB_SNAPPY NAMES libsnappy.a)
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
- set(COMMON_LIBS ${Protobuf_LIBRARIES} ${COMMON_LIBS})
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
+ set(COMMON_LIBS ${Protobuf_LITE_LIBRARIES} ${COMMON_LIBS})
if (USE_LOG4CXX)
if (LOG4CXX_USE_DYNAMIC_LIBS)
@@ -179,30 +179,28 @@ else()
find_package(ZLIB REQUIRED)
set(ZLIB_LIBRARIES ${ZLIB_LIBRARIES})
# NOTE: The default MODULE mode may not find debug libraries so use CONFIG mode here
- unset(Protobuf_INCLUDE_DIRS CACHE)
- unset(Protobuf_LIBRARIES CACHE)
find_package(Protobuf QUIET CONFIG)
# NOTE: On Windows x86 platform, Protobuf_FOUND might be set false but Protobuf_INCLUDE_DIRS and
- # Protobuf_LIBRARIES are both found.
- if (Protobuf_INCLUDE_DIRS AND Protobuf_LIBRARIES AND NOT Protobuf_FOUND)
+ # Protobuf_LITE_LIBRARIES are both found.
+ if (Protobuf_INCLUDE_DIRS AND Protobuf_LITE_LIBRARIES AND NOT Protobuf_FOUND)
set(Protobuf_FOUND TRUE)
endif ()
if (Protobuf_FOUND)
message("Found Protobuf in config mode")
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
message(STATUS "Protobuf_INCLUDE_DIRS: ${Protobuf_INCLUDE_DIRS}")
else ()
message("Failed to find Protobuf in config mode, try to find it from system path")
- find_library(Protobuf_LIBRARIES protobuf libprotobuf)
+ find_library(Protobuf_LITE_LIBRARIES protobuf-lite libprotobuf-lite)
find_path(Protobuf_INCLUDE_DIRS google/protobuf/stubs/common.h)
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
message(STATUS "Protobuf_INCLUDE_DIRS: ${Protobuf_INCLUDE_DIRS}")
endif ()
if (${Protobuf_FOUND} AND (${CMAKE_VERSION} VERSION_GREATER 3.8))
- set(COMMON_LIBS protobuf::libprotobuf ${COMMON_LIBS})
+ set(COMMON_LIBS protobuf::libprotobuf-lite ${COMMON_LIBS})
else ()
- set(COMMON_LIBS ${Protobuf_LIBRARIES} ${COMMON_LIBS})
+ set(COMMON_LIBS ${Protobuf_LITE_LIBRARIES} ${COMMON_LIBS})
endif ()
if (MSVC AND (${CMAKE_BUILD_TYPE} STREQUAL Debug))
@@ -459,4 +457,4 @@ add_custom_target(check-format python ${BUILD_SUPPORT_DIR}/run_clang_format.py
${CMAKE_SOURCE_DIR}/examples
${CMAKE_SOURCE_DIR}/tests
${CMAKE_SOURCE_DIR}/include
- ${CMAKE_SOURCE_DIR}/python/src)
+ ${CMAKE_SOURCE_DIR}/python/src)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1069701501
@oversearch - thanks for your note. An interesting detail is that we're building in a VM, so I would think we could have control over which compiler we're using. I am new to building our C++ client, so I am not very opinionated on how to solve it.
When I removed the `-Wno-error=cpp` line from the `CMakeLists.txt`, I made it further in the build, but failed with this error:
```
default: /Users/vagrant/pulsar/pulsar-client-cpp/lib/stats/ProducerStatsImpl.cc:29:45: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
default: static const std::array<double, 4> probs = {0.5, 0.9, 0.99, 0.999};
default: ^~~~~~~~~~~~~~~~~~~~~
default: { }
default: 1 error generated.
default: make[3]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/stats/ProducerStatsImpl.cc.o] Error 1
default: make[3]: *** Waiting for unfinished jobs....
default: make[2]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/all] Error 2
default: make[1]: *** [python/CMakeFiles/_pulsar.dir/rule] Error 2
default: make: *** [_pulsar] Error 2
```
Note that I don't see the `-Werror=cpp` anywhere in our repo. I only see `-Wno-error=cpp` as well as `-Werror`.
@merlimat - I'm wondering if I should have someone build this on a Linux for now so that we don't block the 2.8.3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1072751456
> Ideally we'd add another branch for AppleClang that has the proper flag so that this works, because warnings as errors is a valuable tool for hardening any C++ code base. Although given the range of compliers y'all need to support, maybe it's more trouble than it's worth... my experience is mostly with big commercial code bases where there's only one or two compilers that need to be supported.
@oversearch - is it reasonable to remove the `-Wno-error=cpp` option? Or should we pursue the branching logic based on the compiler? I can remove the option, but I'm not familiar enough with C++ to create a separate branch in the build process. I tried to add an option to ignore unknown options, but that option is itself not universal to all compilers, so that PR's build failed due to an unknown option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-999577477
Could you try this patch? At this moment I cannot test in my local env because it takes much time to install vagrant.
```diff
xuyunze@xuyunzedeMacBook-Pro pulsar % git diff
diff --git a/pulsar-client-cpp/CMakeLists.txt b/pulsar-client-cpp/CMakeLists.txt
index 3c43aa5ede8..b93b1bfc1d7 100644
--- a/pulsar-client-cpp/CMakeLists.txt
+++ b/pulsar-client-cpp/CMakeLists.txt
@@ -95,7 +95,7 @@ else() # GCC or Clang are mostly compatible:
# Turn on warnings and enable warnings-as-errors:
add_compile_options(-Wall -Wformat-security -Wvla -Werror)
# Turn off certain warnings that are too much pain for too little gain:
- add_compile_options(-Wno-sign-compare -Wno-deprecated-declarations -Wno-error=cpp)
+ add_compile_options(-Wno-sign-compare -Wno-deprecated-declarations)
if (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")
add_compile_options(-msse4.2 -mpclmul)
endif()
@@ -103,7 +103,7 @@ else() # GCC or Clang are mostly compatible:
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Qunused-arguments)
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9))
- add_compile_options(-Wno-stringop-truncation)
+ add_compile_options(-Wno-stringop-truncation -Wno-error=cpp)
endif()
endif()
```
If it doesn't work, you can just try to remove the `-Wno-error=cpp` option.
BTW, /cc @oversearch please take a look when you have time. It looks like to be caused by https://github.com/apache/pulsar/pull/11668.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063638034
@BewareMyPower - that's a helpful data point. I am looking at the diff now. It seems like nothing build related changed in `pulsar-client-cpp/python/`, so I am looking at `pulsar-client-cpp/`. Here are the changed files from the two tags:
```
mmarshall-rmbp16:pulsar michaelmarshall$ git diff --stat v2.9.2-candidate-1..v2.8.3 pulsar-client-cpp/
pulsar-client-cpp/CMakeLists.txt | 26 ++-
pulsar-client-cpp/README.md | 22 +--
pulsar-client-cpp/docker-build-centos7.sh | 2 +-
pulsar-client-cpp/docker-build.sh | 2 +-
pulsar-client-cpp/docker-format.sh | 2 +-
pulsar-client-cpp/docker-tests.sh | 4 +-
pulsar-client-cpp/docker/centos-7/Dockerfile | 15 +-
pulsar-client-cpp/include/pulsar/ConsoleLoggerFactory.h | 4 +-
pulsar-client-cpp/include/pulsar/ConsumerConfiguration.h | 32 ----
pulsar-client-cpp/include/pulsar/ConsumerEventListener.h | 49 ------
pulsar-client-cpp/include/pulsar/FileLoggerFactory.h | 4 +-
pulsar-client-cpp/include/pulsar/Reader.h | 12 --
pulsar-client-cpp/include/pulsar/Schema.h | 5 -
pulsar-client-cpp/include/pulsar/c/consumer_configuration.h | 6 -
pulsar-client-cpp/include/pulsar/c/result.h | 23 +--
pulsar-client-cpp/lib/ClientConnection.cc | 52 ++----
pulsar-client-cpp/lib/ClientConnection.h | 6 +-
pulsar-client-cpp/lib/ClientImpl.cc | 11 +-
pulsar-client-cpp/lib/Commands.cc | 12 +-
pulsar-client-cpp/lib/Commands.h | 3 +-
pulsar-client-cpp/lib/ConsumerConfiguration.cc | 23 ---
pulsar-client-cpp/lib/ConsumerConfigurationImpl.h | 3 -
pulsar-client-cpp/lib/ConsumerImpl.cc | 140 +++++++--------
pulsar-client-cpp/lib/ConsumerImpl.h | 28 +--
pulsar-client-cpp/lib/GetLastMessageIdResponse.h | 56 ++++++
pulsar-client-cpp/lib/Log4cxxLogger.cc | 3 +-
pulsar-client-cpp/{include/pulsar/ProtobufNativeSchema.h => lib/MessageIdUtil.h} | 33 ++--
pulsar-client-cpp/lib/PatternMultiTopicsConsumerImpl.cc | 10 +-
pulsar-client-cpp/lib/PatternMultiTopicsConsumerImpl.h | 15 +-
pulsar-client-cpp/lib/PeriodicTask.cc | 2 +-
pulsar-client-cpp/lib/ProtobufNativeSchema.cc | 83 ---------
pulsar-client-cpp/lib/Reader.cc | 15 --
pulsar-client-cpp/lib/ReaderImpl.cc | 4 -
pulsar-client-cpp/lib/ReaderImpl.h | 2 -
pulsar-client-cpp/lib/Schema.cc | 2 -
pulsar-client-cpp/lib/auth/AuthOauth2.cc | 5 +-
pulsar-client-cpp/lib/auth/AuthOauth2.h | 2 +
pulsar-client-cpp/lib/c/c_ConsumerConfiguration.cc | 10 --
pulsar-client-cpp/python/pulsar/schema/definition.py | 6 +-
pulsar-client-cpp/python/pulsar/schema/schema.py | 22 +--
pulsar-client-cpp/python/pulsar_test.py | 787 ++++++++++++++++++++++++++++++++++++++++++-----------------------------------------
pulsar-client-cpp/test-conf/standalone-ssl.conf | 13 +-
pulsar-client-cpp/test-conf/standalone.conf | 13 +-
pulsar-client-cpp/tests/CMakeLists.txt | 26 +--
pulsar-client-cpp/tests/ConsumerConfigurationTest.cc | 15 --
pulsar-client-cpp/tests/ConsumerTest.cc | 217 +----------------------
pulsar-client-cpp/tests/KeyBasedBatchingTest.cc | 3 +-
pulsar-client-cpp/tests/MessageIdTest.cc | 22 +++
pulsar-client-cpp/tests/PaddingDemo.proto | 26 ---
pulsar-client-cpp/tests/ProtobufNativeSchemaTest.cc | 143 ---------------
pulsar-client-cpp/tests/ReaderTest.cc | 45 +++++
pulsar-client-cpp/tests/SchemaTest.cc | 3 -
pulsar-client-cpp/tests/authentication.conf | 13 +-
pulsar-client-cpp/tests/standalone.conf | 13 +-
54 files changed, 731 insertions(+), 1364 deletions(-)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1070374003
See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html for reference.
`-Werror=` makes the specified warning into an error, while `-Wno-error=` is used to negate `-Werror=` for specified warning.
If you can modify the `CMakeLists.txt`, maybe a quickest way is to remove the ` -Werror` option, which makes all warnings into errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org