You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/02/13 21:07:12 UTC
[GitHub] [arrow-adbc] lidavidm opened a new issue, #454: [Python] Add __del__ to DBAPI objects
lidavidm opened a new issue, #454:
URL: https://github.com/apache/arrow-adbc/issues/454
Just for convenience/ease of use. Optionally we can have this emit a warning to aid debuggability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot commented on issue #454: [Python] Add __del__ to DBAPI objects
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #454:
URL: https://github.com/apache/arrow-adbc/issues/454#issuecomment-1429778055
I do tend to despise that warning (because I am inevitably running snippets of code trying to debug something and don't really care about closing connections preoperly). In R we can do `if (interactive()) { do_something } else { do_something_else }` (but I was going to leave that up to individual drivers to handle rather than attempt it at the driver manager level).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #454: [Python] Add __del__ to DBAPI objects
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #454:
URL: https://github.com/apache/arrow-adbc/issues/454#issuecomment-1429788419
Ah, for Python, it's all handled by the driver manager so it's all/nothing. I think I'll put the warning behind an environment variable to start with and see. And I might have it trip by default under pytest (though maybe it'll be annoying unless it's clear how to reproduce that outside of pytest)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm closed issue #454: [Python] Add __del__ to DBAPI objects
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed issue #454: [Python] Add __del__ to DBAPI objects
URL: https://github.com/apache/arrow-adbc/issues/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #454: [Python] Add __del__ to DBAPI objects
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #454:
URL: https://github.com/apache/arrow-adbc/issues/454#issuecomment-1429004037
Yup, but it seems people hate it when warnings get sprinkled around too much (I have a task to go revert a warning I added last release). That said there's probably a stronger case here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot commented on issue #454: [Python] Add __del__ to DBAPI objects
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #454:
URL: https://github.com/apache/arrow-adbc/issues/454#issuecomment-1428992503
FWIW a warning is what happens if you forget to close an R connection (if I'm drawing the correct parallel here):
```
Warning message:
call dbDisconnect() when finished working with a connection
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org