[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11163: refactor: Replace usages of Popover from react-bootstrap with Antd [WIP]

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #11163:
URL: https://github.com/apache/incubator-superset/pull/11163#discussion_r500001438



##########
File path: superset-frontend/spec/javascripts/components/URLShortLinkButton_spec.jsx
##########
@@ -20,7 +20,7 @@ import React from 'react';
 import configureStore from 'redux-mock-store';
 import { shallow } from 'enzyme';
 
-import { OverlayTrigger } from 'react-bootstrap';
+import Popover from 'src/common/components/Popover';

Review comment:
       please use `src/components/Popover`, which for now is just a redirection to 'src/common/components/Popover', but will allow to eventually alter/style all popover form that central point of convergence.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org