You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/09 23:09:45 UTC

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #472: Fix random printf format warnings

yamt opened a new pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472


   ## Summary
   see https://github.com/apache/incubator-nuttx/pull/2222
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r520588806



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       i dunno. i'm not familiar with this piece of code.
   is there any reason to prefer int over int32_t here?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#issuecomment-726775601


   LGTM, @yamt I will merge this PR now. If there are more nxstyle warnings, please create a new PR to address them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#issuecomment-726771874


   Ok, let's skip canutils nxstyle warning now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r522848451



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#issuecomment-726673434


   the following nxstyle errors are expected.
   ```
       examples/nrf24l01_term/nrf24l01_term.c:125:33: error: Mixed case identifier found
       examples/nrf24l01_term/nrf24l01_term.c:129:15: error: Mixed case identifier found
   ```
   
   also, canutils has a lot of nxstyle errors because it doesn't seem to follow nxstyle at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r520594056



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       two reasons here:
   
   1. Other function(e.g. moveCursorToPosition) use int
   2. Only CScrollingTextBox use int32_t, all other place use int




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r522632246



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       ok, i will fix




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r520246777



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       should we change https://github.com/apache/incubator-nuttx-apps/blob/master/include/graphics/nxwidgets/cscrollingtextbox.hxx#L329 to int instead?
   moveCursorToPosition at https://github.com/apache/incubator-nuttx-apps/blob/master/include/graphics/nxwidgets/cscrollingtextbox.hxx#L320 also need to change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #472: Fix random printf format warnings and type mismatches

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r520594056



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       two reason:
   
   1. Other function(e.g. moveCursorToPosition) use int
   2. Only CScrollingTextBox use int32_t, all other place use int




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org