[GitHub] [incubator-superset] villebro commented on a change in pull request #11393: [WIP] chore(chart-data): add annotations to chart data schema

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#discussion_r512531097



##########
File path: superset/charts/schemas.py
##########
@@ -817,6 +900,19 @@ class ChartDataQueryObjectSchema(Schema):
         "as `having_druid`.",
         deprecated=True,
     )
+    druid_time_origin = fields.String(
+        description="Starting point for time grain counting on legacy Druid "
+        "datasources. Used to change e.g. Monday/Sunday first-day-of-week. "
+        "This field is deprecated and should be passed to `extras` "
+        "as `druid_time_origin`.",
+        allow_none=True,
+    )
+    url_params = fields.Dict(
+        description="Optional query parameters passed to a dashboard or Explore view",
+        keys=fields.String(description="The query parameter"),
+        values=fields.String(description="The value of the query parameter"),
+        allow_none=True,
+    )

Review comment:
       Bycatch: this was missing, will be added to `superset-ui/core`, after which url params can be used in v1 chart data requests with jinja templates.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org