You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ad...@apache.org on 2010/02/17 21:27:26 UTC
svn propchange: r911164 - svn:log
Author: adrianc
Revision: 911164
Modified property: svn:log
Modified: svn:log at Wed Feb 17 20:27:26 2010
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Wed Feb 17 20:27:26 2010
@@ -3,3 +3,5 @@
1. Fixed a bug in TimeDuration.java reported by Adam Heath on the dev mailing list. The elapsed time constructor would produce an incorrect duration if either Calendar was prior to the epoch.
2. Fix for dealing with calendar dates that have a DAY value that is in the special window of 29-31.
+
+3. Fixed catch clause in equals method.
Re: svn propchange: r911164 - svn:log
Posted by Adam Heath <do...@brainfood.com>.
Jacques Le Roux wrote:
> Adam,
>
> What would be great would be a section about best practices using Git in
> http://cwiki.apache.org/confluence/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo
Yeah, I've been thinking about writing up a document.
The major thing that I haven't yet mentioned previously on this list,
is that I do *not* recommend moving away from svn completely, and
switching to git. Doing so would mean someone would have to be
responsible for actually pulling/merging all the various trees; this
would be a full-time job.
Re: svn propchange: r911164 - svn:log
Posted by Jacques Le Roux <ja...@les7arts.com>.
Adam,
What would be great would be a section about best practices using Git in
http://cwiki.apache.org/confluence/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo
Then we would not have to scrutinize the ML later...
Jacques
From: "Adam Heath" <do...@brainfood.com>
> adrianc@apache.org wrote:
>> Author: adrianc
>> Revision: 911164
>> Modified property: svn:log
>>
>> Modified: svn:log at Wed Feb 17 20:27:26 2010
>> ------------------------------------------------------------------------------
>> --- svn:log (original)
>> +++ svn:log Wed Feb 17 20:27:26 2010
>> @@ -3,3 +3,5 @@
>> 1. Fixed a bug in TimeDuration.java reported by Adam Heath on the dev mailing list. The elapsed time constructor would produce
>> an incorrect duration if either Calendar was prior to the epoch.
>>
>> 2. Fix for dealing with calendar dates that have a DAY value that is in the special window of 29-31.
>> +
>> +3. Fixed catch clause in equals method.
>
> And, of course, git helps me with this kind of problem. I commit
> everything, even broken, not even compile crap. Then, I run git diff,
> to see the changes in each final commit, and I then run git commit
> --amend, to change the log message to be correct. Once I get all that
> done, I then do a git svn dcommit.
>
Re: svn propchange: r911164 - svn:log
Posted by Adam Heath <do...@brainfood.com>.
adrianc@apache.org wrote:
> Author: adrianc
> Revision: 911164
> Modified property: svn:log
>
> Modified: svn:log at Wed Feb 17 20:27:26 2010
> ------------------------------------------------------------------------------
> --- svn:log (original)
> +++ svn:log Wed Feb 17 20:27:26 2010
> @@ -3,3 +3,5 @@
> 1. Fixed a bug in TimeDuration.java reported by Adam Heath on the dev mailing list. The elapsed time constructor would produce an incorrect duration if either Calendar was prior to the epoch.
>
> 2. Fix for dealing with calendar dates that have a DAY value that is in the special window of 29-31.
> +
> +3. Fixed catch clause in equals method.
And, of course, git helps me with this kind of problem. I commit
everything, even broken, not even compile crap. Then, I run git diff,
to see the changes in each final commit, and I then run git commit
--amend, to change the log message to be correct. Once I get all that
done, I then do a git svn dcommit.