[GitHub] [dubbo] aamingaa commented on a diff in pull request #11677: feat: generic timeout

["aamingaa (via GitHub)" <gi...@apache.org>]

aamingaa commented on code in PR #11677:
URL: https://github.com/apache/dubbo/pull/11677#discussion_r1162216038


##########
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/MethodConfigTest.java:
##########
@@ -431,7 +431,6 @@ void testVerifyMethodConfigOfService() {
                 .application("demo-app")
                 .service(serviceConfig)
                 .initialize();
-            Assertions.fail("Method config verification should failed");

Review Comment:
   has change to warn



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org