You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/02 03:02:33 UTC

Review Request 18667: Incorrect include in mesos-execute

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18667/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

The headers located within the common-directory should not be used via the angled include directive as those headers are not common or pre/installed but strictly belonging to the mesos source tree.


Diffs
-----

  src/cli/execute.cpp 2b5789e 

Diff: https://reviews.apache.org/r/18667/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 18667: Incorrect include in mesos-execute

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18667/#review35909
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 2, 2014, 2:02 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18667/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 2:02 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The headers located within the common-directory should not be used via the angled include directive as those headers are not common or pre/installed but strictly belonging to the mesos source tree.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 2b5789e 
> 
> Diff: https://reviews.apache.org/r/18667/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>