You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "scwhittle (via GitHub)" <gi...@apache.org> on 2023/04/11 13:51:58 UTC
[GitHub] [beam] scwhittle opened a new pull request, #26219: Add more logging to QueryChangeStreamAction exceptions
scwhittle opened a new pull request, #26219:
URL: https://github.com/apache/beam/pull/26219
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1503488019
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1509005137
That error was an authorization issue before, I don't think it is related to this PR. (sorry thought I replied on this earlier with that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1508980488
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1512939131
R: @bvolpato are you able to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26219:
URL: https://github.com/apache/beam/pull/26219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1512940884
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1503415769
@ChangyuLi28 @nancyxu123 I think this could be helpful to add these logs too
In particular I think we should log when the out-of-range exception is ignored as it could also trigger if the start timestamp is unexpectedly less than the partition range and would lead to data loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nancyxu123 commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "nancyxu123 (via GitHub)" <gi...@apache.org>.
nancyxu123 commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1504090243
>
Hi Sam, thanks for the PR. PR looks good, the additional logging could potentially be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #26219: Add more logging to QueryChangeStreamAction exceptions
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #26219:
URL: https://github.com/apache/beam/pull/26219#issuecomment-1508979661
FYI Integration Tests are failing
```
10:47:45 > Task :sdks:java:io:google-cloud-platform:integrationTest
11:05:53
11:05:53 org.apache.beam.sdk.io.gcp.spanner.SpannerReadIT > testReadWithDataBoost FAILED
11:05:53 org.apache.beam.sdk.Pipeline$PipelineExecutionException at SpannerReadIT.java:214
11:05:53 Caused by: com.google.cloud.spanner.SpannerException at SpannerExceptionFactory.java:291
11:05:53 Caused by: com.google.cloud.spanner.SpannerException at SpannerExceptionFactory.java:291
11:05:53 Caused by: io.grpc.StatusRuntimeException at Status.java:539
11:15:42
11:15:42 94 tests completed, 1 failed, 1 skipped
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org