You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Pan Jie (JIRA)" <ji...@apache.org> on 2009/01/12 04:40:59 UTC

[jira] Created: (SHINDIG-839) Argument error when MessageBundleParser::parse an error xml

Argument error when MessageBundleParser::parse an error xml
-----------------------------------------------------------

                 Key: SHINDIG-839
                 URL: https://issues.apache.org/jira/browse/SHINDIG-839
             Project: Shindig
          Issue Type: Bug
          Components: Gadget Rendering Server (PHP)
            Reporter: Pan Jie
            Priority: Minor


It seems that "$doc = @simplexml_load_string($xml);" returned false when error on interpreting xml string.
I think change "public function getMessages(SimpleXMLElement $doc)" to "public function getMessages($doc)" will fix this error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-839) Argument error when MessageBundleParser::parse an error xml

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-839.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.0-rc1
                   trunk
         Assignee: Chris Chabot

Thanks, a few people ran into this error so they'll be relieved to see it fixed :-)

Patch has been committed 

> Argument error when MessageBundleParser::parse an error xml
> -----------------------------------------------------------
>
>                 Key: SHINDIG-839
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-839
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Pan Jie
>            Assignee: Chris Chabot
>            Priority: Minor
>             Fix For: trunk, 1.0.0-rc1
>
>         Attachments: 20090112.patch
>
>
> It seems that "$doc = @simplexml_load_string($xml);" returned false when error on interpreting xml string.
> I think change "public function getMessages(SimpleXMLElement $doc)" to "public function getMessages($doc)" will fix this error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHINDIG-839) Argument error when MessageBundleParser::parse an error xml

Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pan Jie updated SHINDIG-839:
----------------------------

    Attachment: 20090112.patch

I changed "public function getMessages(SimpleXMLElement $doc)" to "public function getMessages($doc)" to fix this error.
Also I added an unittest to reproduce this exception.

> Argument error when MessageBundleParser::parse an error xml
> -----------------------------------------------------------
>
>                 Key: SHINDIG-839
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-839
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Pan Jie
>            Priority: Minor
>         Attachments: 20090112.patch
>
>
> It seems that "$doc = @simplexml_load_string($xml);" returned false when error on interpreting xml string.
> I think change "public function getMessages(SimpleXMLElement $doc)" to "public function getMessages($doc)" will fix this error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.