You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/05 07:38:13 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
morningman commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r683194583
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
##########
@@ -17,6 +17,9 @@
package org.apache.doris.analysis;
+import java.util.Arrays;
+import java.util.Map;
Review comment:
import order
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CompoundPredicate.java
##########
@@ -17,6 +17,9 @@
package org.apache.doris.analysis;
+import com.google.common.collect.Lists;
Review comment:
import order
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1020,12 +1121,21 @@ private void initAggregateBuiltins() {
// count(*)
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1037,12 +1147,21 @@ private void initAggregateBuiltins() {
// Count
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
Lists.newArrayList(t), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/FeMetaVersion.java
##########
@@ -216,6 +216,8 @@
public static final int VERSION_101 = 101;
// add data encrypt
public static final int VERSION_102 = 102;
+ // add vectorized to function
+ public static final int VERSION_103 = 103;
Review comment:
Not used?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1479,7 +1845,7 @@ private void initAggregateBuiltins() {
prefix + "13rank_finalizeEPN9doris_udf15FunctionContextERNS1_9StringValE"));
addBuiltin(AggregateFunction.createAnalyticBuiltin( "row_number",
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/AggregateFunction.java
##########
@@ -20,6 +20,7 @@
import static org.apache.doris.common.io.IOUtils.readOptionStringOrNull;
import static org.apache.doris.common.io.IOUtils.writeOptionString;
+import avro.shaded.com.google.common.collect.ImmutableSet;
Review comment:
wrong import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org