You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by jf...@apache.org on 2003/10/02 19:10:54 UTC
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java
jfarcand 2003/10/02 10:10:54
Modified: catalina/src/share/org/apache/catalina/session
StandardSession.java
Log:
Fix for bugzilla 23525 HttpSessionListener implementors are called to late according to Servlet Specification 2.4 Final Draft 3.
Revision Changes Path
1.23 +11 -7 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
Index: StandardSession.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- StandardSession.java 2 Sep 2003 21:22:01 -0000 1.22
+++ StandardSession.java 2 Oct 2003 17:10:54 -0000 1.23
@@ -575,10 +575,14 @@
*/
public boolean isValid() {
- if (!this.isValid || this.expiring) {
+ if (this.expiring){
+ return true;
+ }
+
+ if (!this.isValid ) {
return false;
}
-
+
if (maxInactiveInterval >= 0) {
long timeNow = System.currentTimeMillis();
int timeIdle = (int) ((timeNow - lastAccessedTime) / 1000L);
@@ -1154,7 +1158,7 @@
public void removeAttribute(String name, boolean notify) {
// Validate our current state
- if (!expiring && !isValid())
+ if (!isValid())
throw new IllegalStateException
(sm.getString("standardSession.removeAttribute.ise"));
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org