[GitHub] [ozone] sodonnel commented on pull request #3766: HDDS-7232. Introduce container-level lock while handling container report events by SCM and Recon

[GitBox <gi...@apache.org>]

sodonnel commented on PR #3766:
URL: https://github.com/apache/ozone/pull/3766#issuecomment-1256069274

   I think this change makes sense, but its always hard to be sure with locking changes. I'm not sure if it matters, but there are at least 2 places in the code where we call `synchronize(containerInfo)`. Eg in LegacyReplicationManager and in the AbstractContainerReportHandler. That should still be fine, as even when they call into containerManager which is changed here, the additional lock take on ContainerID should be OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org