You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/16 05:38:47 UTC

[GitHub] [nuttx] anchao opened a new pull request, #8130: net/tcp: fix potential busy loop on tcp_send_buffered.c

anchao opened a new pull request, #8130:
URL: https://github.com/apache/nuttx/pull/8130

   
   ## Summary
   
   net/tcp: fix potential busy loop on tcp_send_buffered.c 
   
   if the wrbuffer does not have enough space to send the rest of the data, then the send function will loop infinitely in nonblock mode, add send timeout check to avoid this issue.
   
   Signed-off-by: chao an <an...@xiaomi.com>
   
   ## Impact
   
   N/A
   
   ## Testing
   
   iperf tcp send test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] acassis commented on pull request #8130: net/tcp: fix potential busy loop in tcp_send_buffered.c

Posted by GitBox <gi...@apache.org>.
acassis commented on PR #8130:
URL: https://github.com/apache/nuttx/pull/8130#issuecomment-1384200023

   @anchao any idea why these "tools/Unix.mk" messages?
   
   The build system is crashing because of the an issue on uClibc++ (I think it doesn't support C++17)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] pkarashchenko commented on pull request #8130: net/tcp: fix potential busy loop in tcp_send_buffered.c

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #8130:
URL: https://github.com/apache/nuttx/pull/8130#issuecomment-1384324978

   Please rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 merged pull request #8130: net/tcp: fix potential busy loop in tcp_send_buffered.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8130:
URL: https://github.com/apache/nuttx/pull/8130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8130: net/tcp: fix potential busy loop in tcp_send_buffered.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8130:
URL: https://github.com/apache/nuttx/pull/8130#issuecomment-1384316149

   > @anchao any idea why these "tools/Unix.mk" messages?
   > 
   > The build system is crashing because of the an issue on uClibc++ (I think it doesn't support C++17)
   
   the warning is fixed here: https://github.com/apache/nuttx/pull/8133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] anchao commented on pull request #8130: net/tcp: fix potential busy loop in tcp_send_buffered.c

Posted by GitBox <gi...@apache.org>.
anchao commented on PR #8130:
URL: https://github.com/apache/nuttx/pull/8130#issuecomment-1384786750

   > Please rebase
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org