You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pr...@apache.org on 2016/06/01 07:31:22 UTC
incubator-zeppelin git commit: Change the placement of 'Repository
Information' icon with '+Create' button
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 8a409a029 -> 999abe54b
Change the placement of 'Repository Information' icon with '+Create' button
### What is this PR for?
I just changed the `Repository Information` icon placement with `+Create` button in Interpreter setting page, since the tooltip is not shown properly.
### What type of PR is it?
Improvement
### Todos
* [x] - Change the icon placement
### What is the Jira issue?
No
### How should this be tested?
After applying this PR and go to interpreter setting page. Then hover the mouse on the gear icon. That's it :)
### Screenshots (if appropriate)
- **Before**
- **After**
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: AhyoungRyu <fb...@hanmail.net>
Closes #901 from AhyoungRyu/fix/tooltipPlacement and squashes the following commits:
f352a78 [AhyoungRyu] Change the placement of 'Repository Information' icon
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/999abe54
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/999abe54
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/999abe54
Branch: refs/heads/master
Commit: 999abe54bc83596363d4c9b3905b69a22ee2b6db
Parents: 8a409a0
Author: AhyoungRyu <fb...@hanmail.net>
Authored: Thu May 19 17:04:11 2016 +0900
Committer: Prabhjyot Singh <pr...@gmail.com>
Committed: Wed Jun 1 13:01:13 2016 +0530
----------------------------------------------------------------------
zeppelin-web/src/app/interpreter/interpreter.html | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/999abe54/zeppelin-web/src/app/interpreter/interpreter.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html
index 91fa277..655ef7a 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -19,16 +19,16 @@ limitations under the License.
Interpreters
</h3>
<div class="pull-right" style="margin-top:10px;">
+ <span style="cursor:pointer;margin-right:8px;"
+ ng-click="showRepositoryInfo = !showRepositoryInfo"
+ tooltip-placement="bottom" tooltip="Repository information">
+ <i class="fa fa-cog" ng-style="{color: showRepositoryInfo ? '#3071A9' : 'black' }"></i>
+ </span>
<span class="btn btn-default fa fa-plus"
ng-click="showAddNewSetting = !showAddNewSetting"
style="margin-right:6px;">
Create
</span>
- <span style="cursor:pointer;margin-right:4px;"
- ng-click="showRepositoryInfo = !showRepositoryInfo"
- tooltip-placement="bottom" tooltip="Repository information">
- <i class="fa fa-cog" ng-style="{color: showRepositoryInfo ? '#3071A9' : 'black' }"></i>
- </span>
</div>
</div>
</div>