You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:52:43 UTC
[GitHub] [incubator-gobblin] shirshanka opened a new pull request #3058: [WIP] Improvements to Gobblin cli : a command called runOne to run a single…
shirshanka opened a new pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058
… command in standalone and MR mode
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058#discussion_r492456873
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblin.java
##########
@@ -532,7 +539,7 @@ private void dumpJStackOnTimeout(String loc) {
}
}
- private Configurable getSysConfig() {
+ public Configurable getSysConfig() {
Review comment:
Thanks for reminding me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058#discussion_r492420961
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblin.java
##########
@@ -532,7 +539,7 @@ private void dumpJStackOnTimeout(String loc) {
}
}
- private Configurable getSysConfig() {
+ public Configurable getSysConfig() {
Review comment:
Is this public just for testing? We usually put the @VisibleForTesting annotation when access is relaxed just for the purpose of testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058#discussion_r492420961
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblin.java
##########
@@ -532,7 +539,7 @@ private void dumpJStackOnTimeout(String loc) {
}
}
- private Configurable getSysConfig() {
+ public Configurable getSysConfig() {
Review comment:
Is this public just for testing? We usually put the @VisibleForTesting annotation when access is relaxed just for the purpose of testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058#discussion_r492420961
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblin.java
##########
@@ -532,7 +539,7 @@ private void dumpJStackOnTimeout(String loc) {
}
}
- private Configurable getSysConfig() {
+ public Configurable getSysConfig() {
Review comment:
Is this public just for testing? We usually put the @VisibleForTesting annotation when access is relaxed just for the purpose of testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058#discussion_r492456873
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblin.java
##########
@@ -532,7 +539,7 @@ private void dumpJStackOnTimeout(String loc) {
}
}
- private Configurable getSysConfig() {
+ public Configurable getSysConfig() {
Review comment:
Thanks for reminding me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org