You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2021/11/01 19:19:53 UTC
[GitHub] [storm] snikhil5 opened a new pull request #3422: STORM-3805 Changing error to warn for retry update operations
snikhil5 opened a new pull request #3422:
URL: https://github.com/apache/storm/pull/3422
## What is the purpose of the change
We should be able to search supervisor logs for actual errors. This seems like it should be a WARN.
## How was the change tested
None needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3422: STORM-3805 Changing error to warn for retry update operations
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741230005
##########
File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if (Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will retry again later", e);
- } else if (Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again later." , e.getClass().getName());
Review comment:
That was my preference. I've not seen it been useful. If you disagree, I'm fine keeping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3422: STORM-3805 Changing error to warn for retry update operations
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741230005
##########
File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if (Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will retry again later", e);
- } else if (Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again later." , e.getClass().getName());
Review comment:
That was my preference. I've not seen it been useful. If you disagree, I'm fine keeping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3422: STORM-3805 Changing error to warn for retry update operations
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741230005
##########
File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if (Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will retry again later", e);
- } else if (Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again later." , e.getClass().getName());
Review comment:
That was my preference. I've not seen it been useful. If you disagree, I'm fine keeping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3422: STORM-3805 Changing error to warn for retry update operations
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741228782
##########
File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if (Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will retry again later", e);
- } else if (Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again later." , e.getClass().getName());
Review comment:
This doesn't seem to log the stack trace. Is this desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3422: STORM-3805 Changing error to warn for retry update operations
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741228782
##########
File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if (Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will retry again later", e);
- } else if (Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again later." , e.getClass().getName());
Review comment:
This doesn't seem to log the stack trace. Is this desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3422: STORM-3805 Changing error to warn for retry update operations
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741228782
##########
File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if (Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will retry again later", e);
- } else if (Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again later." , e.getClass().getName());
Review comment:
This doesn't seem to log the stack trace. Is this desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org