You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/09/28 02:19:10 UTC

[GitHub] [calcite] liyafan82 opened a new pull request #2177: [CALCITE-4287] Fix the bug in checking aggregate input references in AggregateJoinRemoveRule

liyafan82 opened a new pull request #2177:
URL: https://github.com/apache/calcite/pull/2177


   See https://issues.apache.org/jira/browse/CALCITE-4287


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] liyafan82 commented on pull request #2177: [CALCITE-4287] AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #2177:
URL: https://github.com/apache/calcite/pull/2177#issuecomment-700570809


   Thanks a lot for your effort @rubenada 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] liyafan82 commented on pull request #2177: [CALCITE-4287] AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #2177:
URL: https://github.com/apache/calcite/pull/2177#issuecomment-700401525


   Slow tests validated and passed on my local machine. Thank you @rubenada 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada merged pull request #2177: [CALCITE-4287] AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

Posted by GitBox <gi...@apache.org>.
rubenada merged pull request #2177:
URL: https://github.com/apache/calcite/pull/2177


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2177: [CALCITE-4287] Fix the bug in checking aggregate input references in some rules

Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2177:
URL: https://github.com/apache/calcite/pull/2177#issuecomment-699846349


   LGTM
   Jira title (and commit message) needs to be reviewed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org