You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "vine-trellis (via GitHub)" <gi...@apache.org> on 2024/10/30 19:47:52 UTC
[PR] style(databases): update CSV and Columnar form cosmetics [superset]
vine-trellis opened a new pull request, #30758:
URL: https://github.com/apache/superset/pull/30758
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR updates the cosmetics of the "Upload file to database" form:
- Labels are be sentence cased
- Preview uploaded file switch left-aligned and moved between file upload and Columns field
Fixes #30737
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #30737
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30758:
URL: https://github.com/apache/superset/pull/30758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #30758:
URL: https://github.com/apache/superset/pull/30758#discussion_r1823306214
##########
superset-frontend/src/features/databases/UploadDataModel/index.tsx:
##########
@@ -173,6 +173,12 @@ const allowedExtensionsToAccept = {
columnar: '.parquet, .zip',
};
+const extensionsToLabel: Record<UploadType, string> = {
+ csv: 'CSV',
Review Comment:
did a double take on whether this needs to be wrapped with a18n, but i think it's right to NOT make these labels translatable, maybe "Columnar" is debatable but let's stick to non-a18n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #30758:
URL: https://github.com/apache/superset/pull/30758#discussion_r1823306214
##########
superset-frontend/src/features/databases/UploadDataModel/index.tsx:
##########
@@ -173,6 +173,12 @@ const allowedExtensionsToAccept = {
columnar: '.parquet, .zip',
};
+const extensionsToLabel: Record<UploadType, string> = {
+ csv: 'CSV',
Review Comment:
did a double take on whether this needs to be wrapped with a18n, but i think it's right to NOT make these labels translatable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #30758:
URL: https://github.com/apache/superset/pull/30758#issuecomment-2450438216
@vine-trellis feel free to bring in more test cases or add a lint rule as Evan suggested. That would be super helpful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30758:
URL: https://github.com/apache/superset/pull/30758#issuecomment-2450422754
Oops, merged before the response about test cases... but I think this is something we should handle more broadly via a lint rule, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #30758:
URL: https://github.com/apache/superset/pull/30758#issuecomment-2448329257
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #30758:
URL: https://github.com/apache/superset/pull/30758#issuecomment-2449894600
Thanks for the PR @vine-trellis! Would you please add some tests cases for these labels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30758:
URL: https://github.com/apache/superset/pull/30758#issuecomment-2450421181
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30758:
URL: https://github.com/apache/superset/pull/30758#issuecomment-2448346352
@geido Ephemeral environment spinning up at http://54.185.254.128:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org