You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/15 07:00:06 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #5996: Allow change svc offering with diff stg tags

Pearl1594 opened a new pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996


   ### Description
   
   This PR addresses https://github.com/apache/cloudstack/issues/5512
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040081590


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040100713


   <b>Trillian Build Failed (tid-3338)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044063504


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1041017338


   <b>Trillian test result (tid-3349)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32791 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5996-t3349-kvm-centos7.zip
   Smoke tests completed. 91 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_nic | `Error` | 134.06 | test_nic.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040080878


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040491275


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2622


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040353934


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040170111


   <b>Trillian Build Failed (tid-3343)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1043972223


   I had tested it with mai - but using non customized offering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044022912


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040369781


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2619


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040493510


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044023833


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040214511


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040355786


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040081984


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040100713


   <b>Trillian Build Failed (tid-3338)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040420976


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040043613






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040151374


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040215415


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040100713


   <b>Trillian Build Failed (tid-3338)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044114110


   > Yes @weizhouapache, you are correct. And @Pearl1594 's last commit will fix that issue of "The new disk offering requires that a size be specified."
   
   @harikrishna-patnala  thanks. that's great. 
    @Pearl1594 thanks for the fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044061285


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044802190


   <b>Trillian test result (tid-3386)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31130 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5996-t3386-kvm-centos7.zip
   Smoke tests completed. 92 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044014156


   Yes @weizhouapache, you are correct. And @Pearl1594 's last commit will fix that issue of "The new disk offering requires that a size be specified."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040492296


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040272747


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040044053


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040043613


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040044053






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 edited a comment on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1043972223


   I had tested it with main - but using non customized offering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040419909


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1043235134


   @Pearl1594 
   did you test with 4.16 or 4.17 ?
   
   I faced an issue when I tested this PR in 4.17 by following steps
   (1) create a service offering with storage tag
   (2) update storage tag of pool to same tag
   (3) scale vm to new service offering, works
   (4) change global setting to `false`, when scale vm to default "Small Instance". got an exception: "The new disk offering requires that a size be specified."
   
   I think it is caused by @harikrishna-patnala 's PR #5008
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1044062905


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland merged pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5996: Allow scaling VM to a service offering having different storage tags

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5996:
URL: https://github.com/apache/cloudstack/pull/5996#issuecomment-1040153075


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org