[GitHub] [dubbo-go] zouyx commented on a change in pull request #520: Feature: CI with Docker

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427419710



##########
File path: test/integrate/dubbo/go-client/go.mod
##########
@@ -0,0 +1,3 @@
+module github.com/apache/dubbo-go/test/integrate/dubbo/go-client
+
+go 1.14

Review comment:
       in main package go version is 1.13 , should u change it? if not , may cause compile problem.
   
   https://github.com/apache/dubbo-go/blob/master/go.mod

##########
File path: test/integrate/dubbo/go-server/go.mod
##########
@@ -0,0 +1,3 @@
+module github.com/apache/dubbo-go/test/integrate/dubbo/go-server
+
+go 1.14

Review comment:
       in main package go version is 1.13 , should u change it? if not , may cause compile problem.
   
   https://github.com/apache/dubbo-go/blob/master/go.mod

##########
File path: test/integrate/dubbo/go-client/Dockerfile
##########
@@ -0,0 +1,21 @@
+FROM golang
+
+MAINTAINER scottwangsxll@gmail.com

Review comment:
       what is it mean?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org