You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Arnaud Bienvenu <ar...@generasound.com> on 2001/09/05 14:58:34 UTC

XSPCookieHelper bug [PATCH]

Unless I am mistaken, the <xsp-cookie:getValue name="blahblah"/> tag will
not work properly if there are several cookies sent in the request. I think
you should apply this tiny patch :

Index: ./src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java
===================================================================
RCS file: /home/cvspublic/xml-cocoon2/src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java,v
retrieving revision 1.2.2.5
diff -u -r1.2.2.5 XSPCookieHelper.java
--- ./src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java	2001/08/20 14:07:27	1.2.2.5
+++ ./src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java	2001/09/05 12:51:48
@@ -651,7 +651,10 @@
                     currentCookie = cookies[count];
 
                     if (currentCookie.getName().equals(cookieName))
+                    {
                         matchFound = true;
+                        break;
+                    }
                 }
             }
             else if (retrieveByIndex)

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: XSPCookieHelper bug [PATCH]

Posted by Davanum Srinivas <di...@yahoo.com>.
Arnaud,

Thanks for the patch. Have checked it into both C2.0 and C2.1.

-- dims

--- Arnaud Bienvenu <ar...@generasound.com> wrote:
> Unless I am mistaken, the <xsp-cookie:getValue name="blahblah"/> tag will
> not work properly if there are several cookies sent in the request. I think
> you should apply this tiny patch :
> 
> Index: ./src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java
> ===================================================================
> RCS file:
>
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java,v
> retrieving revision 1.2.2.5
> diff -u -r1.2.2.5 XSPCookieHelper.java
> --- ./src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java	2001/08/20
> 14:07:27	1.2.2.5
> +++ ./src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java	2001/09/05
> 12:51:48
> @@ -651,7 +651,10 @@
>                      currentCookie = cookies[count];
>  
>                      if (currentCookie.getName().equals(cookieName))
> +                    {
>                          matchFound = true;
> +                        break;
> +                    }
>                  }
>              }
>              else if (retrieveByIndex)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 


=====
Davanum Srinivas, JNI-FAQ Manager
http://www.jGuru.com/faq/JNI

__________________________________________________
Do You Yahoo!?
Get email alerts & NEW webcam video instant messaging with Yahoo! Messenger
http://im.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org