You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/12/22 14:32:45 UTC
[PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
suyanhanx opened a new pull request, #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435131910
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
> To group those services that are already available under wasm32?
I feel like this feature flag is meaningless. I don't want to expose arch related feature flag to users.
Adding an array in shell is good enough to me.
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
> To group those services that are already available under wasm32?
I feel like this feature flag is meaningless. I don't want to expose arch related feature flag to users.
Adding an array in shell is good enough to me for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435127855
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
> We could set a new feature flag for wasm32.
Why? wasm32 is a new arch, not a feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435127855
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
> We could set a new feature flag for wasm32.
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435125743
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435133022
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435129296
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
To group those services that are already available under wasm32?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435120001
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
Let's extend this like we do for `build_all_platforms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435144404
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
> For this, I mean: do you want us to have `services-enabled-x86_64`, `services-enabled-wasm32`, `services-enabled-aarch64`?
It's a bit wired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435127645
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
We could set a new feature flag for wasm32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/azblob): available under wasm32 arch [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3806:
URL: https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435133012
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features --features=services-s3,services-azblob
Review Comment:
> I don't want to expose arch related feature flag to users.
For this, I mean: do you want us to have `services-enabled-x86_64`, `services-enabled-wasm32`, `services-enabled-aarch64`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org