[GitHub] [trafficserver] bneradt commented on a diff in pull request #9304: Fix build issues in H3 unit tests

[GitBox <gi...@apache.org>]

bneradt commented on code in PR #9304:
URL: https://github.com/apache/trafficserver/pull/9304#discussion_r1069785208


##########
iocore/net/quic/Mock.h:
##########
@@ -652,6 +664,8 @@ class MockQUICContext : public QUICContext
   {
     return _config;
   }
+#if HAVE_QUICHE_H
+#else

Review Comment:
   `#ifndef HAVE_QUICHE_H`



##########
iocore/net/quic/Mock.h:
##########
@@ -246,6 +255,8 @@ class MockQUICStreamManager : public QUICStreamManagerImpl
   MockQUICStreamManager(QUICContext *context) : QUICStreamManagerImpl(context, nullptr) {}
 
   // Override
+#if HAVE_QUICHE_H
+#else

Review Comment:
   Maybe: `#ifndef HAVE_QUICHE_H`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org