You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/06 10:23:00 UTC
[jira] [Commented] (STORM-810) PartitionManager in storm-kafka
should commit latest offset before close
[ https://issues.apache.org/jira/browse/STORM-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530138#comment-14530138 ]
ASF GitHub Bot commented on STORM-810:
--------------------------------------
GitHub user tedxia opened a pull request:
https://github.com/apache/storm/pull/545
STORM-810: PartitionManager should commit latest offset before close
PR for [STORM-810](https://issues.apache.org/jira/browse/STORM-810)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedxia/storm commit-before-PartitionManager-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #545
----
commit 0380a42f7ddaf48ce17eabb67ec18a27cd258f69
Author: xiajun <xi...@xiaomi.com>
Date: 2015-05-06T08:19:44Z
STORM-810: PartitionManager should commit latest offset before close
----
> PartitionManager in storm-kafka should commit latest offset before close
> -------------------------------------------------------------------------
>
> Key: STORM-810
> URL: https://issues.apache.org/jira/browse/STORM-810
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Affects Versions: 0.10.0, 0.11.0
> Reporter: xiajun
> Assignee: xiajun
>
> When KafkaSpout refresh with kafka partitions, it will remove patitions that no longer served by this spout and close the connection. But before close the connection, PartitionManager don't commit the latest offset. As a result some other spout that serve the removed partition will replay some tuple that between last commit and close.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)