You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/29 06:28:02 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1695: [CALCITE-3606] Derive target table column list by mistake when conver…

jinxing64 commented on a change in pull request #1695: [CALCITE-3606] Derive target table column list by mistake when conver…
URL: https://github.com/apache/calcite/pull/1695#discussion_r361829839
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
 ##########
 @@ -702,7 +702,7 @@ public Result visit(TableModify modify) {
 
       final SqlInsert sqlInsert =
           new SqlInsert(POS, SqlNodeList.EMPTY, sqlTargetTable, sqlSource,
-              identifierList(modify.getInput().getRowType().getFieldNames()));
+              identifierList(modify.getTable().getRowType().getFieldNames()));
 
 
 Review comment:
   Thanks, Danny~
   I will refine by your comments soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services