[jira] [Comment Edited] (FLINK-3952) Bump Netty to 4.1

["Alexey Diomin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018605#comment-16018605 ] 

Alexey Diomin edited comment on FLINK-3952 at 5/20/17 8:52 PM:
---------------------------------------------------------------

No, you mistake.
try 
{code}
jar tvf flink-dist_2.10-1.2.1.jar  | grep netty
{code}

you found then shaded only old version of netty 3.х, 
but addition we distributed without shading 3.х and current used version of netty 4.0.x 
{code}
org/apache/flink/hadoop/shaded/org/jboss/netty/
org/jboss/netty/
io/netty/
{code}

as result if you try use Apache Beam with Flink you have error like https://gist.github.com/xhumanoid/291d7bfc50f830857971c15c34083351

reason it's mix netty 4.1 from beam and netty 4.0 from flink
current hotfix for me it's exclude netty from my result jar for app with beam, but it's potential problem because beam use grpc which require netty 4.1

but because tv.cntt:netty-router:jar:1.10:compile work with netty 4.0 only isn't possible update to netty 4.1.

netty-router looks like was dropped from any support =(


was (Author: humanoid):
No, you mistake.
try 
{code}
jar tvf flink-dist_2.10-1.2.1.jar  | grep netty
{code}

you found then shaded only old version of netty 3.х, 
but addition we distributed without shading 3.х and current used version of netty 4.0.x 
{code}
org/apache/flink/hadoop/shaded/org/jboss/netty/
org/jboss/netty/
io/netty/
{code}

as result if you try use Apache Beam with Flink you have error like https://gist.github.com/xhumanoid/291d7bfc50f830857971c15c34083351

reason it's mix netty 4.1 from beam and netty 4.0 from flink
current hotfix for me it's exclude netty from my result jar for app with beam, but it's potential problem because beam use grpc which require netty 4.1

> Bump Netty to 4.1
> -----------------
>
>                 Key: FLINK-3952
>                 URL: https://issues.apache.org/jira/browse/FLINK-3952
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Network
>            Reporter: rektide de la fey
>              Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of significant enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in particular I find HTTP/2 codecs to be incredibly desirable to have. 
> Additionally, hopefully, the [Hadoop patches for Netty 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and get merged, & I believe if/when that happens it'll be important for Flink to also be using the new Netty minor version.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)