[GitHub] [incubator-druid] leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline

[GitBox <gi...@apache.org>]

leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline
URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474084476
 
 
   @gianm it's not a bug that `DruidCoordinatorLogger` uses this method. `@VisibleForTesting` is also used to "explain" why some method is package-private rather than private or public rather than package-private. There is no annotation in Guava for methods that should be used *only* in test code.
   
   It seems that the right way to express this is to add "InTest" suffix to the method name and also say in Javadoc comment that the method should be called only from test code. ~~But we can create an annotation like "@ForTestsOnly".~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org