You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/19 20:23:51 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here

john-bodley opened a new pull request #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here
URL: https://github.com/apache/incubator-superset/pull/9331
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   Per https://github.com/apache/incubator-superset/pull/9323 there is merit in preventing Celery version 4.4.1 from being installed. Note that version 4.4.2 was released recently and currently we're unsure if this is also problematic for our configuration.
    
   ### TEST PLAN
   
   Ran `pip-compile setup.py`.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @etr2460 @villebro 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on issue #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here
URL: https://github.com/apache/incubator-superset/pull/9331#issuecomment-601456290
 
 
   I think just marking 4.4.1 bad is good enough. you'll be on the git blame for this line now, so hopefully if anyone decides to upgrade in the future, they'll loop you in first

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley merged pull request #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here
URL: https://github.com/apache/incubator-superset/pull/9331
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9331: [requirements] Telling Celery version 4.4.1 it is not welcome here
URL: https://github.com/apache/incubator-superset/pull/9331#discussion_r395298496
 
 

 ##########
 File path: requirements-dev.txt
 ##########
 @@ -22,7 +22,7 @@ ipdb==0.12
 isort==4.3.21
 mypy==0.670
 nose==1.3.7
-pip-tools==3.7.0
+pip-tools==4.5.1
 
 Review comment:
   I needed to bump this to work with the latest version of `pip`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org