[GitHub] [nifi] exceptionfactory commented on a change in pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5451:
URL: https://github.com/apache/nifi/pull/5451#discussion_r726186297



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -136,6 +136,16 @@
             .defaultValue("true")
             .build();
 
+    public static final PropertyDescriptor INCLUDE_CUSTOM_EXTENSIONS = new PropertyDescriptor.Builder()
+            .name("INCLUDE_CUSTOM_EXTENSIONS")
+            .displayName("Include custom extensions")
+            .description("If set to true, custom extensions (not specified in the CEF specifications) will be "
+                    + "included in the generated data/attributes.")
+            .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+            .required(true)

Review comment:
       As a new property, should required be set to `false` to maintain backward compatibility?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org