You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/06/17 16:28:59 UTC
Review Request 35566: Refactor executorEnvironment to take
slave::Flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35566/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-2832
https://issues.apache.org/jira/browse/MESOS-2832
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/containerizer.hpp 0b67d1bdf157b2db927699f44fa8210bacb76701
src/slave/containerizer/containerizer.cpp e995ce602261c18373ac09c823638c4a252cca86
src/slave/containerizer/docker.hpp 395d5352ad70ed4b7f954d82b1b93e18ca4b74e5
src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147
src/slave/containerizer/external_containerizer.cpp 33fc010393e1e664c3b50d849284b14275b29377
src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426
Diff: https://reviews.apache.org/r/35566/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 35566: Refactor executorEnvironment to take
slave::Flags.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On June 18, 2015, 1:01 a.m., Till Toenshoff wrote:
> > src/tests/containerizer.cpp, line 124
> > <https://reviews.apache.org/r/35566/diff/1/?file=986478#file986478line124>
> >
> > This indention will very soon not comply with our styleguide anymore, no?
No, it will, we still wrap the same way for 'for' and 'foreach*'.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35566/#review88320
-----------------------------------------------------------
On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35566/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 2:28 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-2832
> https://issues.apache.org/jira/browse/MESOS-2832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0b67d1bdf157b2db927699f44fa8210bacb76701
> src/slave/containerizer/containerizer.cpp e995ce602261c18373ac09c823638c4a252cca86
> src/slave/containerizer/docker.hpp 395d5352ad70ed4b7f954d82b1b93e18ca4b74e5
> src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147
> src/slave/containerizer/external_containerizer.cpp 33fc010393e1e664c3b50d849284b14275b29377
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
> src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426
>
> Diff: https://reviews.apache.org/r/35566/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 35566: Refactor executorEnvironment to take
slave::Flags.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35566/#review88320
-----------------------------------------------------------
Ship it!
src/slave/containerizer/containerizer.hpp (lines 132 - 144)
<https://reviews.apache.org/r/35566/#comment140781>
Nice!
src/tests/containerizer.cpp (line 124)
<https://reviews.apache.org/r/35566/#comment140779>
This indention will very soon not comply with our styleguide anymore, no?
src/tests/containerizer.cpp (line 136)
<https://reviews.apache.org/r/35566/#comment140777>
See above.
- Till Toenshoff
On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35566/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 2:28 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-2832
> https://issues.apache.org/jira/browse/MESOS-2832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0b67d1bdf157b2db927699f44fa8210bacb76701
> src/slave/containerizer/containerizer.cpp e995ce602261c18373ac09c823638c4a252cca86
> src/slave/containerizer/docker.hpp 395d5352ad70ed4b7f954d82b1b93e18ca4b74e5
> src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147
> src/slave/containerizer/external_containerizer.cpp 33fc010393e1e664c3b50d849284b14275b29377
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
> src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426
>
> Diff: https://reviews.apache.org/r/35566/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>