You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:02:11 UTC

[GitHub] [hive] zabetak opened a new pull request #2107: HIVE-24886: Support simple equality operations between MAP/LIST/STRUCT types

zabetak opened a new pull request #2107:
URL: https://github.com/apache/hive/pull/2107


   ### What changes were proposed in this pull request?
   
   1. Refactor GenericUDFBaseCompare#initialize to allow equalities between
   MAP/LIST/STRUCT types and improve readability.
   2. Add positive and negative parameterized tests for GenericUDF#initialize
   method with various argument types.
   3. Re-work and unify messages in UDFArgumentException when types do not
   match.
   4. Add positive qtests for MAP, LIST, and, STRUCT types and different UDFs.
   
   ### Why are the changes needed?
   1. Allow simple comparisons between non primitive types.
   2. Avoid unexpected parse and runtime exceptions when performing comparisons involving MAP, LIST, STRUCT types.
   3. Extend test coverage of comparisons operators on STRUCT, LIST, MAP, and primitive types.
   
   ### Does this PR introduce _any_ user-facing change?
   Allows more SQL queries and provides proper failure information when comparisons are not supported.
   
   ### How was this patch tested?
   ```
   mvn test -Dtest=TestGenericUDFInitializeOnCompareUDF
   mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile="equals_map_types.q,equals_list_types.q,equals_struct_types.q" 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] jcamachor merged pull request #2107: HIVE-24886: Support simple equality operations between MAP/LIST/STRUCT types

Posted by GitBox <gi...@apache.org>.
jcamachor merged pull request #2107:
URL: https://github.com/apache/hive/pull/2107


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org