[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9173: [fix] SQL query source

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9173: [fix] SQL query source
URL: https://github.com/apache/incubator-superset/pull/9173#discussion_r381810132
 
 

 ##########
 File path: superset/models/core.py
 ##########
 @@ -314,6 +314,12 @@ def get_sqla_engine(
         params.update(self.get_encrypted_extra())
 
         if DB_CONNECTION_MUTATOR:
+            if not source and request and request.referrer:
 
 Review comment:
   This is similar logic to what was defined in `get_df` however it's been pushed further up the stack. Note we only try to mutate the source if it isn't explicitly defined. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org