You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/31 13:21:13 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #6292: doc: polish the documentations on ALS and MS
kezhenxu94 opened a new pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292
Polish the doc on ALS and MS as they are outdated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (dda8d19) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `12.50%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 40.32% -12.51%
+ Complexity 3793 2295 -1498
=============================================
Files 1732 778 -954
Lines 36915 19322 -17593
Branches 4071 1830 -2241
=============================================
- Hits 19504 7792 -11712
+ Misses 16434 10937 -5497
+ Partials 977 593 -384
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (dda8d19) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `6.58%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 46.24% -6.59%
+ Complexity 3793 3252 -541
============================================
Files 1732 945 -787
Lines 36915 23389 -13526
Branches 4071 2284 -1787
============================================
- Hits 19504 10817 -8687
+ Misses 16434 11622 -4812
+ Partials 977 950 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1262 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#discussion_r567427417
##########
File path: docs/en/setup/envoy/als_setting.md
##########
@@ -48,9 +60,31 @@ helm repo add elastic https://helm.elastic.co
helm dep up skywalking
-helm install 8.1.0 skywalking -n istio-system --set oap.env.SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh --set fullnameOverride=skywalking --set oap.envoy.als.enabled=true
+helm install 8.1.0 skywalking -n istio-system \
+ --set oap.env.SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh \
+ --set fullnameOverride=skywalking \
+ --set oap.envoy.als.enabled=true
```
-Notice, only use this when Envoy is under Istio's control, and they are in k8s environment. The OAP requires the read right to k8s API server for all pods IPs.
+You can use `kubectl -n istio-system logs -l app=skywalking | grep "K8sALSServiceMeshHTTPAnalysis"` to ensure OAP ALS `k8s-mesh` analyzer has been activated.
+
+A more detailed tutorial can be found [on the website](https://skywalking.apache.org/blog/2020-12-03-obs-service-mesh-with-sw-and-als/).
+
+## SkyWalking ALS Analyzers
+
+There are two available analyzers, `k8s-mesh` and `mx-mesh`, you can specify one or more analyzers to analyze the access logs.
+When multiple analyzers are specified, it acts as a fast-success mechanism: SkyWalking loops over the analyzers and use it to analyze the logs, once
+there is an analyzer that is able to produce a result, it stops the loop.
+
+### `k8s-mesh`
+
+`k8s-mesh` uses the metadata from Kubernetes cluster, hence in this analyzer OAP needs access roles to `Pod`, `Service`, and `Endpoints`.
+
+The [blog](https://skywalking.apache.org/blog/2020-12-03-obs-service-mesh-with-sw-and-als/) illustrates the detail of how it works, and a step-by-step tutorial to apply it into the `bookinfo` application.
+
+### `mx-mesh`
+
+`mx-mesh` uses the Envoy metadata exchange mechanism to get the service name, etc.,
+this analyzer requires Istio to enable the metadata exchange plugin (you can enable it by `--set values.telemetry.v2.enabled=true`,
+or if you're using Istio 1.7+ and installing it with profile `demo`/`preview`, it should be enabled then).
Review comment:
Consider to add both of your writes at the end of this doc again, referencing to SkyWalking website's version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `5.62%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 47.21% -5.63%
+ Complexity 3793 3310 -483
============================================
Files 1732 945 -787
Lines 36915 23389 -13526
Branches 4071 2284 -1787
============================================
- Hits 19504 11042 -8462
+ Misses 16434 11394 -5040
+ Partials 977 953 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `8.32%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 44.51% -8.33%
+ Complexity 3793 2557 -1236
============================================
Files 1732 795 -937
Lines 36915 19822 -17093
Branches 4071 1882 -2189
============================================
- Hits 19504 8823 -10681
+ Misses 16434 10323 -6111
+ Partials 977 676 -301
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1323 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#discussion_r567427275
##########
File path: docs/en/setup/envoy/metrics_service_setting.md
##########
@@ -1,6 +1,19 @@
-# Configuring Envoy to send metrics to SkyWalking
+# Send Envoy metrics to SkyWalking with / without Istio
-In order to let Envoy to send metrics to SkyWalking, we need to feed Envoy with a configuration which contains `stats_sinks` that includes `envoy.metrics_service`.
+Envoy defines a gRPC service to emit the metrics, whatever implements this protocol can be used to receive the metrics.
+SkyWalking has a built-in receiver that implements this protocol so that you can configure Envoy to emit its metrics to SkyWalking.
+
+As an APM system, SkyWalking does not only receive and store the metrics emitted by Envoy, it also analyzes the topology of services and service instances.
+
+**Attention:** There are two versions of Envoy metrics service protocol up to date,
+[v2](https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/grpc_service.proto#envoy-api-msg-core-grpcservice) and
+[v3](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/metrics_service.proto), SkyWalking (8.3.0+) supports both of them.
+
+## Configure Envoy to send metrics to SkyWalking without Istio
Review comment:
Will the name format mechanism fail if there is no Istio?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (116760e) into [master](https://codecov.io/gh/apache/skywalking/commit/93165abc2a074bef1f62b889f2eaa9c7c87bde6e?el=desc) (93165ab) will **increase** coverage by `10.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
+ Coverage 37.18% 47.26% +10.08%
- Complexity 2688 3312 +624
=============================================
Files 941 945 +4
Lines 23010 23378 +368
Branches 2215 2284 +69
=============================================
+ Hits 8556 11050 +2494
+ Misses 13722 11373 -2349
- Partials 732 955 +223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...p/server/telemetry/none/NoneTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9Ob25lVGVsZW1ldHJ5UHJvdmlkZXIuamF2YQ==) | `30.00% <0.00%> (-70.00%)` | `3.00% <0.00%> (-5.00%)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `4.34% <0.00%> (-52.18%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ap/server/telemetry/none/MetricsCollectorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ29sbGVjdG9yTm9vcC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <0.00%> (-43.75%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `28.57% <0.00%> (-42.86%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [198 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (dda8d19) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `6.45%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 46.38% -6.46%
+ Complexity 3793 3201 -592
============================================
Files 1732 928 -804
Lines 36915 22889 -14026
Branches 4071 2232 -1839
============================================
- Hits 19504 10616 -8888
+ Misses 16434 11337 -5097
+ Partials 977 936 -41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1269 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (9f39337) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **increase** coverage by `4.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
+ Coverage 52.83% 57.60% +4.77%
+ Complexity 3793 803 -2990
============================================
Files 1732 170 -1562
Lines 36915 4128 -32787
Branches 4071 477 -3594
============================================
- Hits 19504 2378 -17126
+ Misses 16434 1447 -14987
+ Partials 977 303 -674
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `18.60% <0.00%> (-55.82%)` | `6.00% <0.00%> (-1.00%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `14.28% <0.00%> (-49.78%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [1639 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (9f39337) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `11.88%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 40.95% -11.89%
+ Complexity 3793 2903 -890
=============================================
Files 1732 928 -804
Lines 36915 22846 -14069
Branches 4071 2213 -1858
=============================================
- Hits 19504 9356 -10148
+ Misses 16434 12669 -3765
+ Partials 977 821 -156
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `11.11% <ø> (-38.89%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (dda8d19) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `16.48%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 36.34% -16.49%
+ Complexity 3793 2111 -1682
=============================================
Files 1732 778 -954
Lines 36915 19287 -17628
Branches 4071 1824 -2247
=============================================
- Hits 19504 7010 -12494
+ Misses 16434 11736 -4698
+ Partials 977 541 -436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `11.11% <ø> (-38.89%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (9f39337) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `11.88%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 40.95% -11.89%
+ Complexity 3793 2903 -890
=============================================
Files 1732 928 -804
Lines 36915 22846 -14069
Branches 4071 2213 -1858
=============================================
- Hits 19504 9356 -10148
+ Misses 16434 12669 -3765
+ Partials 977 821 -156
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `11.11% <ø> (-38.89%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...f0b2cbc](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (9f39337) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `11.88%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 40.95% -11.89%
+ Complexity 3793 2903 -890
=============================================
Files 1732 928 -804
Lines 36915 22846 -14069
Branches 4071 2213 -1858
=============================================
- Hits 19504 9356 -10148
+ Misses 16434 12669 -3765
+ Partials 977 821 -156
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `11.11% <ø> (-38.89%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...f0b2cbc](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (dda8d19) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `5.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 47.01% -5.82%
+ Complexity 3793 3303 -490
============================================
Files 1732 945 -787
Lines 36915 23389 -13526
Branches 4071 2284 -1787
============================================
- Hits 19504 10997 -8507
+ Misses 16434 11439 -4995
+ Partials 977 953 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (dda8d19) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `16.48%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 36.34% -16.49%
+ Complexity 3793 2111 -1682
=============================================
Files 1732 778 -954
Lines 36915 19287 -17628
Branches 4071 1824 -2247
=============================================
- Hits 19504 7010 -12494
+ Misses 16434 11736 -4698
+ Partials 977 541 -436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `11.11% <ø> (-38.89%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2a245ca...9f39337](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `10.33%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 42.49% -10.34%
+ Complexity 3793 2464 -1329
=============================================
Files 1732 795 -937
Lines 36915 19822 -17093
Branches 4071 1882 -2189
=============================================
- Hits 19504 8424 -11080
+ Misses 16434 10744 -5690
+ Partials 977 654 -323
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#discussion_r567428201
##########
File path: docs/en/setup/envoy/metrics_service_setting.md
##########
@@ -1,6 +1,19 @@
-# Configuring Envoy to send metrics to SkyWalking
+# Send Envoy metrics to SkyWalking with / without Istio
-In order to let Envoy to send metrics to SkyWalking, we need to feed Envoy with a configuration which contains `stats_sinks` that includes `envoy.metrics_service`.
+Envoy defines a gRPC service to emit the metrics, whatever implements this protocol can be used to receive the metrics.
+SkyWalking has a built-in receiver that implements this protocol so that you can configure Envoy to emit its metrics to SkyWalking.
+
+As an APM system, SkyWalking does not only receive and store the metrics emitted by Envoy, it also analyzes the topology of services and service instances.
+
+**Attention:** There are two versions of Envoy metrics service protocol up to date,
+[v2](https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/grpc_service.proto#envoy-api-msg-core-grpcservice) and
+[v3](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/metrics_service.proto), SkyWalking (8.3.0+) supports both of them.
+
+## Configure Envoy to send metrics to SkyWalking without Istio
Review comment:
The name format still works w/o Istio if the metadata is injected, check line 55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `16.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 36.21% -16.62%
+ Complexity 3793 2100 -1693
=============================================
Files 1732 778 -954
Lines 36915 19281 -17634
Branches 4071 1811 -2260
=============================================
- Hits 19504 6983 -12521
+ Misses 16434 11760 -4674
+ Partials 977 538 -439
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `11.11% <ø> (-38.89%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1363 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (116760e) into [master](https://codecov.io/gh/apache/skywalking/commit/93165abc2a074bef1f62b889f2eaa9c7c87bde6e?el=desc) (93165ab) will **decrease** coverage by `0.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 37.18% 36.37% -0.81%
+ Complexity 2688 2110 -578
============================================
Files 941 778 -163
Lines 23010 19283 -3727
Branches 2215 1826 -389
============================================
- Hits 8556 7015 -1541
+ Misses 13722 11728 -1994
+ Partials 732 540 -192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/telemetry/none/NoneTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9Ob25lVGVsZW1ldHJ5UHJvdmlkZXIuamF2YQ==) | `30.00% <0.00%> (-70.00%)` | `3.00% <0.00%> (-5.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [244 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `13.39%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 52.83% 39.43% -13.40%
+ Complexity 3793 2310 -1483
=============================================
Files 1732 795 -937
Lines 36915 19822 -17093
Branches 4071 1882 -2189
=============================================
- Hits 19504 7817 -11687
+ Misses 16434 11415 -5019
+ Partials 977 590 -387
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `0.00% <ø> (-52.64%)` | `0.00 <0.00> (-5.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `0.00% <ø> (-63.75%)` | `0.00 <0.00> (-8.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1337 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `4.63%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 48.19% -4.64%
+ Complexity 3793 3310 -483
============================================
Files 1732 1731 -1
Lines 36915 36867 -48
Branches 4071 4066 -5
============================================
- Hits 19504 17769 -1735
- Misses 16434 18121 +1687
Partials 977 977
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...walking/oap/server/core/query/LogQueryService.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTG9nUXVlcnlTZXJ2aWNlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/query/type/Log.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvdHlwZS9Mb2cuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...kywalking/oap/query/graphql/resolver/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0xvZ1F1ZXJ5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (bb32380) into [master](https://codecov.io/gh/apache/skywalking/commit/93165abc2a074bef1f62b889f2eaa9c7c87bde6e?el=desc) (93165ab) will **decrease** coverage by `16.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
=============================================
- Coverage 46.05% 29.65% -16.40%
=============================================
Files 941 1638 +697
Lines 23211 34341 +11130
Branches 2265 4530 +2265
=============================================
- Hits 10689 10184 -505
- Misses 11587 23210 +11623
- Partials 935 947 +12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/oap/server/core/source/Endpoint.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmModule.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1Nb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/oap/server/core/config/ConfigService.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29uZmlnL0NvbmZpZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1623 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `5.62%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 47.21% -5.63%
+ Complexity 3793 3310 -483
============================================
Files 1732 945 -787
Lines 36915 23389 -13526
Branches 4071 2284 -1787
============================================
- Hits 19504 11042 -8462
+ Misses 16434 11394 -5040
+ Partials 977 953 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <ø> (-58.42%)` | `2.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `6.38% <ø> (-51.87%)` | `1.00 <0.00> (-6.00)` | |
| [...storage/plugin/jdbc/h2/dao/H2LogRecordBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUmVjb3JkQnVpbGRlci5qYXZh) | `50.00% <ø> (+1.21%)` | `2.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/source/AbstractLog.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Fic3RyYWN0TG9nLmphdmE=) | `80.00% <100.00%> (+5.00%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (116760e) into [master](https://codecov.io/gh/apache/skywalking/commit/93165abc2a074bef1f62b889f2eaa9c7c87bde6e?el=desc) (93165ab) will **increase** coverage by `7.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
+ Coverage 37.18% 44.47% +7.28%
+ Complexity 2688 2550 -138
============================================
Files 941 795 -146
Lines 23010 19811 -3199
Branches 2215 1882 -333
============================================
+ Hits 8556 8810 +254
+ Misses 13722 10323 -3399
+ Partials 732 678 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/telemetry/none/NoneTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9Ob25lVGVsZW1ldHJ5UHJvdmlkZXIuamF2YQ==) | `30.00% <0.00%> (-70.00%)` | `3.00% <0.00%> (-5.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (116760e) into [master](https://codecov.io/gh/apache/skywalking/commit/93165abc2a074bef1f62b889f2eaa9c7c87bde6e?el=desc) (93165ab) will **increase** coverage by `7.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
+ Coverage 37.18% 44.57% +7.39%
+ Complexity 2688 2500 -188
============================================
Files 941 778 -163
Lines 23010 19317 -3693
Branches 2215 1830 -385
============================================
+ Hits 8556 8611 +55
+ Misses 13722 10043 -3679
+ Partials 732 663 -69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/telemetry/none/NoneTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9Ob25lVGVsZW1ldHJ5UHJvdmlkZXIuamF2YQ==) | `30.00% <0.00%> (-70.00%)` | `3.00% <0.00%> (-5.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (116760e) into [master](https://codecov.io/gh/apache/skywalking/commit/93165abc2a074bef1f62b889f2eaa9c7c87bde6e?el=desc) (93165ab) will **increase** coverage by `7.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
+ Coverage 37.18% 44.52% +7.33%
+ Complexity 2688 2556 -132
============================================
Files 941 795 -146
Lines 23010 19811 -3199
Branches 2215 1882 -333
============================================
+ Hits 8556 8820 +264
+ Misses 13722 10313 -3409
+ Partials 732 678 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/telemetry/none/NoneTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9Ob25lVGVsZW1ldHJ5UHJvdmlkZXIuamF2YQ==) | `30.00% <0.00%> (-70.00%)` | `3.00% <0.00%> (-5.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [347 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [93165ab...bb32380](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#issuecomment-770384052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=h1) Report
> Merging [#6292](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=desc) (ff0db7c) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `4.63%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6292 +/- ##
============================================
- Coverage 52.83% 48.19% -4.64%
+ Complexity 3793 3310 -483
============================================
Files 1732 1731 -1
Lines 36915 36867 -48
Branches 4071 4066 -5
============================================
- Hits 19504 17769 -1735
- Misses 16434 18121 +1687
Partials 977 977
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `50.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...walking/oap/server/core/query/LogQueryService.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTG9nUXVlcnlTZXJ2aWNlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/query/type/Log.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvdHlwZS9Mb2cuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <ø> (-71.43%)` | `0.00 <0.00> (-3.00)` | |
| [...kywalking/oap/query/graphql/resolver/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0xvZ1F1ZXJ5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.03% <ø> (-49.61%)` | `1.00 <0.00> (-4.00)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6292/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=footer). Last update [2739b71...18408c3](https://codecov.io/gh/apache/skywalking/pull/6292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6292: doc: polish the documentations on ALS and MS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6292:
URL: https://github.com/apache/skywalking/pull/6292#discussion_r567427519
##########
File path: docs/en/setup/envoy/als_setting.md
##########
@@ -48,9 +60,31 @@ helm repo add elastic https://helm.elastic.co
helm dep up skywalking
-helm install 8.1.0 skywalking -n istio-system --set oap.env.SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh --set fullnameOverride=skywalking --set oap.envoy.als.enabled=true
+helm install 8.1.0 skywalking -n istio-system \
+ --set oap.env.SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh \
+ --set fullnameOverride=skywalking \
+ --set oap.envoy.als.enabled=true
```
-Notice, only use this when Envoy is under Istio's control, and they are in k8s environment. The OAP requires the read right to k8s API server for all pods IPs.
+You can use `kubectl -n istio-system logs -l app=skywalking | grep "K8sALSServiceMeshHTTPAnalysis"` to ensure OAP ALS `k8s-mesh` analyzer has been activated.
+
+A more detailed tutorial can be found [on the website](https://skywalking.apache.org/blog/2020-12-03-obs-service-mesh-with-sw-and-als/).
Review comment:
This duplicates with L83, consider to keep one only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org