You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/08/16 18:18:30 UTC
[GitHub] storm pull request #2807: STORM-3199: Remove metrics-ganglia due to LGPL dep...
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2807
STORM-3199: Remove metrics-ganglia due to LGPL dependency
https://issues.apache.org/jira/browse/STORM-3199
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3199
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2807
----
commit 806bb11ca26b5caa41c6d0ef7c4658855219cec3
Author: Stig Rohde Døssing <sr...@...>
Date: 2018-08-16T18:04:11Z
STORM-3199: Remove metrics-ganglia due to LGPL dependency
----
---
[GitHub] storm issue #2807: STORM-3199: Remove metrics-ganglia due to LGPL dependency
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Rerunning test, it had some trouble pulling dependencies from Maven
---
[GitHub] storm issue #2807: STORM-3199: Remove metrics-ganglia due to LGPL dependency
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Posted a discuss thread on the mailing list.
---
[GitHub] storm issue #2807: STORM-3199: Remove metrics-ganglia due to LGPL dependency
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2807
@srdo
I guess it worths to discuss in user/dev mailing list, cause I don't know who is using Ganglia Reporter. Actually I feel Metrics V2 may not be used actively, so IMHO the risk is small, but we may want to do some kinds of poll before removing anyway. If someone is using the Ganglia Reporter for 1.x, we can deprecate it for 1.x and remove in 2.0.
---
[GitHub] storm pull request #2807: STORM-3199: Remove metrics-ganglia due to LGPL dep...
Posted by srdo <gi...@git.apache.org>.
Github user srdo closed the pull request at:
https://github.com/apache/storm/pull/2807
---
[GitHub] storm issue #2807: STORM-3199: Remove metrics-ganglia due to LGPL dependency
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Thanks for reviewing @HeartSaVioR. It can't, I'll open another PR against 1.x shortly
---
[GitHub] storm pull request #2807: STORM-3199: Remove metrics-ganglia due to LGPL dep...
Posted by srdo <gi...@git.apache.org>.
GitHub user srdo reopened a pull request:
https://github.com/apache/storm/pull/2807
STORM-3199: Remove metrics-ganglia due to LGPL dependency
https://issues.apache.org/jira/browse/STORM-3199
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3199
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2807
----
commit 806bb11ca26b5caa41c6d0ef7c4658855219cec3
Author: Stig Rohde Døssing <sr...@...>
Date: 2018-08-16T18:04:11Z
STORM-3199: Remove metrics-ganglia due to LGPL dependency
----
---
[GitHub] storm issue #2807: STORM-3199: Remove metrics-ganglia due to LGPL dependency
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Raised https://github.com/apache/storm/pull/2809.
On 1.x the LGPL dependency is excluded so people can install it manually. If we want to keep metrics-ganglia, we could probably make that change instead of removing the dependency entirely.
I'm not sure it makes sense for us to keep metrics-ganglia though, since the Metrics library maintainers have decided to drop it. We'll be unable to upgrade past Metrics 3.2.x if we decide to keep the dependency.
What do you think @HeartSaVioR?
---
[GitHub] storm pull request #2807: STORM-3199: Remove metrics-ganglia due to LGPL dep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2807
---