You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by feng lu <am...@gmail.com> on 2013/01/15 07:54:33 UTC
pass null NutchDocument BasicIndexingFilter
Hi All
In BasicIndexingFilter.java , it has not check the null of NutchDocument,
Shoud we add such code in the filter method in BasicIndexingFilter.
// just in case
if (doc == null)
return doc;
thanks all
--
Don't Grow Old, Grow Up... :-)
Re: pass null NutchDocument BasicIndexingFilter
Posted by feng lu <am...@gmail.com>.
yes, Markus, The IndexerMapReduce will ensure that Document is not null.
Thanks Lewis and Markus.
On Wed, Jan 16, 2013 at 3:20 AM, Markus Jelsma
<ma...@openindex.io>wrote:
> This should be implemented in IndexerMapReduce. I haven't committed the
> patch yet that skips documents.
>
>
>
> -----Original message-----
> > From:Lewis John Mcgibbney <le...@gmail.com>
> > Sent: Tue 15-Jan-2013 19:23
> > To: dev@nutch.apache.org
> > Subject: Re: pass null NutchDocument BasicIndexingFilter
> >
> > Hi,
> >
> > Although this is a trivial patch, if you could open a Jira issue so we
> can track it this would be excellent.
> > Please also describe where you would like to add this to the code.
> > If you could submit a patch that would be excellent.
> > Thank you
> > Lewis
> >
> > On Mon, Jan 14, 2013 at 10:54 PM, feng lu <amuseme.lu@gmail.com <mailto:
> amuseme.lu@gmail.com> > wrote:
> > Hi All
> >
> > In BasicIndexingFilter.java , it has not check the null of
> NutchDocument, Shoud we add such code in the filter method in
> BasicIndexingFilter.
> >
> > // just in case
> > if (doc == null)
> > return doc;
> >
> > thanks all
> >
> > --
> > Don't Grow Old, Grow Up... :-)
> >
> >
> >
> > --
> > Lewis
> >
>
--
Don't Grow Old, Grow Up... :-)
RE: pass null NutchDocument BasicIndexingFilter
Posted by Markus Jelsma <ma...@openindex.io>.
This should be implemented in IndexerMapReduce. I haven't committed the patch yet that skips documents.
-----Original message-----
> From:Lewis John Mcgibbney <le...@gmail.com>
> Sent: Tue 15-Jan-2013 19:23
> To: dev@nutch.apache.org
> Subject: Re: pass null NutchDocument BasicIndexingFilter
>
> Hi,
>
> Although this is a trivial patch, if you could open a Jira issue so we can track it this would be excellent.
> Please also describe where you would like to add this to the code.
> If you could submit a patch that would be excellent.
> Thank you
> Lewis
>
> On Mon, Jan 14, 2013 at 10:54 PM, feng lu <amuseme.lu@gmail.com <ma...@gmail.com> > wrote:
> Hi All
>
> In BasicIndexingFilter.java , it has not check the null of NutchDocument, Shoud we add such code in the filter method in BasicIndexingFilter.
>
> // just in case
> if (doc == null)
> return doc;
>
> thanks all
>
> --
> Don't Grow Old, Grow Up... :-)
>
>
>
> --
> Lewis
>
Re: pass null NutchDocument BasicIndexingFilter
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi,
Although this is a trivial patch, if you could open a Jira issue so we can
track it this would be excellent.
Please also describe where you would like to add this to the code.
If you could submit a patch that would be excellent.
Thank you
Lewis
On Mon, Jan 14, 2013 at 10:54 PM, feng lu <am...@gmail.com> wrote:
> Hi All
>
> In BasicIndexingFilter.java , it has not check the null of NutchDocument,
> Shoud we add such code in the filter method in BasicIndexingFilter.
>
> // just in case
> if (doc == null)
> return doc;
>
> thanks all
>
> --
> Don't Grow Old, Grow Up... :-)
>
--
*Lewis*