You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/10/27 21:52:13 UTC
Review Request 63376: Started `LocalResourceProviderDaemon` after
obtaining the slave ID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63376/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
Bugs: MESOS-8097
https://issues.apache.org/jira/browse/MESOS-8097
Repository: mesos
Description
-------
The local resource provider daemon is now started aftor we get a slave
id (either through registration or recovery). The slave id will be
eventually passed into each local resource provider for checkpointing.
Diffs
-----
src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263
src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed
src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
Diff: https://reviews.apache.org/r/63376/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 63376: Started `LocalResourceProviderDaemon` after
obtaining the slave ID.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63376/#review191678
-----------------------------------------------------------
Fix it, then Ship it!
src/resource_provider/daemon.cpp
Lines 182-184 (patched)
<https://reviews.apache.org/r/63376/#comment269530>
I'd just use `.put(info->name(), info.get())` here
- Jie Yu
On Nov. 20, 2017, 11:15 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63376/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2017, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8097
> https://issues.apache.org/jira/browse/MESOS-8097
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The local resource provider daemon is now started aftor we get a slave
> id (either through registration or recovery). The slave id will be
> eventually passed into each local resource provider for checkpointing
> their metadata.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263
> src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed
> src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
>
>
> Diff: https://reviews.apache.org/r/63376/diff/3/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 63376: Started `LocalResourceProviderDaemon` after
obtaining the slave ID.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63376/
-----------------------------------------------------------
(Updated Nov. 20, 2017, 11:15 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Load all configs in `initialize()` but launch the resource providers in `start()`.
Bugs: MESOS-8097
https://issues.apache.org/jira/browse/MESOS-8097
Repository: mesos
Description
-------
The local resource provider daemon is now started aftor we get a slave
id (either through registration or recovery). The slave id will be
eventually passed into each local resource provider for checkpointing
their metadata.
Diffs (updated)
-----
src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263
src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed
src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
Diff: https://reviews.apache.org/r/63376/diff/3/
Changes: https://reviews.apache.org/r/63376/diff/2-3/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63376: Started `LocalResourceProviderDaemon` after
obtaining the slave ID.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63376/
-----------------------------------------------------------
(Updated Nov. 17, 2017, 12:13 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Constructed the process object during daemon creation but spawned it later when `start()` is called. This enables us to accept reload requests even before `start()` is called by the agent. Also made the daemon fail-fast if the config dir cannot be read.
Bugs: MESOS-8097
https://issues.apache.org/jira/browse/MESOS-8097
Repository: mesos
Description (updated)
-------
The local resource provider daemon is now started aftor we get a slave
id (either through registration or recovery). The slave id will be
eventually passed into each local resource provider for checkpointing
their metadata.
Diffs (updated)
-----
src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263
src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed
src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
Diff: https://reviews.apache.org/r/63376/diff/2/
Changes: https://reviews.apache.org/r/63376/diff/1-2/
Testing
-------
make
Thanks,
Chun-Hung Hsiao