You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by et...@apache.org on 2020/02/27 18:35:59 UTC
[storm] branch master updated: [STORM-3591] change log level to
debug for scheduling left over sys tasks
This is an automated email from the ASF dual-hosted git repository.
ethanli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/storm.git
The following commit(s) were added to refs/heads/master by this push:
new cc058eb [STORM-3591] change log level to debug for scheduling left over sys tasks
new 79b181d Merge pull request #3218 from RuiLi8080/STORM-3591
cc058eb is described below
commit cc058eb805217448df33b6173d6cbf011496415b
Author: Rui Li <ru...@verizonmedia.com>
AuthorDate: Wed Feb 26 10:19:13 2020 -0600
[STORM-3591] change log level to debug for scheduling left over sys tasks
---
.../resource/strategies/scheduling/DefaultResourceAwareStrategy.java | 3 ++-
.../resource/strategies/scheduling/GenericResourceAwareStrategy.java | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java b/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
index 6c3c1f7..ba1d7c2 100644
--- a/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
+++ b/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
@@ -79,7 +79,8 @@ public class DefaultResourceAwareStrategy extends BaseResourceAwareStrategy impl
}
executorsNotScheduled.removeAll(scheduledTasks);
- LOG.debug("/* Scheduling left over task (most likely sys tasks) */");
+ LOG.debug("Scheduling left over tasks {} (most likely sys tasks) from topology {}",
+ executorsNotScheduled, td.getId());
// schedule left over system tasks
for (ExecutorDetails exec : executorsNotScheduled) {
if (Thread.currentThread().isInterrupted()) {
diff --git a/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/GenericResourceAwareStrategy.java b/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/GenericResourceAwareStrategy.java
index b2555f2..790ada2 100644
--- a/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/GenericResourceAwareStrategy.java
+++ b/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/GenericResourceAwareStrategy.java
@@ -120,7 +120,8 @@ public class GenericResourceAwareStrategy extends BaseResourceAwareStrategy impl
executorsNotScheduled.removeAll(scheduledTasks);
if (!executorsNotScheduled.isEmpty()) {
- LOG.warn("Scheduling {} left over task (most likely sys tasks)", executorsNotScheduled);
+ LOG.debug("Scheduling left over tasks {} (most likely sys tasks) from topology {}",
+ executorsNotScheduled, td.getId());
// schedule left over system tasks
for (ExecutorDetails exec : executorsNotScheduled) {
if (Thread.currentThread().isInterrupted()) {