You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by upthewaterspout <gi...@git.apache.org> on 2017/03/01 19:16:41 UTC

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode-examples/pull/3#discussion_r103763443
  
    --- Diff: partitioned/src/main/java/org/apache/geode/examples/partitioned/BaseClient.java ---
    @@ -0,0 +1,79 @@
    +/*
    --- End diff --
    
    Nitpick - I feel like this BaseClient actually makes the code less readable. It might be better to just create the caches and regions inline in the producer and consumer, and just have a static class that has the common properties.
    
    Also, getRegion1 and getRegion2 aren't very descriptive method names.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---