You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "one-data-cookie (via GitHub)" <gi...@apache.org> on 2023/05/19 13:47:47 UTC
[GitHub] [superset] one-data-cookie opened a new issue, #24136: `/api/v1/dataset/{pk}/refresh` overrides `columns.filterable` and `columns.groupby` to `true`
one-data-cookie opened a new issue, #24136:
URL: https://github.com/apache/superset/issues/24136
API method `/api/v1/dataset/{pk}/refresh` overrides `columns.groupby` and `columns.filterable` to `true` regardless of their settings. Surprisingly, this doesn't happen when the same is triggered from UI.
#### How to reproduce the bug
1. Create/Use a dataset with columns that have `Is filterable` and/or `Is dimension` unticked
2. Sync columns from source (to see it working from UI)
3. Call `/api/v1/dataset/{pk}/refresh` on given dataset (to see it _not_ working via API)
### Expected results
Columns are kept untouched (provided there is no change to the underlying query/data, ofc, no matter from where the refresh is triggered.
### Actual results
`filterable`/`Is filterable` and `groupby`/`Is dimension` are changed to `true`
#### Screenshots
Before anything.
After refreshing from UI.
After refreshing via API.
### Environment
- superset version: `2.1.0`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] `/api/v1/dataset/{pk}/refresh` overrides `columns.filterable` and `columns.groupby` to `true` [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24136:
URL: https://github.com/apache/superset/issues/24136#issuecomment-1977346592
I'm not sure if this is still an issue in current versions of Superset (3.x). If it is, we can re-open this, or feel free to open a new issue with updated context and a reproducible case we can try. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] `/api/v1/dataset/{pk}/refresh` overrides `columns.filterable` and `columns.groupby` to `true` [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #24136: `/api/v1/dataset/{pk}/refresh` overrides `columns.filterable` and `columns.groupby` to `true`
URL: https://github.com/apache/superset/issues/24136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] a-othman commented on issue #24136: `/api/v1/dataset/{pk}/refresh` overrides `columns.filterable` and `columns.groupby` to `true`
Posted by "a-othman (via GitHub)" <gi...@apache.org>.
a-othman commented on issue #24136:
URL: https://github.com/apache/superset/issues/24136#issuecomment-1630697394
Hello @one-data-cookie , is this end point "/api/v1/dataset/{pk}/refresh" working with you, cause I can't get it to work with me. it gives me "405 Error: METHOD NOT ALLOWED". I am using a PUT method as per the documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] one-data-cookie commented on issue #24136: `/api/v1/dataset/{pk}/refresh` overrides `columns.filterable` and `columns.groupby` to `true`
Posted by "one-data-cookie (via GitHub)" <gi...@apache.org>.
one-data-cookie commented on issue #24136:
URL: https://github.com/apache/superset/issues/24136#issuecomment-1634154682
@a-othman As far as I know `PUT` requests are only supported if CSRF tokens are disabled in Superset (`WTF_CSRF_ENABLED=False`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org