You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/07 17:33:26 UTC
[GitHub] [hadoop-ozone] prashantpogde opened a new pull request #783:
HDDS-2976. Recon throws error while trying to get snapshot over https
prashantpogde opened a new pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783
## What changes were proposed in this pull request?
Making getOzoneManagerDBSnapshot work over https.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2976
## How was this patch tested?
- Manual Test in a secure environment
- Unit Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx merged pull request #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #783: HDDS-2976. Recon
throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-611346415
The conflict with `master` still remains. Resolved it locally, pushed to https://github.com/adoroszlai/hadoop-ozone/commit/a0152d8530bc29fc038f8a395030361cebb4a5a7, please feel free to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-611342060
Yup, fixed this in new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on a change in pull request
#783: HDDS-2976. Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#discussion_r405970213
##########
File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconUtils.java
##########
@@ -166,9 +168,11 @@ public int read() throws IOException {
}
});
- InputStream inputStream = new ReconUtils()
- .makeHttpCall(httpClientMock, url);
- String contents = IOUtils.toString(inputStream, Charset.defaultCharset());
+ String contents;
+ try (InputStream inputStream = new ReconUtils()
+ .makeHttpCall(httpClientMock, url)) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request
#783: HDDS-2976. Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#discussion_r405065768
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java
##########
@@ -245,6 +246,16 @@ public InputStream makeHttpCall(CloseableHttpClient httpClient, String url)
}
}
+ public InputStream makeHttpCall(URLConnectionFactory connectionFactory,
Review comment:
Can we remove the other makeHttpCall that accepts CloseableHttpClient if it is no longer used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on a change in pull request
#783: HDDS-2976. Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#discussion_r405970156
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java
##########
@@ -245,6 +246,16 @@ public InputStream makeHttpCall(CloseableHttpClient httpClient, String url)
}
}
+ public InputStream makeHttpCall(URLConnectionFactory connectionFactory,
+ String url)
+ throws IOException {
+
+ java.net.URLConnection urlConnection =
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-611352162
Uploaded new commits to address all review comments. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-612322340
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde removed a comment on issue #783:
HDDS-2976. Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde removed a comment on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-611867107
The reported failures seem to be preexisting ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-613035510
Thank you for the fix @prashantpogde, and the reviews @vivekratnavel & @adoroszlai.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request
#783: HDDS-2976. Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#discussion_r405065739
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java
##########
@@ -245,6 +246,16 @@ public InputStream makeHttpCall(CloseableHttpClient httpClient, String url)
}
}
+ public InputStream makeHttpCall(URLConnectionFactory connectionFactory,
+ String url)
+ throws IOException {
+
+ java.net.URLConnection urlConnection =
Review comment:
NIT: We can import java.net.URLConnection and java.net.URL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-612170412
@prashantpogde Can you rebase this branch with the current master, so we can get a clean CI run? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request
#783: HDDS-2976. Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#discussion_r405260217
##########
File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconUtils.java
##########
@@ -166,9 +168,11 @@ public int read() throws IOException {
}
});
- InputStream inputStream = new ReconUtils()
- .makeHttpCall(httpClientMock, url);
- String contents = IOUtils.toString(inputStream, Charset.defaultCharset());
+ String contents;
+ try (InputStream inputStream = new ReconUtils()
+ .makeHttpCall(httpClientMock, url)) {
Review comment:
Can we modify the unit test to test the new makeHttpCall API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-611857054
Fixed all comments as suggested above. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] prashantpogde commented on issue #783: HDDS-2976.
Recon throws error while trying to get snapshot over https
Posted by GitBox <gi...@apache.org>.
prashantpogde commented on issue #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#issuecomment-611867107
The reported failures seem to be preexisting ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org