You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/08/28 14:48:26 UTC
[26/51] [partial] hbase-site git commit: Published site at
3afe9fb7e6ebfa71187cbe131558a83fae61cecd.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/424d7e41/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.html
index 8ea4be9..1788f01 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.html
@@ -28,66 +28,72 @@
<span class="sourceLineNo">020</span>import java.io.IOException;<a name="line.20"></a>
<span class="sourceLineNo">021</span>import org.apache.hadoop.hbase.ServerName;<a name="line.21"></a>
<span class="sourceLineNo">022</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.22"></a>
-<span class="sourceLineNo">023</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.RegionCloseOperation;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.RemoteOperation;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.CloseRegionProcedureStateData;<a name="line.29"></a>
-<span class="sourceLineNo">030</span><a name="line.30"></a>
-<span class="sourceLineNo">031</span>/**<a name="line.31"></a>
-<span class="sourceLineNo">032</span> * The remote procedure used to close a region.<a name="line.32"></a>
-<span class="sourceLineNo">033</span> */<a name="line.33"></a>
-<span class="sourceLineNo">034</span>@InterfaceAudience.Private<a name="line.34"></a>
-<span class="sourceLineNo">035</span>public class CloseRegionProcedure extends RegionRemoteProcedureBase {<a name="line.35"></a>
-<span class="sourceLineNo">036</span><a name="line.36"></a>
-<span class="sourceLineNo">037</span> // For a region move operation, we will assign the region after we unassign it, this is the target<a name="line.37"></a>
-<span class="sourceLineNo">038</span> // server for the subsequent assign. We will send this value to RS, and RS will record the region<a name="line.38"></a>
-<span class="sourceLineNo">039</span> // in a Map to tell client that where the region has been moved to. Can be null. And also, can be<a name="line.39"></a>
-<span class="sourceLineNo">040</span> // wrong(but do not make it wrong intentionally). The client can handle this error.<a name="line.40"></a>
-<span class="sourceLineNo">041</span> private ServerName assignCandidate;<a name="line.41"></a>
-<span class="sourceLineNo">042</span><a name="line.42"></a>
-<span class="sourceLineNo">043</span> public CloseRegionProcedure() {<a name="line.43"></a>
-<span class="sourceLineNo">044</span> super();<a name="line.44"></a>
-<span class="sourceLineNo">045</span> }<a name="line.45"></a>
-<span class="sourceLineNo">046</span><a name="line.46"></a>
-<span class="sourceLineNo">047</span> public CloseRegionProcedure(RegionInfo region, ServerName targetServer,<a name="line.47"></a>
-<span class="sourceLineNo">048</span> ServerName assignCandidate) {<a name="line.48"></a>
-<span class="sourceLineNo">049</span> super(region, targetServer);<a name="line.49"></a>
-<span class="sourceLineNo">050</span> this.assignCandidate = assignCandidate;<a name="line.50"></a>
-<span class="sourceLineNo">051</span> }<a name="line.51"></a>
-<span class="sourceLineNo">052</span><a name="line.52"></a>
-<span class="sourceLineNo">053</span> @Override<a name="line.53"></a>
-<span class="sourceLineNo">054</span> public TableOperationType getTableOperationType() {<a name="line.54"></a>
-<span class="sourceLineNo">055</span> return TableOperationType.REGION_UNASSIGN;<a name="line.55"></a>
-<span class="sourceLineNo">056</span> }<a name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span> @Override<a name="line.58"></a>
-<span class="sourceLineNo">059</span> public RemoteOperation remoteCallBuild(MasterProcedureEnv env, ServerName remote) {<a name="line.59"></a>
-<span class="sourceLineNo">060</span> return new RegionCloseOperation(this, region, assignCandidate);<a name="line.60"></a>
-<span class="sourceLineNo">061</span> }<a name="line.61"></a>
-<span class="sourceLineNo">062</span><a name="line.62"></a>
-<span class="sourceLineNo">063</span> @Override<a name="line.63"></a>
-<span class="sourceLineNo">064</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.64"></a>
-<span class="sourceLineNo">065</span> super.serializeStateData(serializer);<a name="line.65"></a>
-<span class="sourceLineNo">066</span> CloseRegionProcedureStateData.Builder builder = CloseRegionProcedureStateData.newBuilder();<a name="line.66"></a>
-<span class="sourceLineNo">067</span> if (assignCandidate != null) {<a name="line.67"></a>
-<span class="sourceLineNo">068</span> builder.setAssignCandidate(ProtobufUtil.toServerName(assignCandidate));<a name="line.68"></a>
-<span class="sourceLineNo">069</span> }<a name="line.69"></a>
-<span class="sourceLineNo">070</span> serializer.serialize(builder.build());<a name="line.70"></a>
-<span class="sourceLineNo">071</span> }<a name="line.71"></a>
-<span class="sourceLineNo">072</span><a name="line.72"></a>
-<span class="sourceLineNo">073</span> @Override<a name="line.73"></a>
-<span class="sourceLineNo">074</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.74"></a>
-<span class="sourceLineNo">075</span> super.deserializeStateData(serializer);<a name="line.75"></a>
-<span class="sourceLineNo">076</span> CloseRegionProcedureStateData data =<a name="line.76"></a>
-<span class="sourceLineNo">077</span> serializer.deserialize(CloseRegionProcedureStateData.class);<a name="line.77"></a>
-<span class="sourceLineNo">078</span> if (data.hasAssignCandidate()) {<a name="line.78"></a>
-<span class="sourceLineNo">079</span> assignCandidate = ProtobufUtil.toServerName(data.getAssignCandidate());<a name="line.79"></a>
-<span class="sourceLineNo">080</span> }<a name="line.80"></a>
-<span class="sourceLineNo">081</span> }<a name="line.81"></a>
-<span class="sourceLineNo">082</span>}<a name="line.82"></a>
+<span class="sourceLineNo">023</span>import org.apache.hadoop.hbase.master.RegionState;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.RegionCloseOperation;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.RemoteOperation;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.CloseRegionProcedureStateData;<a name="line.30"></a>
+<span class="sourceLineNo">031</span><a name="line.31"></a>
+<span class="sourceLineNo">032</span>/**<a name="line.32"></a>
+<span class="sourceLineNo">033</span> * The remote procedure used to close a region.<a name="line.33"></a>
+<span class="sourceLineNo">034</span> */<a name="line.34"></a>
+<span class="sourceLineNo">035</span>@InterfaceAudience.Private<a name="line.35"></a>
+<span class="sourceLineNo">036</span>public class CloseRegionProcedure extends RegionRemoteProcedureBase {<a name="line.36"></a>
+<span class="sourceLineNo">037</span><a name="line.37"></a>
+<span class="sourceLineNo">038</span> // For a region move operation, we will assign the region after we unassign it, this is the target<a name="line.38"></a>
+<span class="sourceLineNo">039</span> // server for the subsequent assign. We will send this value to RS, and RS will record the region<a name="line.39"></a>
+<span class="sourceLineNo">040</span> // in a Map to tell client that where the region has been moved to. Can be null. And also, can be<a name="line.40"></a>
+<span class="sourceLineNo">041</span> // wrong(but do not make it wrong intentionally). The client can handle this error.<a name="line.41"></a>
+<span class="sourceLineNo">042</span> private ServerName assignCandidate;<a name="line.42"></a>
+<span class="sourceLineNo">043</span><a name="line.43"></a>
+<span class="sourceLineNo">044</span> public CloseRegionProcedure() {<a name="line.44"></a>
+<span class="sourceLineNo">045</span> super();<a name="line.45"></a>
+<span class="sourceLineNo">046</span> }<a name="line.46"></a>
+<span class="sourceLineNo">047</span><a name="line.47"></a>
+<span class="sourceLineNo">048</span> public CloseRegionProcedure(RegionInfo region, ServerName targetServer,<a name="line.48"></a>
+<span class="sourceLineNo">049</span> ServerName assignCandidate) {<a name="line.49"></a>
+<span class="sourceLineNo">050</span> super(region, targetServer);<a name="line.50"></a>
+<span class="sourceLineNo">051</span> this.assignCandidate = assignCandidate;<a name="line.51"></a>
+<span class="sourceLineNo">052</span> }<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span> @Override<a name="line.54"></a>
+<span class="sourceLineNo">055</span> public TableOperationType getTableOperationType() {<a name="line.55"></a>
+<span class="sourceLineNo">056</span> return TableOperationType.REGION_UNASSIGN;<a name="line.56"></a>
+<span class="sourceLineNo">057</span> }<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span> @Override<a name="line.59"></a>
+<span class="sourceLineNo">060</span> public RemoteOperation remoteCallBuild(MasterProcedureEnv env, ServerName remote) {<a name="line.60"></a>
+<span class="sourceLineNo">061</span> return new RegionCloseOperation(this, region, assignCandidate);<a name="line.61"></a>
+<span class="sourceLineNo">062</span> }<a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span> @Override<a name="line.64"></a>
+<span class="sourceLineNo">065</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.65"></a>
+<span class="sourceLineNo">066</span> super.serializeStateData(serializer);<a name="line.66"></a>
+<span class="sourceLineNo">067</span> CloseRegionProcedureStateData.Builder builder = CloseRegionProcedureStateData.newBuilder();<a name="line.67"></a>
+<span class="sourceLineNo">068</span> if (assignCandidate != null) {<a name="line.68"></a>
+<span class="sourceLineNo">069</span> builder.setAssignCandidate(ProtobufUtil.toServerName(assignCandidate));<a name="line.69"></a>
+<span class="sourceLineNo">070</span> }<a name="line.70"></a>
+<span class="sourceLineNo">071</span> serializer.serialize(builder.build());<a name="line.71"></a>
+<span class="sourceLineNo">072</span> }<a name="line.72"></a>
+<span class="sourceLineNo">073</span><a name="line.73"></a>
+<span class="sourceLineNo">074</span> @Override<a name="line.74"></a>
+<span class="sourceLineNo">075</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.75"></a>
+<span class="sourceLineNo">076</span> super.deserializeStateData(serializer);<a name="line.76"></a>
+<span class="sourceLineNo">077</span> CloseRegionProcedureStateData data =<a name="line.77"></a>
+<span class="sourceLineNo">078</span> serializer.deserialize(CloseRegionProcedureStateData.class);<a name="line.78"></a>
+<span class="sourceLineNo">079</span> if (data.hasAssignCandidate()) {<a name="line.79"></a>
+<span class="sourceLineNo">080</span> assignCandidate = ProtobufUtil.toServerName(data.getAssignCandidate());<a name="line.80"></a>
+<span class="sourceLineNo">081</span> }<a name="line.81"></a>
+<span class="sourceLineNo">082</span> }<a name="line.82"></a>
+<span class="sourceLineNo">083</span><a name="line.83"></a>
+<span class="sourceLineNo">084</span> @Override<a name="line.84"></a>
+<span class="sourceLineNo">085</span> protected boolean shouldDispatch(RegionStateNode regionNode) {<a name="line.85"></a>
+<span class="sourceLineNo">086</span> return !regionNode.isInState(RegionState.State.CLOSED, RegionState.State.ABNORMALLY_CLOSED);<a name="line.86"></a>
+<span class="sourceLineNo">087</span> }<a name="line.87"></a>
+<span class="sourceLineNo">088</span>}<a name="line.88"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/424d7e41/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.html
index 276ffd0..6e27067 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.html
@@ -28,51 +28,57 @@
<span class="sourceLineNo">020</span>import java.io.IOException;<a name="line.20"></a>
<span class="sourceLineNo">021</span>import org.apache.hadoop.hbase.ServerName;<a name="line.21"></a>
<span class="sourceLineNo">022</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.22"></a>
-<span class="sourceLineNo">023</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.RegionOpenOperation;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.RemoteOperation;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.27"></a>
-<span class="sourceLineNo">028</span><a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.OpenRegionProcedureStateData;<a name="line.29"></a>
-<span class="sourceLineNo">030</span><a name="line.30"></a>
-<span class="sourceLineNo">031</span>/**<a name="line.31"></a>
-<span class="sourceLineNo">032</span> * The remote procedure used to open a region.<a name="line.32"></a>
-<span class="sourceLineNo">033</span> */<a name="line.33"></a>
-<span class="sourceLineNo">034</span>@InterfaceAudience.Private<a name="line.34"></a>
-<span class="sourceLineNo">035</span>public class OpenRegionProcedure extends RegionRemoteProcedureBase {<a name="line.35"></a>
-<span class="sourceLineNo">036</span><a name="line.36"></a>
-<span class="sourceLineNo">037</span> public OpenRegionProcedure() {<a name="line.37"></a>
-<span class="sourceLineNo">038</span> super();<a name="line.38"></a>
-<span class="sourceLineNo">039</span> }<a name="line.39"></a>
-<span class="sourceLineNo">040</span><a name="line.40"></a>
-<span class="sourceLineNo">041</span> public OpenRegionProcedure(RegionInfo region, ServerName targetServer) {<a name="line.41"></a>
-<span class="sourceLineNo">042</span> super(region, targetServer);<a name="line.42"></a>
-<span class="sourceLineNo">043</span> }<a name="line.43"></a>
-<span class="sourceLineNo">044</span><a name="line.44"></a>
-<span class="sourceLineNo">045</span> @Override<a name="line.45"></a>
-<span class="sourceLineNo">046</span> public TableOperationType getTableOperationType() {<a name="line.46"></a>
-<span class="sourceLineNo">047</span> return TableOperationType.REGION_ASSIGN;<a name="line.47"></a>
-<span class="sourceLineNo">048</span> }<a name="line.48"></a>
-<span class="sourceLineNo">049</span><a name="line.49"></a>
-<span class="sourceLineNo">050</span> @Override<a name="line.50"></a>
-<span class="sourceLineNo">051</span> public RemoteOperation remoteCallBuild(MasterProcedureEnv env, ServerName remote) {<a name="line.51"></a>
-<span class="sourceLineNo">052</span> return new RegionOpenOperation(this, region, env.getAssignmentManager().getFavoredNodes(region),<a name="line.52"></a>
-<span class="sourceLineNo">053</span> false);<a name="line.53"></a>
-<span class="sourceLineNo">054</span> }<a name="line.54"></a>
-<span class="sourceLineNo">055</span><a name="line.55"></a>
-<span class="sourceLineNo">056</span> @Override<a name="line.56"></a>
-<span class="sourceLineNo">057</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.57"></a>
-<span class="sourceLineNo">058</span> super.serializeStateData(serializer);<a name="line.58"></a>
-<span class="sourceLineNo">059</span> serializer.serialize(OpenRegionProcedureStateData.getDefaultInstance());<a name="line.59"></a>
-<span class="sourceLineNo">060</span> }<a name="line.60"></a>
-<span class="sourceLineNo">061</span><a name="line.61"></a>
-<span class="sourceLineNo">062</span> @Override<a name="line.62"></a>
-<span class="sourceLineNo">063</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.63"></a>
-<span class="sourceLineNo">064</span> super.deserializeStateData(serializer);<a name="line.64"></a>
-<span class="sourceLineNo">065</span> serializer.deserialize(OpenRegionProcedureStateData.class);<a name="line.65"></a>
-<span class="sourceLineNo">066</span> }<a name="line.66"></a>
-<span class="sourceLineNo">067</span>}<a name="line.67"></a>
+<span class="sourceLineNo">023</span>import org.apache.hadoop.hbase.master.RegionState;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.RegionOpenOperation;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.RemoteOperation;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.28"></a>
+<span class="sourceLineNo">029</span><a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.OpenRegionProcedureStateData;<a name="line.30"></a>
+<span class="sourceLineNo">031</span><a name="line.31"></a>
+<span class="sourceLineNo">032</span>/**<a name="line.32"></a>
+<span class="sourceLineNo">033</span> * The remote procedure used to open a region.<a name="line.33"></a>
+<span class="sourceLineNo">034</span> */<a name="line.34"></a>
+<span class="sourceLineNo">035</span>@InterfaceAudience.Private<a name="line.35"></a>
+<span class="sourceLineNo">036</span>public class OpenRegionProcedure extends RegionRemoteProcedureBase {<a name="line.36"></a>
+<span class="sourceLineNo">037</span><a name="line.37"></a>
+<span class="sourceLineNo">038</span> public OpenRegionProcedure() {<a name="line.38"></a>
+<span class="sourceLineNo">039</span> super();<a name="line.39"></a>
+<span class="sourceLineNo">040</span> }<a name="line.40"></a>
+<span class="sourceLineNo">041</span><a name="line.41"></a>
+<span class="sourceLineNo">042</span> public OpenRegionProcedure(RegionInfo region, ServerName targetServer) {<a name="line.42"></a>
+<span class="sourceLineNo">043</span> super(region, targetServer);<a name="line.43"></a>
+<span class="sourceLineNo">044</span> }<a name="line.44"></a>
+<span class="sourceLineNo">045</span><a name="line.45"></a>
+<span class="sourceLineNo">046</span> @Override<a name="line.46"></a>
+<span class="sourceLineNo">047</span> public TableOperationType getTableOperationType() {<a name="line.47"></a>
+<span class="sourceLineNo">048</span> return TableOperationType.REGION_ASSIGN;<a name="line.48"></a>
+<span class="sourceLineNo">049</span> }<a name="line.49"></a>
+<span class="sourceLineNo">050</span><a name="line.50"></a>
+<span class="sourceLineNo">051</span> @Override<a name="line.51"></a>
+<span class="sourceLineNo">052</span> public RemoteOperation remoteCallBuild(MasterProcedureEnv env, ServerName remote) {<a name="line.52"></a>
+<span class="sourceLineNo">053</span> return new RegionOpenOperation(this, region, env.getAssignmentManager().getFavoredNodes(region),<a name="line.53"></a>
+<span class="sourceLineNo">054</span> false);<a name="line.54"></a>
+<span class="sourceLineNo">055</span> }<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span> @Override<a name="line.57"></a>
+<span class="sourceLineNo">058</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.58"></a>
+<span class="sourceLineNo">059</span> super.serializeStateData(serializer);<a name="line.59"></a>
+<span class="sourceLineNo">060</span> serializer.serialize(OpenRegionProcedureStateData.getDefaultInstance());<a name="line.60"></a>
+<span class="sourceLineNo">061</span> }<a name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span> @Override<a name="line.63"></a>
+<span class="sourceLineNo">064</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.64"></a>
+<span class="sourceLineNo">065</span> super.deserializeStateData(serializer);<a name="line.65"></a>
+<span class="sourceLineNo">066</span> serializer.deserialize(OpenRegionProcedureStateData.class);<a name="line.66"></a>
+<span class="sourceLineNo">067</span> }<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span> @Override<a name="line.69"></a>
+<span class="sourceLineNo">070</span> protected boolean shouldDispatch(RegionStateNode regionNode) {<a name="line.70"></a>
+<span class="sourceLineNo">071</span> return !regionNode.isInState(RegionState.State.OPEN);<a name="line.71"></a>
+<span class="sourceLineNo">072</span> }<a name="line.72"></a>
+<span class="sourceLineNo">073</span>}<a name="line.73"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/424d7e41/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/RegionRemoteProcedureBase.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/RegionRemoteProcedureBase.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/RegionRemoteProcedureBase.html
index 511d3f2..daf2583 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/RegionRemoteProcedureBase.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/RegionRemoteProcedureBase.html
@@ -85,16 +85,16 @@
<span class="sourceLineNo">077</span> throw new UnsupportedOperationException();<a name="line.77"></a>
<span class="sourceLineNo">078</span> }<a name="line.78"></a>
<span class="sourceLineNo">079</span><a name="line.79"></a>
-<span class="sourceLineNo">080</span> private ProcedureEvent<?> getRegionEvent(MasterProcedureEnv env) {<a name="line.80"></a>
-<span class="sourceLineNo">081</span> return env.getAssignmentManager().getRegionStates().getOrCreateRegionStateNode(region)<a name="line.81"></a>
-<span class="sourceLineNo">082</span> .getProcedureEvent();<a name="line.82"></a>
-<span class="sourceLineNo">083</span> }<a name="line.83"></a>
-<span class="sourceLineNo">084</span><a name="line.84"></a>
-<span class="sourceLineNo">085</span> @Override<a name="line.85"></a>
-<span class="sourceLineNo">086</span> public void remoteCallFailed(MasterProcedureEnv env, ServerName remote,<a name="line.86"></a>
-<span class="sourceLineNo">087</span> IOException exception) {<a name="line.87"></a>
-<span class="sourceLineNo">088</span> ProcedureEvent<?> event = getRegionEvent(env);<a name="line.88"></a>
-<span class="sourceLineNo">089</span> synchronized (event) {<a name="line.89"></a>
+<span class="sourceLineNo">080</span> private RegionStateNode getRegionNode(MasterProcedureEnv env) {<a name="line.80"></a>
+<span class="sourceLineNo">081</span> return env.getAssignmentManager().getRegionStates().getRegionStateNode(region);<a name="line.81"></a>
+<span class="sourceLineNo">082</span> }<a name="line.82"></a>
+<span class="sourceLineNo">083</span><a name="line.83"></a>
+<span class="sourceLineNo">084</span> @Override<a name="line.84"></a>
+<span class="sourceLineNo">085</span> public void remoteCallFailed(MasterProcedureEnv env, ServerName remote, IOException exception) {<a name="line.85"></a>
+<span class="sourceLineNo">086</span> RegionStateNode regionNode = getRegionNode(env);<a name="line.86"></a>
+<span class="sourceLineNo">087</span> regionNode.lock();<a name="line.87"></a>
+<span class="sourceLineNo">088</span> try {<a name="line.88"></a>
+<span class="sourceLineNo">089</span> ProcedureEvent<?> event = regionNode.getProcedureEvent();<a name="line.89"></a>
<span class="sourceLineNo">090</span> if (event.isReady()) {<a name="line.90"></a>
<span class="sourceLineNo">091</span> LOG.warn(<a name="line.91"></a>
<span class="sourceLineNo">092</span> "The procedure event of procedure {} for region {} to server {} is not suspended, " +<a name="line.92"></a>
@@ -105,64 +105,86 @@
<span class="sourceLineNo">097</span> LOG.warn("The remote operation {} for region {} to server {} failed", this, region,<a name="line.97"></a>
<span class="sourceLineNo">098</span> targetServer, exception);<a name="line.98"></a>
<span class="sourceLineNo">099</span> event.wake(env.getProcedureScheduler());<a name="line.99"></a>
-<span class="sourceLineNo">100</span> }<a name="line.100"></a>
-<span class="sourceLineNo">101</span> }<a name="line.101"></a>
-<span class="sourceLineNo">102</span><a name="line.102"></a>
-<span class="sourceLineNo">103</span> @Override<a name="line.103"></a>
-<span class="sourceLineNo">104</span> public TableName getTableName() {<a name="line.104"></a>
-<span class="sourceLineNo">105</span> return region.getTable();<a name="line.105"></a>
-<span class="sourceLineNo">106</span> }<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span> @Override<a name="line.108"></a>
-<span class="sourceLineNo">109</span> protected void rollback(MasterProcedureEnv env) throws IOException, InterruptedException {<a name="line.109"></a>
-<span class="sourceLineNo">110</span> throw new UnsupportedOperationException();<a name="line.110"></a>
-<span class="sourceLineNo">111</span> }<a name="line.111"></a>
-<span class="sourceLineNo">112</span><a name="line.112"></a>
-<span class="sourceLineNo">113</span> @Override<a name="line.113"></a>
-<span class="sourceLineNo">114</span> protected boolean abort(MasterProcedureEnv env) {<a name="line.114"></a>
-<span class="sourceLineNo">115</span> return false;<a name="line.115"></a>
-<span class="sourceLineNo">116</span> }<a name="line.116"></a>
-<span class="sourceLineNo">117</span><a name="line.117"></a>
-<span class="sourceLineNo">118</span> @Override<a name="line.118"></a>
-<span class="sourceLineNo">119</span> protected Procedure<MasterProcedureEnv>[] execute(MasterProcedureEnv env)<a name="line.119"></a>
-<span class="sourceLineNo">120</span> throws ProcedureYieldException, ProcedureSuspendedException, InterruptedException {<a name="line.120"></a>
-<span class="sourceLineNo">121</span> if (dispatched) {<a name="line.121"></a>
-<span class="sourceLineNo">122</span> // we are done, the parent procedure will check whether we are succeeded.<a name="line.122"></a>
-<span class="sourceLineNo">123</span> return null;<a name="line.123"></a>
-<span class="sourceLineNo">124</span> }<a name="line.124"></a>
-<span class="sourceLineNo">125</span> ProcedureEvent<?> event = getRegionEvent(env);<a name="line.125"></a>
-<span class="sourceLineNo">126</span> synchronized (event) {<a name="line.126"></a>
-<span class="sourceLineNo">127</span> try {<a name="line.127"></a>
-<span class="sourceLineNo">128</span> env.getRemoteDispatcher().addOperationToNode(targetServer, this);<a name="line.128"></a>
-<span class="sourceLineNo">129</span> } catch (FailedRemoteDispatchException e) {<a name="line.129"></a>
-<span class="sourceLineNo">130</span> LOG.warn("Can not add remote operation {} for region {} to server {}, this usually " +<a name="line.130"></a>
-<span class="sourceLineNo">131</span> "because the server is alread dead, give up and mark the procedure as complete, " +<a name="line.131"></a>
-<span class="sourceLineNo">132</span> "the parent procedure will take care of this.", this, region, targetServer, e);<a name="line.132"></a>
-<span class="sourceLineNo">133</span> return null;<a name="line.133"></a>
-<span class="sourceLineNo">134</span> }<a name="line.134"></a>
-<span class="sourceLineNo">135</span> dispatched = true;<a name="line.135"></a>
-<span class="sourceLineNo">136</span> event.suspend();<a name="line.136"></a>
-<span class="sourceLineNo">137</span> event.suspendIfNotReady(this);<a name="line.137"></a>
-<span class="sourceLineNo">138</span> throw new ProcedureSuspendedException();<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span> }<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span> @Override<a name="line.142"></a>
-<span class="sourceLineNo">143</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.143"></a>
-<span class="sourceLineNo">144</span> serializer.serialize(RegionRemoteProcedureBaseStateData.newBuilder()<a name="line.144"></a>
-<span class="sourceLineNo">145</span> .setRegion(ProtobufUtil.toRegionInfo(region))<a name="line.145"></a>
-<span class="sourceLineNo">146</span> .setTargetServer(ProtobufUtil.toServerName(targetServer)).setDispatched(dispatched).build());<a name="line.146"></a>
-<span class="sourceLineNo">147</span> }<a name="line.147"></a>
-<span class="sourceLineNo">148</span><a name="line.148"></a>
-<span class="sourceLineNo">149</span> @Override<a name="line.149"></a>
-<span class="sourceLineNo">150</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.150"></a>
-<span class="sourceLineNo">151</span> RegionRemoteProcedureBaseStateData data =<a name="line.151"></a>
-<span class="sourceLineNo">152</span> serializer.deserialize(RegionRemoteProcedureBaseStateData.class);<a name="line.152"></a>
-<span class="sourceLineNo">153</span> region = ProtobufUtil.toRegionInfo(data.getRegion());<a name="line.153"></a>
-<span class="sourceLineNo">154</span> targetServer = ProtobufUtil.toServerName(data.getTargetServer());<a name="line.154"></a>
-<span class="sourceLineNo">155</span> dispatched = data.getDispatched();<a name="line.155"></a>
-<span class="sourceLineNo">156</span> }<a name="line.156"></a>
-<span class="sourceLineNo">157</span>}<a name="line.157"></a>
+<span class="sourceLineNo">100</span> } finally {<a name="line.100"></a>
+<span class="sourceLineNo">101</span> regionNode.unlock();<a name="line.101"></a>
+<span class="sourceLineNo">102</span> }<a name="line.102"></a>
+<span class="sourceLineNo">103</span> }<a name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span> @Override<a name="line.105"></a>
+<span class="sourceLineNo">106</span> public TableName getTableName() {<a name="line.106"></a>
+<span class="sourceLineNo">107</span> return region.getTable();<a name="line.107"></a>
+<span class="sourceLineNo">108</span> }<a name="line.108"></a>
+<span class="sourceLineNo">109</span><a name="line.109"></a>
+<span class="sourceLineNo">110</span> @Override<a name="line.110"></a>
+<span class="sourceLineNo">111</span> protected void rollback(MasterProcedureEnv env) throws IOException, InterruptedException {<a name="line.111"></a>
+<span class="sourceLineNo">112</span> throw new UnsupportedOperationException();<a name="line.112"></a>
+<span class="sourceLineNo">113</span> }<a name="line.113"></a>
+<span class="sourceLineNo">114</span><a name="line.114"></a>
+<span class="sourceLineNo">115</span> @Override<a name="line.115"></a>
+<span class="sourceLineNo">116</span> protected boolean abort(MasterProcedureEnv env) {<a name="line.116"></a>
+<span class="sourceLineNo">117</span> return false;<a name="line.117"></a>
+<span class="sourceLineNo">118</span> }<a name="line.118"></a>
+<span class="sourceLineNo">119</span><a name="line.119"></a>
+<span class="sourceLineNo">120</span> /**<a name="line.120"></a>
+<span class="sourceLineNo">121</span> * Check whether we still need to make the call to RS.<a name="line.121"></a>
+<span class="sourceLineNo">122</span> * <p/><a name="line.122"></a>
+<span class="sourceLineNo">123</span> * Usually this will not happen if we do not allow assigning a already onlined region. But if we<a name="line.123"></a>
+<span class="sourceLineNo">124</span> * have something wrong in the RSProcedureDispatcher, where we have already sent the request to<a name="line.124"></a>
+<span class="sourceLineNo">125</span> * RS, but then we tell the upper layer the remote call is failed due to rpc timeout or connection<a name="line.125"></a>
+<span class="sourceLineNo">126</span> * closed or anything else, then this issue can still happen. So here we add a check to make it<a name="line.126"></a>
+<span class="sourceLineNo">127</span> * more robust.<a name="line.127"></a>
+<span class="sourceLineNo">128</span> */<a name="line.128"></a>
+<span class="sourceLineNo">129</span> protected abstract boolean shouldDispatch(RegionStateNode regionNode);<a name="line.129"></a>
+<span class="sourceLineNo">130</span><a name="line.130"></a>
+<span class="sourceLineNo">131</span> @Override<a name="line.131"></a>
+<span class="sourceLineNo">132</span> protected Procedure<MasterProcedureEnv>[] execute(MasterProcedureEnv env)<a name="line.132"></a>
+<span class="sourceLineNo">133</span> throws ProcedureYieldException, ProcedureSuspendedException, InterruptedException {<a name="line.133"></a>
+<span class="sourceLineNo">134</span> if (dispatched) {<a name="line.134"></a>
+<span class="sourceLineNo">135</span> // we are done, the parent procedure will check whether we are succeeded.<a name="line.135"></a>
+<span class="sourceLineNo">136</span> return null;<a name="line.136"></a>
+<span class="sourceLineNo">137</span> }<a name="line.137"></a>
+<span class="sourceLineNo">138</span> RegionStateNode regionNode = getRegionNode(env);<a name="line.138"></a>
+<span class="sourceLineNo">139</span> regionNode.lock();<a name="line.139"></a>
+<span class="sourceLineNo">140</span> try {<a name="line.140"></a>
+<span class="sourceLineNo">141</span> if (!shouldDispatch(regionNode)) {<a name="line.141"></a>
+<span class="sourceLineNo">142</span> return null;<a name="line.142"></a>
+<span class="sourceLineNo">143</span> }<a name="line.143"></a>
+<span class="sourceLineNo">144</span> // The code which wakes us up also needs to lock the RSN so here we do not need to synchronize<a name="line.144"></a>
+<span class="sourceLineNo">145</span> // on the event.<a name="line.145"></a>
+<span class="sourceLineNo">146</span> ProcedureEvent<?> event = regionNode.getProcedureEvent();<a name="line.146"></a>
+<span class="sourceLineNo">147</span> try {<a name="line.147"></a>
+<span class="sourceLineNo">148</span> env.getRemoteDispatcher().addOperationToNode(targetServer, this);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> } catch (FailedRemoteDispatchException e) {<a name="line.149"></a>
+<span class="sourceLineNo">150</span> LOG.warn("Can not add remote operation {} for region {} to server {}, this usually " +<a name="line.150"></a>
+<span class="sourceLineNo">151</span> "because the server is alread dead, give up and mark the procedure as complete, " +<a name="line.151"></a>
+<span class="sourceLineNo">152</span> "the parent procedure will take care of this.", this, region, targetServer, e);<a name="line.152"></a>
+<span class="sourceLineNo">153</span> return null;<a name="line.153"></a>
+<span class="sourceLineNo">154</span> }<a name="line.154"></a>
+<span class="sourceLineNo">155</span> dispatched = true;<a name="line.155"></a>
+<span class="sourceLineNo">156</span> event.suspend();<a name="line.156"></a>
+<span class="sourceLineNo">157</span> event.suspendIfNotReady(this);<a name="line.157"></a>
+<span class="sourceLineNo">158</span> throw new ProcedureSuspendedException();<a name="line.158"></a>
+<span class="sourceLineNo">159</span> } finally {<a name="line.159"></a>
+<span class="sourceLineNo">160</span> regionNode.unlock();<a name="line.160"></a>
+<span class="sourceLineNo">161</span> }<a name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> @Override<a name="line.164"></a>
+<span class="sourceLineNo">165</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.165"></a>
+<span class="sourceLineNo">166</span> serializer.serialize(RegionRemoteProcedureBaseStateData.newBuilder()<a name="line.166"></a>
+<span class="sourceLineNo">167</span> .setRegion(ProtobufUtil.toRegionInfo(region))<a name="line.167"></a>
+<span class="sourceLineNo">168</span> .setTargetServer(ProtobufUtil.toServerName(targetServer)).setDispatched(dispatched).build());<a name="line.168"></a>
+<span class="sourceLineNo">169</span> }<a name="line.169"></a>
+<span class="sourceLineNo">170</span><a name="line.170"></a>
+<span class="sourceLineNo">171</span> @Override<a name="line.171"></a>
+<span class="sourceLineNo">172</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.172"></a>
+<span class="sourceLineNo">173</span> RegionRemoteProcedureBaseStateData data =<a name="line.173"></a>
+<span class="sourceLineNo">174</span> serializer.deserialize(RegionRemoteProcedureBaseStateData.class);<a name="line.174"></a>
+<span class="sourceLineNo">175</span> region = ProtobufUtil.toRegionInfo(data.getRegion());<a name="line.175"></a>
+<span class="sourceLineNo">176</span> targetServer = ProtobufUtil.toServerName(data.getTargetServer());<a name="line.176"></a>
+<span class="sourceLineNo">177</span> dispatched = data.getDispatched();<a name="line.177"></a>
+<span class="sourceLineNo">178</span> }<a name="line.178"></a>
+<span class="sourceLineNo">179</span>}<a name="line.179"></a>