You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/04 19:12:29 UTC
[GitHub] [arrow] diegodfrf opened a new pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
diegodfrf opened a new pull request #10878:
URL: https://github.com/apache/arrow/pull/10878
Update shared_ptr<Scalar> and shared_ptr<Arrow> to Datum in CheckScalar* functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#issuecomment-893066977
R failure is unrelated, merging. Thanks @diegodfrf!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #10878:
URL: https://github.com/apache/arrow/pull/10878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#issuecomment-892905554
https://issues.apache.org/jira/browse/ARROW-12953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #10878:
URL: https://github.com/apache/arrow/pull/10878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] edponce commented on pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
edponce commented on pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#issuecomment-892934792
LGTM. Thanks for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#issuecomment-892905554
https://issues.apache.org/jira/browse/ARROW-12953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] diegodfrf commented on a change in pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
diegodfrf commented on a change in pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#discussion_r682899048
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1186,9 +1186,9 @@ TYPED_TEST(TestStringKernels, BinaryJoin) {
auto expected =
ArrayFromJSON(this->type(), R"(["a--bb--ccc", "", null, "dd", null, "ff--"])");
CheckScalarBinary("binary_join", ArrayFromJSON(list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
CheckScalarBinary("binary_join", ArrayFromJSON(large_list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] edponce commented on pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
edponce commented on pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#issuecomment-892934792
LGTM. Thanks for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#discussion_r682895881
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1186,9 +1186,9 @@ TYPED_TEST(TestStringKernels, BinaryJoin) {
auto expected =
ArrayFromJSON(this->type(), R"(["a--bb--ccc", "", null, "dd", null, "ff--"])");
CheckScalarBinary("binary_join", ArrayFromJSON(list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
CheckScalarBinary("binary_join", ArrayFromJSON(large_list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
Review comment:
Ah, this isn't a cast, but is instead invoking the implicit conversion ([case (1) here](https://en.cppreference.com/w/cpp/language/static_cast)). Can we write it as just `Datum(separator)` to make that clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] diegodfrf commented on a change in pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
diegodfrf commented on a change in pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#discussion_r682899048
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1186,9 +1186,9 @@ TYPED_TEST(TestStringKernels, BinaryJoin) {
auto expected =
ArrayFromJSON(this->type(), R"(["a--bb--ccc", "", null, "dd", null, "ff--"])");
CheckScalarBinary("binary_join", ArrayFromJSON(list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
CheckScalarBinary("binary_join", ArrayFromJSON(large_list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#issuecomment-893066977
R failure is unrelated, merging. Thanks @diegodfrf!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10878: ARROW-12953: [C++][Compute] Refactor CheckScalar* to take Datum arguments
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#discussion_r682895881
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1186,9 +1186,9 @@ TYPED_TEST(TestStringKernels, BinaryJoin) {
auto expected =
ArrayFromJSON(this->type(), R"(["a--bb--ccc", "", null, "dd", null, "ff--"])");
CheckScalarBinary("binary_join", ArrayFromJSON(list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
CheckScalarBinary("binary_join", ArrayFromJSON(large_list(this->type()), list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
Review comment:
Ah, this isn't a cast, but is instead invoking the implicit conversion ([case (1) here](https://en.cppreference.com/w/cpp/language/static_cast)). Can we write it as just `Datum(separator)` to make that clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org