You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Noah Slater <ns...@tumbolia.org> on 2012/10/04 12:08:53 UTC

Re: Review Request: apache 4.0 docs

Just following up on this. What is a "private" branch?

On Tue, Sep 25, 2012 at 9:26 AM, Noah Slater <ns...@tumbolia.org> wrote:

> Can you clarify what you mean as "a private" branch?
>
>
> On Tue, Sep 11, 2012 at 10:28 AM, Radhika Puthiyetath <
> radhika.puthiyetath@citrix.com> wrote:
>
>> Hello Community,
>>
>> Here is one question: AutoScale code is committed to a private branch.
>> Where the autoscale documentation should go ?
>>
>> Documentation does not have a private branch yet. Therefore, I have
>> pushed the AutoScale documentation to the master  branch as of now. Do I
>> need to revert it ?
>>
>> Looking forward to the right direction in this matter.
>>
>> Thanks
>> -Radhika
>>
>>
>>
>> From: Jessica Tomechak [mailto:noreply@reviews.apache.org] On Behalf Of
>> Jessica Tomechak
>> Sent: Tuesday, September 11, 2012 1:23 PM
>> To: cloudstack; Radhika Puthiyetath; Jessica Tomechak
>> Subject: Re: Review Request: apache 4.0 docs
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/6978/
>>
>>
>>
>> Ship it!
>>
>> Spot checked. These are the same files Radhika and I have been using to
>> generate docs for a commercial version of CloudStack and they have passed
>> review and built properly in that context.
>>
>>
>> - Jessica
>>
>>
>> On September 10th, 2012, 10:21 a.m., Radhika PC wrote:
>> Review request for cloudstack.
>> By Radhika PC.
>>
>> Updated Sept. 10, 2012, 10:21 a.m.
>>
>> Description
>>
>> This patch includes defect fixes and the new feature documentation:
>> site-to-site vpn, inter-vlan routing, and autoscale. The issues pointed out
>> for the Review Request #6328 has also been fixed. Updated the ASF license
>> header for other files.
>>
>>
>> Testing
>>
>> reviewed for the commercial release
>>
>>
>> Diffs
>>
>>  *   docs/en-US/Book_Info_Admin.xml (PRE-CREATION)
>>  *   docs/en-US/LDAPserver-for-user-authentication.xml (5fcb300)
>>  *   docs/en-US/about-clusters.xml (e328cba)
>>  *   docs/en-US/about-hosts.xml (956c695)
>>  *   docs/en-US/about-physical-networks.xml (8edb9e0)
>>  *   docs/en-US/about-pods.xml (ed3520c)
>>  *   docs/en-US/about-primary-storage.xml (68d7a25)
>>  *   docs/en-US/about-secondary-storage.xml (c4df0b8)
>>  *   docs/en-US/about-security-groups.xml (PRE-CREATION)
>>  *   docs/en-US/about-virtual-networks.xml (2fc6ba9)
>>  *   docs/en-US/about-working-with-vms.xml (47153e2)
>>  *   docs/en-US/about-zones.xml (a05a9a6)
>>  *   docs/en-US/accessing-vms.xml (d69d021)
>>  *   docs/en-US/accounts-users-domains.xml (8549129)
>>  *   docs/en-US/accounts.xml (5292a9c)
>>  *   docs/en-US/acquire-new-ip-for-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/add-additional-guest-network.xml (57e7ffd)
>>  *   docs/en-US/add-clusters-kvm-xenserver.xml (PRE-CREATION)
>>  *   docs/en-US/add-clusters-ovm.xml (PRE-CREATION)
>>  *   docs/en-US/add-clusters-vsphere.xml (PRE-CREATION)
>>  *   docs/en-US/add-gateway-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/add-ingress-egress-rules.xml (964045f)
>>  *   docs/en-US/add-iso.xml (f56d10c)
>>  *   docs/en-US/add-load-balancer-rule.xml (ddbce95)
>>  *   docs/en-US/add-loadbalancer-rule-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/add-more-clusters.xml (PRE-CREATION)
>>  *   docs/en-US/add-portforward-rule-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/add-primary-storage.xml (PRE-CREATION)
>>  *   docs/en-US/add-secondary-storage.xml (PRE-CREATION)
>>  *   docs/en-US/add-security-group.xml (e4c8b3c)
>>  *   docs/en-US/add-tier.xml (PRE-CREATION)
>>  *   docs/en-US/add-vm-to-tier.xml (PRE-CREATION)
>>  *   docs/en-US/add-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/advanced-zone-configuration.xml (85909e3)
>>  *   docs/en-US/advanced-zone-guest-ip-addresses.xml (b5d10a0)
>>  *   docs/en-US/advanced-zone-network-traffic-types.xml (9f475cf)
>>  *   docs/en-US/advanced-zone-physical-network-configuration.xml (4c44c7d)
>>  *   docs/en-US/advanced-zone-public-ip-addresses.xml (eeb9404)
>>  *   docs/en-US/alerts.xml (f903023)
>>  *   docs/en-US/api-overview.xml (PRE-CREATION)
>>  *   docs/en-US/attach-iso-to-vm.xml (30e5d51)
>>  *   docs/en-US/automatic-snapshot-creation-retention.xml (ee4cf73)
>>  *   docs/en-US/autoscale.xml (PRE-CREATION)
>>  *   docs/en-US/basic-zone-configuration.xml (18afa84)
>>  *   docs/en-US/basic-zone-guest-ip-addresses.xml (d1d9135)
>>  *   docs/en-US/basic-zone-network-traffic-types.xml (fa3be0f)
>>  *   docs/en-US/basic-zone-physical-network-configuration.xml (83833a7)
>>  *   docs/en-US/best-practices-for-vms.xml (a67add4)
>>  *   docs/en-US/change-database-config.xml (PRE-CREATION)
>>  *   docs/en-US/change-network-offering-on-guest-network.xml (98f1b63)
>>  *   docs/en-US/change-ssvm-service-offering.xml (PRE-CREATION)
>>  *   docs/en-US/changing-root-password.xml (0d2333a)
>>  *   docs/en-US/changing-secondary-storage-ip.xml (7e146de)
>>  *   docs/en-US/changing-service-offering-for-vm.xml (5a42912)
>>  *   docs/en-US/changing-vm-name-os-group.xml (f16ffda)
>>  *   docs/en-US/cloud-infrastructure-concepts.xml (58f8844)
>>  *   docs/en-US/cloud-infrastructure-overview.xml (5b467a3)
>>  *   docs/en-US/cloudstack_admin.xml (c80c94f)
>>  *   docs/en-US/cluster-add-xenserver-kvm.xml (PRE-CREATION)
>>  *   docs/en-US/cluster-add.xml (5210bd8)
>>  *   docs/en-US/compute-disk-service-offerings.xml (2469dfe)
>>  *   docs/en-US/concepts.xml (1912c23)
>>  *   docs/en-US/configure-acl.xml (PRE-CREATION)
>>  *   docs/en-US/configure-guest-traffic-in-advanced-zone.xml (95df473)
>>  *   docs/en-US/configure-snmp-rhel.xml (PRE-CREATION)
>>  *   docs/en-US/configure-usage-server.xml (d167a49)
>>  *   docs/en-US/configure-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/configure-vpn.xml (9e059f7)
>>  *   docs/en-US/console-proxy.xml (df29c42)
>>  *   docs/en-US/convert-hyperv-vm-to-template.xml (c6294d4)
>>  *   docs/en-US/create-template-from-existing-vm.xml (c22b7ec)
>>  *   docs/en-US/create-template-from-snapshot.xml (3075032)
>>  *   docs/en-US/create-templates-overview.xml (818b42d)
>>  *   docs/en-US/create-vpn-connection-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/create-vpn-customer-gateway.xml (PRE-CREATION)
>>  *   docs/en-US/create-vpn-gateway-for-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/create-vr-network-offering.xml (PRE-CREATION)
>>  *   docs/en-US/create-windows-template.xml (f8dbc79)
>>  *   docs/en-US/creating-compute-offerings.xml (56679a4)
>>  *   docs/en-US/creating-network-offerings.xml (ab56920)
>>  *   docs/en-US/creating-new-volumes.xml (62181b9)
>>  *   docs/en-US/creating-vms.xml (dc37dbb)
>>  *   docs/en-US/default-account-resource-limit.xml (abc313f)
>>  *   docs/en-US/delete-reset-vpn.xml (PRE-CREATION)
>>  *   docs/en-US/deleting-vms.xml (1f1ee95)
>>  *   docs/en-US/deployment-architecture-overview.xml (6a67a2c)
>>  *   docs/en-US/detach-move-volumes.xml (a00e15f)
>>  *   docs/en-US/developer-guide.xml (c4bdf39)
>>  *   docs/en-US/enable-disable-static-nat-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/enable-disable-static-nat.xml (f25327a)
>>  *   docs/en-US/enable-security-groups.xml (27f69d2)
>>  *   docs/en-US/end-user-ui-overview.xml (dc95ce0)
>>  *   docs/en-US/event-log-queries.xml (32a1612)
>>  *   docs/en-US/event-types.xml (9a71055)
>>  *   docs/en-US/events-log.xml (9de679e)
>>  *   docs/en-US/events.xml (cbefc54)
>>  *   docs/en-US/external-firewalls-and-load-balancers.xml (1452804)
>>  *   docs/en-US/feature-overview.xml (236d78b)
>>  *   docs/en-US/firewall-rules.xml (388bf7e)
>>  *   docs/en-US/global-config.xml (PRE-CREATION)
>>  *   docs/en-US/globally-configured-limits.xml (ac71112)
>>  *   docs/en-US/guest-traffic.xml (96f9c06)
>>  *   docs/en-US/ha-for-hosts.xml (e395d22)
>>  *   docs/en-US/host-add-xenserver-kvm-ovm.xml (PRE-CREATION)
>>  *   docs/en-US/host-add.xml (2a984fd)
>>  *   docs/en-US/host-allocation.xml (8a362e6)
>>  *   docs/en-US/hypervisor-support-for-primarystorage.xml (ca266a4)
>>  *   docs/en-US/images/add-cluster.png (PRE-CREATION)
>>  *   docs/en-US/images/add-guest-network.png (PRE-CREATION)
>>  *   docs/en-US/images/add-new-gateway-vpc.png (PRE-CREATION)
>>  *   docs/en-US/images/add-tier.png (PRE-CREATION)
>>  *   docs/en-US/images/add-vpc.png (PRE-CREATION)
>>  *   docs/en-US/images/add-vpn-customer-gateway.png (PRE-CREATION)
>>  *   docs/en-US/images/autoscale-config.png (PRE-CREATION)
>>  *   docs/en-US/images/cluster-overview.png
>> (33f1a0477ef48b7af9475da0d148085f36d480c7)
>>  *   docs/en-US/images/create-vpn-connection.png (PRE-CREATION)
>>  *   docs/en-US/images/enable-disable-autoscale.png (PRE-CREATION)
>>  *   docs/en-US/images/guest-traffic-setup.png (PRE-CREATION)
>>  *   docs/en-US/images/icon.svg (PRE-CREATION)
>>  *   docs/en-US/images/multi-tier-app.png (PRE-CREATION)
>>  *   docs/en-US/images/network-acl.png (PRE-CREATION)
>>  *   docs/en-US/images/network-setup-zone.png (PRE-CREATION)
>>  *   docs/en-US/images/network-singlepod.png (PRE-CREATION)
>>  *   docs/en-US/images/remove-tier.png (PRE-CREATION)
>>  *   docs/en-US/images/restart-vpc.png (PRE-CREATION)
>>  *   docs/en-US/images/select-vm-staticnat-vpc.png (PRE-CREATION)
>>  *   docs/en-US/images/vm-lifecycle.png (PRE-CREATION)
>>  *   docs/en-US/images/vsphere-client.png (PRE-CREATION)
>>  *   docs/en-US/import-ami.xml (2f093b1)
>>  *   docs/en-US/initialize-and-test.xml (cf0c04e)
>>  *   docs/en-US/installation-complete.xml (PRE-CREATION)
>>  *   docs/en-US/inter-vlan-routing.xml (PRE-CREATION)
>>  *   docs/en-US/ip-forwarding-firewalling.xml (61aa6ad)
>>  *   docs/en-US/isolated-networks.xml (13f8aa1)
>>  *   docs/en-US/kvm-install.xml (PRE-CREATION)
>>  *   docs/en-US/linux-installation.xml (60d389c)
>>  *   docs/en-US/load-balancer-rules.xml (8dd7d3b)
>>  *   docs/en-US/log-in-root-admin.xml (c0a340a)
>>  *   docs/en-US/log-in.xml (e72d27b)
>>  *   docs/en-US/maintain-hypervisors-on-hosts.xml (213f078)
>>  *   docs/en-US/manage-cloud.xml (c4c4d6b)
>>  *   docs/en-US/manage-network-traffic.xml (PRE-CREATION)
>>  *   docs/en-US/manual-live-migration.xml (390b417)
>>  *   docs/en-US/migrate-vm-rootvolume-volume-new-storage-pool.xml
>> (67fe2f5)
>>  *   docs/en-US/minimum-system-requirements.xml (0043a26)
>>  *   docs/en-US/network-offerings.xml (ccfb93c)
>>  *   docs/en-US/network-service-providers.xml (af57097)
>>  *   docs/en-US/networking-in-a-pod.xml (81f0827)
>>  *   docs/en-US/networking-in-a-zone.xml (c380c33)
>>  *   docs/en-US/networking-overview.xml (798fd7a)
>>  *   docs/en-US/networks-for-users-overview.xml (PRE-CREATION)
>>  *   docs/en-US/networks.xml (PRE-CREATION)
>>  *   docs/en-US/offerings.xml (PRE-CREATION)
>>  *   docs/en-US/pod-add.xml (419e333)
>>  *   docs/en-US/port-forwarding.xml (b778693)
>>  *   docs/en-US/prepare-system-vm-template.xml (PRE-CREATION)
>>  *   docs/en-US/primary-storage-add.xml (588d491)
>>  *   docs/en-US/primary-storage.xml (4860488)
>>  *   docs/en-US/projects-overview.xml (PRE-CREATION)
>>  *   docs/en-US/projects.xml (0390f52)
>>  *   docs/en-US/provisioning-steps-overview.xml (1da4485)
>>  *   docs/en-US/provisioning-steps.xml (fda3e17)
>>  *   docs/en-US/re-install-hosts.xml (PRE-CREATION)
>>  *   docs/en-US/release-ip-address.xml (87b5300)
>>  *   docs/en-US/release-ip-for-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/remove-tier.xml (PRE-CREATION)
>>  *   docs/en-US/remove-vpc.xml (PRE-CREATION)
>>  *   docs/en-US/removing-hosts.xml (PRE-CREATION)
>>  *   docs/en-US/removing-vsphere-hosts.xml (16830b7)
>>  *   docs/en-US/runtime-allocation-virtual-network-resources.xml (696ea9b)
>>  *   docs/en-US/scheduled-maintenance-maintenance-mode-hosts.xml (6364e8b)
>>  *   docs/en-US/secondary-storage-add.xml (15e8c74)
>>  *   docs/en-US/secondary-storage-vm.xml (7926444)
>>  *   docs/en-US/secondary-storage.xml (e755b56)
>>  *   docs/en-US/security-groups.xml (fdb4ee9)
>>  *   docs/en-US/set-up-invitations.xml (e6a22db)
>>  *   docs/en-US/set-up-network-for-users.xml (4e2be48)
>>  *   docs/en-US/set-usage-limit.xml (3ef528a)
>>  *   docs/en-US/shared-networks.xml (d505fed)
>>  *   docs/en-US/site-to-site-vpn.xml (034fb42)
>>  *   docs/en-US/standard-events.xml (b4a4c68)
>>  *   docs/en-US/static-nat.xml (ef9e2fc)
>>  *   docs/en-US/stop-restart-management-server.xml (2edc233)
>>  *   docs/en-US/stopping-and-starting-vms.xml (8b294af)
>>  *   docs/en-US/storage-overview.xml (PRE-CREATION)
>>  *   docs/en-US/storage.xml (c4df50f)
>>  *   docs/en-US/suspend-project.xml (bfaa12a)
>>  *   docs/en-US/sys-reliability-and-ha.xml (bdb36d0)
>>  *   docs/en-US/sysprep-for-windows-server-2003R2.xml (86e1667)
>>  *   docs/en-US/sysprep-windows-server-2008R2.xml (af36d15)
>>  *   docs/en-US/system-reserved-ip-addresses.xml (2f49225)
>>  *   docs/en-US/system-service-offerings.xml (75aa128)
>>  *   docs/en-US/tagging-resources.xml (PRE-CREATION)
>>  *   docs/en-US/time-zones.xml (d6d4bc7)
>>  *   docs/en-US/troubleshooting.xml (f3dc7d3)
>>  *   docs/en-US/tuning.xml (bcaaaa1)
>>  *   docs/en-US/ui.xml (4f7f327)
>>  *   docs/en-US/upgrade-management-server.xml (PRE-CREATION)
>>  *   docs/en-US/upload-template.xml (51aeb5a)
>>  *   docs/en-US/user-services-overview.xml (f9e38c0)
>>  *   docs/en-US/using-multiple-guest-networks.xml (ce71caa)
>>  *   docs/en-US/using-sshkeys.xml (b51569d)
>>  *   docs/en-US/vcenter-maintenance-mode.xml (a07300e)
>>  *   docs/en-US/virtual-machines.xml (PRE-CREATION)
>>  *   docs/en-US/virtual-router.xml (775d474)
>>  *   docs/en-US/vm-lifecycle.xml (f5696ce)
>>  *   docs/en-US/vm-storage-migration.xml (4b09ffd)
>>  *   docs/en-US/vmware-install.xml (PRE-CREATION)
>>  *   docs/en-US/vpc.xml (3899100)
>>  *   docs/en-US/vpn.xml (a459987)
>>  *   docs/en-US/windows-installation.xml (b6e0632)
>>  *   docs/en-US/work-with-usage.xml (e9fb1d8)
>>  *   docs/en-US/working-with-hosts.xml (fb4364b)
>>  *   docs/en-US/working-with-iso.xml (efe5fb5)
>>  *   docs/en-US/working-with-snapshots.xml (6145ffd)
>>  *   docs/en-US/working-with-system-vm.xml (016d579)
>>  *   docs/en-US/working-with-templates.xml (57a0a58)
>>  *   docs/en-US/working-with-volumes.xml (f4fce71)
>>  *   docs/en-US/xenserver-install.xml (PRE-CREATION)
>>  *   docs/en-US/xenserver-maintenance-mode.xml (4dfa43e)
>>
>> View Diff<https://reviews.apache.org/r/6978/diff/>
>>
>>
>>
>
>
> --
> NS
>



-- 
NS

Re: Review Request: apache 4.0 docs

Posted by Noah Slater <ns...@tumbolia.org>.
Okay cool, thanks. My concern was that we were developing code away from
the ASF Git repository. Which is always a temptation with DVCS systems. We
absolutely must not do this. It is one of the stipulations of using Git
responsibly at Apache. Code should be checked in early, and often, so that
the community can comment on it in bite-sized amounts. Monolithic patches
that land out of the middle of nowhere from someone's (local) private
branch are Not Coolâ„¢. Seems we're cool though! :-)

On Thu, Oct 4, 2012 at 11:48 AM, Prasanna Santhanam <
prasanna.santhanam@citrix.com> wrote:

> There is no "private" branch. Just a topic branch for autoscale on the
> asf repos.
>
> It was decided to have docs in a single branch earlier as discussed
> here: http://incubator.markmail.org/thread/mmke3j2bnqosfaeg
>
> And merge into the impending release branch before the release.
>
> --
> Prasanna.,
>
> On Thu, Oct 04, 2012 at 06:08:53AM -0400, Noah Slater wrote:
> > Just following up on this. What is a "private" branch?
> >
> > On Tue, Sep 25, 2012 at 9:26 AM, Noah Slater <ns...@tumbolia.org>
> wrote:
> >
> > > Can you clarify what you mean as "a private" branch?
> > >
> > >
> > > On Tue, Sep 11, 2012 at 10:28 AM, Radhika Puthiyetath <
> > > radhika.puthiyetath@citrix.com> wrote:
> > >
> > >> Hello Community,
> > >>
> > >> Here is one question: AutoScale code is committed to a private branch.
> > >> Where the autoscale documentation should go ?
> > >>
> > >> Documentation does not have a private branch yet. Therefore, I have
> > >> pushed the AutoScale documentation to the master  branch as of now.
> Do I
> > >> need to revert it ?
> > >>
> > >> Looking forward to the right direction in this matter.
> > >>
> > >> Thanks
> > >> -Radhika
> > >>
> > >>
> > >>
>
>


-- 
NS

Re: Review Request: apache 4.0 docs

Posted by Prasanna Santhanam <pr...@citrix.com>.
There is no "private" branch. Just a topic branch for autoscale on the
asf repos. 

It was decided to have docs in a single branch earlier as discussed
here: http://incubator.markmail.org/thread/mmke3j2bnqosfaeg

And merge into the impending release branch before the release.

-- 
Prasanna.,

On Thu, Oct 04, 2012 at 06:08:53AM -0400, Noah Slater wrote:
> Just following up on this. What is a "private" branch?
> 
> On Tue, Sep 25, 2012 at 9:26 AM, Noah Slater <ns...@tumbolia.org> wrote:
> 
> > Can you clarify what you mean as "a private" branch?
> >
> >
> > On Tue, Sep 11, 2012 at 10:28 AM, Radhika Puthiyetath <
> > radhika.puthiyetath@citrix.com> wrote:
> >
> >> Hello Community,
> >>
> >> Here is one question: AutoScale code is committed to a private branch.
> >> Where the autoscale documentation should go ?
> >>
> >> Documentation does not have a private branch yet. Therefore, I have
> >> pushed the AutoScale documentation to the master  branch as of now. Do I
> >> need to revert it ?
> >>
> >> Looking forward to the right direction in this matter.
> >>
> >> Thanks
> >> -Radhika
> >>
> >>
> >>