You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2008/02/29 19:38:51 UTC
[jira] Created: (SLING-298) FormEncoding parameter should be
ignored during POST processing
FormEncoding parameter should be ignored during POST processing
---------------------------------------------------------------
Key: SLING-298
URL: https://issues.apache.org/jira/browse/SLING-298
Project: Sling
Issue Type: Bug
Components: ujax
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574390#action_12574390 ]
Carsten Ziegeler commented on SLING-298:
----------------------------------------
I'm wondering if we could simplify the handling by saying that we require a "./" for setting properties and
everything else are special parameters?
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577128#action_12577128 ]
Tobias Bocanegra commented on SLING-298:
----------------------------------------
what about: X-HTTP-Charset, then ?
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573902#action_12573902 ]
Carsten Ziegeler commented on SLING-298:
----------------------------------------
I guess this has to do with SLING-299, if no parameter starting with "./" is set, FormEncoding is assumed to specify a property.
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574389#action_12574389 ]
Bertrand Delacretaz commented on SLING-298:
-------------------------------------------
> I guess this has to do with SLING-299, if no parameter starting with "./" is set, FormEncoding is assumed
> to specify a property.
Yes, IIRC that's how the logic works, and I agree that it's a problem in this case: FormEncoding will be stored if no other parameter is supplied.
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593006#action_12593006 ]
Tobias Bocanegra commented on SLING-298:
----------------------------------------
agreed.
+1 for using _charset_ and encouraging form creators to also set the "accept-charset" attribute in form elements.
(why didn't we know that before??):-)
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: Post Servlets
> Affects Versions: 2.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573895#action_12573895 ]
Carsten Ziegeler commented on SLING-298:
----------------------------------------
Then perhaps the processing of properties in the ujax post processor is wrong. Without my latest fix, the FormEncoding property was set on newly created nodes.
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592967#action_12592967 ]
Felix Meschberger commented on SLING-298:
-----------------------------------------
I think it is worth it using a special (well-known and exceptional) parameter for this kind of thing because (1) it is supported by the major browser vendors and (2) it fixes a problem, which would otherwise not be properly fixed.
+1 for using _charset_ and encouraging form creators to also set the "accept-charset" attribute in form elements.
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: Post Servlets
> Affects Versions: 2.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577016#action_12577016 ]
Felix Meschberger commented on SLING-298:
-----------------------------------------
> we might rename it to something more specific, like:
> X-HTTP-ContentType
Thinking about this and considering, that we prefix everything pertaining to Sling with the sling: prefix, why not do sling:formEncoding ?
X-HTTP-ContentType is not accurate because the property contains the character encoding and not the content type.
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577913#action_12577913 ]
Felix Meschberger commented on SLING-298:
-----------------------------------------
Because our parameters are not generally created in this X-** form but as sling:* or ujax:* (at least currently) ... Also, having it names according to other "system" parameters makes its handling (aka ignoring) in the UjaxPostServlet much easier ...
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-298) FormEncoding parameter should be ignored
during POST processing
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-298.
----------------------------------
Resolution: Fixed
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: Post Servlets
> Affects Versions: 2.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573909#action_12573909 ]
Tobias Bocanegra commented on SLING-298:
----------------------------------------
since the FormEncoding is used internally in sling as hint for a missing POST content type,
we might rename it to something more specific, like:
X-HTTP-ContentType
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-298) FormEncoding parameter
should be ignored during POST processing
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573893#action_12573893 ]
tripod edited comment on SLING-298 at 2/29/08 10:49 AM:
------------------------------------------------------------------
imo this should not be treated specially. just prefix all other props with "./" and you're set.
eg:
POST /foo/bar
FormEncoding = "utf-8"
./jcr:title = "hello"
was (Author: tripod):
imo this should be treated specially. just prefix all other props with "./" and you're set.
eg:
POST /foo/bar
FormEncoding = "utf-8"
./jcr:title = "hello"
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592824#action_12592824 ]
Carsten Ziegeler commented on SLING-298:
----------------------------------------
Ok, can we come to a consensus here and use the same prefix for FormEncoding as we use for other special post commands? (That's currently "sling:post:", but we'll change that to ":" soon)
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: Post Servlets
> Affects Versions: 2.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573893#action_12573893 ]
Tobias Bocanegra commented on SLING-298:
----------------------------------------
imo this should be treated specially. just prefix all other props with "./" and you're set.
eg:
POST /foo/bar
FormEncoding = "utf-8"
./jcr:title = "hello"
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: ujax
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-298) FormEncoding parameter should be
ignored during POST processing
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592965#action_12592965 ]
Carsten Ziegeler commented on SLING-298:
----------------------------------------
The alternative would be to use "_charset_" which is set by IE and Firefox, see http://www.crazysquirrel.com/computing/general/form-encoding.jspx
> FormEncoding parameter should be ignored during POST processing
> ---------------------------------------------------------------
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
> Issue Type: Bug
> Components: Post Servlets
> Affects Versions: 2.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> The FormEncoding parameter should be ignored during post processing and not be set as a property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.