[jira] [Commented] (TRAFODION-6) JDBC T2 has compilation errors when use -D_DEBUG option.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TRAFODION-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600507#comment-14600507 ] 

ASF GitHub Bot commented on TRAFODION-6:
----------------------------------------

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/5#discussion_r33215262
  
    --- Diff: core/conn/jdbc_type2/native/Debug.cpp ---
    @@ -183,8 +184,9 @@ static const char *UCase(const char *text)
     
     static unsigned long GetThreadId(void)
     {
    -	_TSLX_t thread_id = tslx_ext_pthread_self();
    -	return((unsigned long) thread_id.field1);
    +	//_TSLX_t thread_id = tslx_ext_pthread_self();
    +	//return((unsigned long) thread_id.field1);
    +        return pthread_self();
    --- End diff --
    
    Consider removing TSLX thread and pthread package references in T2 driver. T2 driver may not need to deal with threads at all. Also consider using syscall(SYS_gettid); to get the thread id to avoid pulling in pthread references.
    
    You should feel free to drop all wanted cpp and .h files related to threads


> JDBC T2 has compilation errors when use -D_DEBUG option.
> --------------------------------------------------------
>
>                 Key: TRAFODION-6
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-6
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: Weiqing Xu
>
> JDBC T2 native code has some debug code which can used to output the log, detect the memory leak. The code can be enabled by using -D_DEBUG compile option. But now there are some compilation errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)