You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2011/03/23 14:32:58 UTC
svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Author: dweiss
Date: Wed Mar 23 13:32:58 2011
New Revision: 1084583
URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
Log:
Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
Modified:
lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
==============================================================================
--- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
+++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
@@ -1182,14 +1182,8 @@
<!-- Clustering Component
http://wiki.apache.org/solr/ClusteringComponent
-
- You'll need to set the solr.cluster.enabled system property
- when running solr to run with clustering enabled:
-
- java -Dsolr.clustering.enabled=true -jar start.jar
-->
<searchComponent name="clustering"
- enable="${solr.clustering.enabled:false}"
class="solr.clustering.ClusteringComponent" >
<!-- Declare an engine -->
<lst name="engine">
@@ -1239,7 +1233,6 @@
-->
<requestHandler name="/clustering"
startup="lazy"
- enable="${solr.clustering.enabled:false}"
class="solr.SearchHandler">
<lst name="defaults">
<bool name="clustering">true</bool>
Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
==============================================================================
--- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
+++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
@@ -1,6 +1,5 @@
<h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
<div id="clusters">
- Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
</div>
<script type="text/javascript">
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Posted by Chris Hostetter <ho...@fucit.org>.
: we should not depend on contribs during test at all!
While i generally agree with this sentiment, it's important to keep the
context of these tests in mind:
Because we use to have problems with people tweaking the example configs
in ways that would inadvertantly cause them to break, we have tests in
place (like "SolrExampleTests") for the sole and explicit purpose of
running Solr using the example configs and doing some indexing/querying to
ensure that those configs are "ok"
(these tests should not be confused with other tests that use the example
configs for no particular reason and expect certain fields/options to
always be set in ways that are brittle and anoying when making
improvements to the configs -- the point is some of the tests are there to
*test* the example configs, others *reuses* the example configs out of
laziness)
With that in mind: if we're going to have the example configs refer to
contribs, it makes sense that when testing those example configs, we
should probably have those contrib jars compiled so we can test the full
example as people who use them would see it.
but i agree -- those jars should not be part of the classpath for
test-core, where inadvertent class dependencies might get overlooked.
I'm not sure that there really is a good way to have the best of both
worlds w/o pulling the "example" tests out of the current test hierarchy
completley, and moving them to their own jar run seperately after all
contribs have also been jar'ed up.
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Posted by Simon Willnauer <si...@googlemail.com>.
On Thu, Mar 24, 2011 at 10:10 AM, Dawid Weiss
<da...@cs.put.poznan.pl> wrote:
> Ok, I see what the problem is now -- I tested by making the solr
> distribution and running the clustering handler, not by running ant
> test.
>
> From what I see in the test infrastructure, contrib/ stuff is not
> included in classpath during default tests. We have a few options:
>
> 1) keep clustering handler optional in the example (no changes needed),
+1 to this
> 2) change the default in solrconfig to: solr.clustering.enabled:true
> and define a false sysproperty for tests to disable this handler,
> 3) add contrib/clustering classpath to main tests so that clustering
> gets loaded.
we should not depend on contribs during test at all!
simon
>
> Opinions?
>
> Dawid
>
>
> On Wed, Mar 23, 2011 at 10:49 PM, Dawid Weiss
> <da...@cs.put.poznan.pl> wrote:
>> Ooops, apologies -- I actually tested it locally before committing and
>> it did work... Are the automated tests different or not using
>> contribs? So, what do we do, keep the property?
>>
>> Dawid
>>
>> On Wed, Mar 23, 2011 at 6:55 PM, Grant Ingersoll <gs...@apache.org> wrote:
>>> Hmm, that's weird, as it should be the same as the other contribs.
>>>
>>> On Mar 23, 2011, at 11:37 AM, Robert Muir wrote:
>>>
>>>> I think this one breaks the build?
>>>>
>>>> now the example relies upon contrib/clustering, but core tests test
>>>> the example, so ant test fails.
>>>>
>>>> On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
>>>>> Author: dweiss
>>>>> Date: Wed Mar 23 13:32:58 2011
>>>>> New Revision: 1084583
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
>>>>> Log:
>>>>> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>>>>>
>>>>> Modified:
>>>>> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>>>>> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>>>>
>>>>> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>>>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
>>>>> ==============================================================================
>>>>> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
>>>>> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
>>>>> @@ -1182,14 +1182,8 @@
>>>>> <!-- Clustering Component
>>>>>
>>>>> http://wiki.apache.org/solr/ClusteringComponent
>>>>> -
>>>>> - You'll need to set the solr.cluster.enabled system property
>>>>> - when running solr to run with clustering enabled:
>>>>> -
>>>>> - java -Dsolr.clustering.enabled=true -jar start.jar
>>>>> -->
>>>>> <searchComponent name="clustering"
>>>>> - enable="${solr.clustering.enabled:false}"
>>>>> class="solr.clustering.ClusteringComponent" >
>>>>> <!-- Declare an engine -->
>>>>> <lst name="engine">
>>>>> @@ -1239,7 +1233,6 @@
>>>>> -->
>>>>> <requestHandler name="/clustering"
>>>>> startup="lazy"
>>>>> - enable="${solr.clustering.enabled:false}"
>>>>> class="solr.SearchHandler">
>>>>> <lst name="defaults">
>>>>> <bool name="clustering">true</bool>
>>>>>
>>>>> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
>>>>> ==============================================================================
>>>>> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
>>>>> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
>>>>> @@ -1,6 +1,5 @@
>>>>> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
>>>>> <div id="clusters">
>>>>> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
>>>>> </div>
>>>>> <script type="text/javascript">
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>
>>> --------------------------
>>> Grant Ingersoll
>>> http://www.lucidimagination.com/
>>>
>>> Search the Lucene ecosystem docs using Solr/Lucene:
>>> http://www.lucidimagination.com/search
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
Ok, I see what the problem is now -- I tested by making the solr
distribution and running the clustering handler, not by running ant
test.
>From what I see in the test infrastructure, contrib/ stuff is not
included in classpath during default tests. We have a few options:
1) keep clustering handler optional in the example (no changes needed),
2) change the default in solrconfig to: solr.clustering.enabled:true
and define a false sysproperty for tests to disable this handler,
3) add contrib/clustering classpath to main tests so that clustering
gets loaded.
Opinions?
Dawid
On Wed, Mar 23, 2011 at 10:49 PM, Dawid Weiss
<da...@cs.put.poznan.pl> wrote:
> Ooops, apologies -- I actually tested it locally before committing and
> it did work... Are the automated tests different or not using
> contribs? So, what do we do, keep the property?
>
> Dawid
>
> On Wed, Mar 23, 2011 at 6:55 PM, Grant Ingersoll <gs...@apache.org> wrote:
>> Hmm, that's weird, as it should be the same as the other contribs.
>>
>> On Mar 23, 2011, at 11:37 AM, Robert Muir wrote:
>>
>>> I think this one breaks the build?
>>>
>>> now the example relies upon contrib/clustering, but core tests test
>>> the example, so ant test fails.
>>>
>>> On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
>>>> Author: dweiss
>>>> Date: Wed Mar 23 13:32:58 2011
>>>> New Revision: 1084583
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
>>>> Log:
>>>> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>>>>
>>>> Modified:
>>>> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>>>> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>>>
>>>> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
>>>> ==============================================================================
>>>> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
>>>> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
>>>> @@ -1182,14 +1182,8 @@
>>>> <!-- Clustering Component
>>>>
>>>> http://wiki.apache.org/solr/ClusteringComponent
>>>> -
>>>> - You'll need to set the solr.cluster.enabled system property
>>>> - when running solr to run with clustering enabled:
>>>> -
>>>> - java -Dsolr.clustering.enabled=true -jar start.jar
>>>> -->
>>>> <searchComponent name="clustering"
>>>> - enable="${solr.clustering.enabled:false}"
>>>> class="solr.clustering.ClusteringComponent" >
>>>> <!-- Declare an engine -->
>>>> <lst name="engine">
>>>> @@ -1239,7 +1233,6 @@
>>>> -->
>>>> <requestHandler name="/clustering"
>>>> startup="lazy"
>>>> - enable="${solr.clustering.enabled:false}"
>>>> class="solr.SearchHandler">
>>>> <lst name="defaults">
>>>> <bool name="clustering">true</bool>
>>>>
>>>> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
>>>> ==============================================================================
>>>> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
>>>> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
>>>> @@ -1,6 +1,5 @@
>>>> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
>>>> <div id="clusters">
>>>> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
>>>> </div>
>>>> <script type="text/javascript">
>>>>
>>>>
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>> --------------------------
>> Grant Ingersoll
>> http://www.lucidimagination.com/
>>
>> Search the Lucene ecosystem docs using Solr/Lucene:
>> http://www.lucidimagination.com/search
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
Ooops, apologies -- I actually tested it locally before committing and
it did work... Are the automated tests different or not using
contribs? So, what do we do, keep the property?
Dawid
On Wed, Mar 23, 2011 at 6:55 PM, Grant Ingersoll <gs...@apache.org> wrote:
> Hmm, that's weird, as it should be the same as the other contribs.
>
> On Mar 23, 2011, at 11:37 AM, Robert Muir wrote:
>
>> I think this one breaks the build?
>>
>> now the example relies upon contrib/clustering, but core tests test
>> the example, so ant test fails.
>>
>> On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
>>> Author: dweiss
>>> Date: Wed Mar 23 13:32:58 2011
>>> New Revision: 1084583
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
>>> Log:
>>> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>>>
>>> Modified:
>>> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>>> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>>
>>> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
>>> ==============================================================================
>>> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
>>> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
>>> @@ -1182,14 +1182,8 @@
>>> <!-- Clustering Component
>>>
>>> http://wiki.apache.org/solr/ClusteringComponent
>>> -
>>> - You'll need to set the solr.cluster.enabled system property
>>> - when running solr to run with clustering enabled:
>>> -
>>> - java -Dsolr.clustering.enabled=true -jar start.jar
>>> -->
>>> <searchComponent name="clustering"
>>> - enable="${solr.clustering.enabled:false}"
>>> class="solr.clustering.ClusteringComponent" >
>>> <!-- Declare an engine -->
>>> <lst name="engine">
>>> @@ -1239,7 +1233,6 @@
>>> -->
>>> <requestHandler name="/clustering"
>>> startup="lazy"
>>> - enable="${solr.clustering.enabled:false}"
>>> class="solr.SearchHandler">
>>> <lst name="defaults">
>>> <bool name="clustering">true</bool>
>>>
>>> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
>>> ==============================================================================
>>> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
>>> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
>>> @@ -1,6 +1,5 @@
>>> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
>>> <div id="clusters">
>>> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
>>> </div>
>>> <script type="text/javascript">
>>>
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> --------------------------
> Grant Ingersoll
> http://www.lucidimagination.com/
>
> Search the Lucene ecosystem docs using Solr/Lucene:
> http://www.lucidimagination.com/search
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf: solrconfig.xml velocity/cluster.vm
Posted by Grant Ingersoll <gs...@apache.org>.
Hmm, that's weird, as it should be the same as the other contribs.
On Mar 23, 2011, at 11:37 AM, Robert Muir wrote:
> I think this one breaks the build?
>
> now the example relies upon contrib/clustering, but core tests test
> the example, so ant test fails.
>
> On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
>> Author: dweiss
>> Date: Wed Mar 23 13:32:58 2011
>> New Revision: 1084583
>>
>> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
>> Log:
>> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>>
>> Modified:
>> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>
>> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
>> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
>> @@ -1182,14 +1182,8 @@
>> <!-- Clustering Component
>>
>> http://wiki.apache.org/solr/ClusteringComponent
>> -
>> - You'll need to set the solr.cluster.enabled system property
>> - when running solr to run with clustering enabled:
>> -
>> - java -Dsolr.clustering.enabled=true -jar start.jar
>> -->
>> <searchComponent name="clustering"
>> - enable="${solr.clustering.enabled:false}"
>> class="solr.clustering.ClusteringComponent" >
>> <!-- Declare an engine -->
>> <lst name="engine">
>> @@ -1239,7 +1233,6 @@
>> -->
>> <requestHandler name="/clustering"
>> startup="lazy"
>> - enable="${solr.clustering.enabled:false}"
>> class="solr.SearchHandler">
>> <lst name="defaults">
>> <bool name="clustering">true</bool>
>>
>> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
>> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
>> @@ -1,6 +1,5 @@
>> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
>> <div id="clusters">
>> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
>> </div>
>> <script type="text/javascript">
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--------------------------
Grant Ingersoll
http://www.lucidimagination.com/
Search the Lucene ecosystem docs using Solr/Lucene:
http://www.lucidimagination.com/search
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Posted by Robert Muir <rc...@gmail.com>.
FYI i backed this out for now, so that ant test works.
On Wed, Mar 23, 2011 at 11:37 AM, Robert Muir <rc...@gmail.com> wrote:
> I think this one breaks the build?
>
> now the example relies upon contrib/clustering, but core tests test
> the example, so ant test fails.
>
> On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
>> Author: dweiss
>> Date: Wed Mar 23 13:32:58 2011
>> New Revision: 1084583
>>
>> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
>> Log:
>> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>>
>> Modified:
>> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>
>> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
>> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
>> @@ -1182,14 +1182,8 @@
>> <!-- Clustering Component
>>
>> http://wiki.apache.org/solr/ClusteringComponent
>> -
>> - You'll need to set the solr.cluster.enabled system property
>> - when running solr to run with clustering enabled:
>> -
>> - java -Dsolr.clustering.enabled=true -jar start.jar
>> -->
>> <searchComponent name="clustering"
>> - enable="${solr.clustering.enabled:false}"
>> class="solr.clustering.ClusteringComponent" >
>> <!-- Declare an engine -->
>> <lst name="engine">
>> @@ -1239,7 +1233,6 @@
>> -->
>> <requestHandler name="/clustering"
>> startup="lazy"
>> - enable="${solr.clustering.enabled:false}"
>> class="solr.SearchHandler">
>> <lst name="defaults">
>> <bool name="clustering">true</bool>
>>
>> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
>> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
>> @@ -1,6 +1,5 @@
>> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
>> <div id="clusters">
>> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
>> </div>
>> <script type="text/javascript">
>>
>>
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf: solrconfig.xml velocity/cluster.vm
Posted by Grant Ingersoll <gs...@apache.org>.
Hmm, that's weird, as it should be the same as the other contribs.
On Mar 23, 2011, at 11:37 AM, Robert Muir wrote:
> I think this one breaks the build?
>
> now the example relies upon contrib/clustering, but core tests test
> the example, so ant test fails.
>
> On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
>> Author: dweiss
>> Date: Wed Mar 23 13:32:58 2011
>> New Revision: 1084583
>>
>> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
>> Log:
>> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>>
>> Modified:
>> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>>
>> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
>> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
>> @@ -1182,14 +1182,8 @@
>> <!-- Clustering Component
>>
>> http://wiki.apache.org/solr/ClusteringComponent
>> -
>> - You'll need to set the solr.cluster.enabled system property
>> - when running solr to run with clustering enabled:
>> -
>> - java -Dsolr.clustering.enabled=true -jar start.jar
>> -->
>> <searchComponent name="clustering"
>> - enable="${solr.clustering.enabled:false}"
>> class="solr.clustering.ClusteringComponent" >
>> <!-- Declare an engine -->
>> <lst name="engine">
>> @@ -1239,7 +1233,6 @@
>> -->
>> <requestHandler name="/clustering"
>> startup="lazy"
>> - enable="${solr.clustering.enabled:false}"
>> class="solr.SearchHandler">
>> <lst name="defaults">
>> <bool name="clustering">true</bool>
>>
>> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
>> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
>> @@ -1,6 +1,5 @@
>> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
>> <div id="clusters">
>> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
>> </div>
>> <script type="text/javascript">
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--------------------------
Grant Ingersoll
http://www.lucidimagination.com/
Search the Lucene ecosystem docs using Solr/Lucene:
http://www.lucidimagination.com/search
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1084583 - in /lucene/dev/trunk/solr/example/solr/conf:
solrconfig.xml velocity/cluster.vm
Posted by Robert Muir <rc...@gmail.com>.
I think this one breaks the build?
now the example relies upon contrib/clustering, but core tests test
the example, so ant test fails.
On Wed, Mar 23, 2011 at 9:32 AM, <dw...@apache.org> wrote:
> Author: dweiss
> Date: Wed Mar 23 13:32:58 2011
> New Revision: 1084583
>
> URL: http://svn.apache.org/viewvc?rev=1084583&view=rev
> Log:
> Enabling the clustering handler by default (no need to specify solr.clustering.enabled=true).
>
> Modified:
> lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
> lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
>
> Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1084583&r1=1084582&r2=1084583&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
> +++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Wed Mar 23 13:32:58 2011
> @@ -1182,14 +1182,8 @@
> <!-- Clustering Component
>
> http://wiki.apache.org/solr/ClusteringComponent
> -
> - You'll need to set the solr.cluster.enabled system property
> - when running solr to run with clustering enabled:
> -
> - java -Dsolr.clustering.enabled=true -jar start.jar
> -->
> <searchComponent name="clustering"
> - enable="${solr.clustering.enabled:false}"
> class="solr.clustering.ClusteringComponent" >
> <!-- Declare an engine -->
> <lst name="engine">
> @@ -1239,7 +1233,6 @@
> -->
> <requestHandler name="/clustering"
> startup="lazy"
> - enable="${solr.clustering.enabled:false}"
> class="solr.SearchHandler">
> <lst name="defaults">
> <bool name="clustering">true</bool>
>
> Modified: lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm?rev=1084583&r1=1084582&r2=1084583&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm (original)
> +++ lucene/dev/trunk/solr/example/solr/conf/velocity/cluster.vm Wed Mar 23 13:32:58 2011
> @@ -1,6 +1,5 @@
> <h2 #annTitle("Clusters generated by Carrot2 using the /clustering RequestHandler")>Clusters</h2>
> <div id="clusters">
> - Run Solr with java -Dsolr.clustering.enabled=true -jar start.jar to see results
> </div>
> <script type="text/javascript">
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org